Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a mutable copy of input if inplace scaling is required #243

Merged
merged 4 commits into from
May 7, 2024

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Jan 31, 2024

This fixes the inverse Chebyshev transform for immutable input vectors. The following works now:

julia> ichebyshevtransform(1.0:4.0)
4-element Vector{Float64}:
  6.499813138042575
 -4.05147160887461
  1.808830921755324
 -0.25717245092328955

This throws an error on master, as the input doesn't support in-place assignment.

Copy link

codecov bot commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9f135a8) 82.70% compared to head (b54f6d7) 82.70%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #243   +/-   ##
=======================================
  Coverage   82.70%   82.70%           
=======================================
  Files          15       15           
  Lines        2688     2689    +1     
=======================================
+ Hits         2223     2224    +1     
  Misses        465      465           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jishnub
Copy link
Member Author

jishnub commented Apr 27, 2024

bump

@dlfivefifty dlfivefifty merged commit da3e865 into JuliaApproximation:master May 7, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants