Add copy for Eye and Diagonal(::AbstractFill) (#142)

JuliaArrays · Mar 18, 2021 · a7ce2f8 · a7ce2f8 · dlfivefifty · Mar 18, 2021
1 parent ee9bafd
commit a7ce2f8
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/Project.toml b/Project.toml
@@ -1,6 +1,6 @@
 name = "FillArrays"
 uuid = "1a297f60-69ca-5386-bcde-b61e274b549b"
-version = "0.11.6"
+version = "0.11.7"
 
 [deps]
 LinearAlgebra = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e"

diff --git a/src/FillArrays.jl b/src/FillArrays.jl
@@ -384,7 +384,7 @@ const Eye{T,Axes} = RectOrDiagonal{T,Ones{T,1,Tuple{Axes}}}
 isone(::SquareEye) = true
 
 # These should actually be in StdLib, LinearAlgebra.jl, for all Diagonal
-for f in (:permutedims, :triu, :triu!, :tril, :tril!)
+for f in (:permutedims, :triu, :triu!, :tril, :tril!, :copy)
     @eval ($f)(IM::Diagonal{<:Any,<:AbstractFill}) = IM
 end
 

diff --git a/test/runtests.jl b/test/runtests.jl
@@ -927,6 +927,7 @@ end
 @testset "Eye identity ops" begin
     m = Eye(10)
     D = Diagonal(Fill(2,10))
+
     for op in (permutedims, inv)
         @test op(m) === m
     end
@@ -938,6 +939,11 @@ end
             @test op(m) === m
         end
     end
+
+    @test copy(m) ≡ m
+    @test copy(D) ≡ D
+    @test LinearAlgebra.copy_oftype(m, Int) ≡ Eye{Int}(10)
+    @test LinearAlgebra.copy_oftype(D, Float64) ≡ Diagonal(Fill(2.0,10))
 end
 
 @testset "Issue #31" begin