Replace round with div (#298)

Use `div` with appropriate `RoundingMode` in `center` instead of `round`. This improves accuracy for large lengths.
JuliaArrays · Jun 6, 2022 · 1493303 · 1493303 · jishnub · Jun 6, 2022
1 parent 83ab52e
commit 1493303
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/Project.toml b/Project.toml
@@ -1,6 +1,6 @@
 name = "OffsetArrays"
 uuid = "6fe1bfb0-de20-5000-8ca7-80f57d26f881"
-version = "1.12.2"
+version = "1.12.3"
 
 [deps]
 Adapt = "79e6a3ab-5dfb-504d-930d-738a2a938a0e"

diff --git a/src/OffsetArrays.jl b/src/OffsetArrays.jl
@@ -705,6 +705,13 @@ _no_offset_view(::Any, A::AbstractUnitRange) = UnitRange(A)
 # These two helpers are deliberately not exported; their meaning can be very different in
 # other scenarios and will be very likely to cause name conflicts if exported.
 #####
+
+if VERSION < v"1.4"
+   _halfroundInt(v, r::RoundingMode) = round(Int, v/2, r)
+else
+   _halfroundInt(v, r::RoundingMode) = div(v, 2, r)
+end
+
 """
     center(A, [r::RoundingMode=RoundDown])::Dims
 
@@ -743,7 +750,7 @@ can use [`centered`](@ref OffsetArrays.centered).
 """
 function center(A::AbstractArray, r::RoundingMode=RoundDown)
     map(axes(A)) do inds
-        round(Int, (length(inds)-1)/2, r) + first(inds)
+        _halfroundInt(length(inds)-1, r) + first(inds)
     end
 end