[WIP] OrderedRobinDict #39
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oxinabox
previously approved these changes
May 25, 2020
oxinabox
reviewed
May 25, 2020
| @@ -0,0 +1,309 @@ | |||
| using DataStructures: RobinDict; | |||
There was a problem hiding this comment.
But DataStructures has a dependency on OrderedCollections
so you can’t have OrderedCollections depend on DataStructures
The OrderedRobinDict has a RobinDict typed field
oxinabox
reviewed
May 25, 2020
Comment on lines
+80
to
+82
| ccall(:jl_array_grow_end, Cvoid, (Any, UInt), hk, 1) | ||
| nk = length(hk) | ||
| @inbounds hk[nk] = key |
There was a problem hiding this comment.
Why are we doing this instead of just push!(hk, key ?
oxinabox
reviewed
May 25, 2020
| else | ||
| p = sortperm(d.keys; args...) | ||
| end | ||
| return LittleDict(d.keys[p], d.vals[p]) |
There was a problem hiding this comment.
this should not be a LittleDict it should be a OrderedRobinDict
Closed
|
This is stale and was last touched 4 years ago. If you still are interested in updating this, please don't hesitate to open a new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work on creating a generic ordered dictionary which can be easily extended to new
Dictdeveloped inDataStructures.jl.I'll be documenting my design process, and later publish that in a blog. In the meantime, bear with the lot of commits, sometimes unnecessary. At the end of the pipeline, all of them will be squashed into meaningful commits, which reflects the essential features of the design process.
Task for now
iterateaccordinglyrehash!. Implementcheck_for_rehashandrehash!