Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make upload_dataset(progress=) and download_dataset(quiet=) consistent #51

Open
mortenpi opened this issue Apr 26, 2024 · 0 comments
Open
Labels
enhancement New feature or request

Comments

@mortenpi
Copy link
Member

download_dataset has a quiet argument to suppress rclone's stdout (and other stuff). In #48 we added progress to upload_dataset (which decides whether to pass --progress to rlcone). We should make the arguments consistent somehow, but their behavior is subtly different.

  1. Just use quiet, deprecate progress.
  2. Just use progress, deprecate quiet.
  3. Use both, because their behavior is different.

I'm partial to (1): rclone is an implementation detail, so the only thing we can really promise is that there is no output at all, from anywhere.

@mortenpi mortenpi added the enhancement New feature or request label Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant