Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PRE REVIEW]: Extrae.jl: #168

Open
editorialbot opened this issue Jan 9, 2025 · 41 comments
Open

[PRE REVIEW]: Extrae.jl: #168

editorialbot opened this issue Jan 9, 2025 · 41 comments
Assignees
@luraess
Labels
Julia pre-review Ruby TeX

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Jan 9, 2025 •
edited
Loading

Submitting author: @mofeing (Sergio Sánchez Ramírez)
Repository: https://github.com/bsc-quantic/Extrae.jl
Branch with paper.md (empty if default branch):
Version: v0.2.0
Editor: @luraess
Reviewers: Pending
Managing EiC: Luca Ferranti

Status

status

Status badge code:

HTML: <a href="https://proceedings.juliacon.org/papers/fc8a16a70d639bc983ab00315b47a01c"><img src="https://proceedings.juliacon.org/papers/fc8a16a70d639bc983ab00315b47a01c/status.svg"></a>
Markdown: [![status](https://proceedings.juliacon.org/papers/fc8a16a70d639bc983ab00315b47a01c/status.svg)](https://proceedings.juliacon.org/papers/fc8a16a70d639bc983ab00315b47a01c)

Author instructions

Thanks for submitting your paper to JCON @mofeing. Currently, there isn't a JCON editor assigned to your paper.

The AEiC suggestion for the handling editor is @luraess.

@mofeing if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JCON submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper source files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.98  T=0.03 s (1294.9 files/s, 176299.5 lines/s)
--------------------------------------------------------------------------------
Language                      files          blank        comment           code
--------------------------------------------------------------------------------
TeX                               8            311            194           2565
Julia                             8            115            114            532
YAML                              6              0              2            175
SVG                               1              0              0            157
XML                               1             18              1             87
Markdown                          1             28              0             46
Ruby                              1              8              4             45
Bourne Again Shell                1              8              2             26
TOML                              3              4              0             20
JSON                              1              0              0             17
Bourne Shell                      2              5              0              9
--------------------------------------------------------------------------------
SUM:                             33            497            317           3679
--------------------------------------------------------------------------------

Commit count by author:

   108	Sergio Sánchez Ramírez
     7	Marc Clascà
     2	Mosè Giordano

@editorialbot
Copy link
Collaborator Author

⚠️ An error happened when generating the pdf. Problem with affiliations for Sergio Sanchez-Ramirez, perhaps the affiliations index need quoting?.

@editorialbot
Copy link
Collaborator Author 

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.1109/SC.2002.10004 is OK
- 10.1145/3404397.3404440 is OK
- 10.21105/jcon.00077 is OK
- 10.1016/j.jcp.2021.110467 is OK
- 10.5281/zenodo.3996439 is OK
- 10.5334/jors.151 is OK

🟡 SKIP DOIs

- No DOI given, and none found for title: Paraver: A tool to visualize and analyze parallel ...
- No DOI given, and none found for title: The international exascale software project roadma...
- No DOI given, and none found for title: Scalability of visualization and tracing tools
- No DOI given, and none found for title: Paraver: Reference Manual (Version 3.1)
- No DOI given, and none found for title: Extrae 4.2.3 documentation
- No DOI given, and none found for title: ScoreP.jl
- No DOI given, and none found for title: LIKWID.jl
- No DOI given, and none found for title: LinuxPerf.jl
- No DOI given, and none found for title: MPI.jl: Julia bindings for the Message Passing Int...
- No DOI given, and none found for title: IntelITT.jl
- No DOI given, and none found for title: MPITape.jl
- No DOI given, and none found for title: NVTX.jl
- No DOI given, and none found for title: Introduction to Paraver

❌ MISSING DOIs

- 10.1137/141000671 may be a valid DOI for title: Julia: A fresh approach to numerical computing
- 10.1016/j.procs.2017.05.203 may be a valid DOI for title: Performance analysis of parallel python applicatio...
- 10.1016/j.softx.2015.10.004 may be a valid DOI for title: COMP Superscalar, an interoperable programming fra...
- 10.1177/109434200001400303 may be a valid DOI for title: A portable programming interface for performance e...

❌ INVALID DOIs

- https://doi.org/10.1016/j.future.2024.07.050 is INVALID because of 'https://doi.org/' prefix

@lucaferranti
Copy link
Member

@editorialbot add @luraess as editor

@editorialbot
Copy link
Collaborator Author

Assigned! @luraess is now the editor

@editorialbot
Copy link
Collaborator Author

Paper file info:

📄 Wordcount for paper.tex is 3071

🔴 Failed to discover a Statement of need section in paper

@editorialbot
Copy link
Collaborator Author

License info:

✅ License found: Apache License 2.0 (Valid open source OSI approved license)

@luraess
Copy link

luraess commented Jan 13, 2025

Dear authors, thank you for submitting your work to the JuliaCon Proceedings. @mofeing could you please try to check and fix the invalid an missing DOIs and make sure none exist for the skipped once (see #168 (comment)). Also, there seems to be an issue with PDF generation (see #168 (comment)). In the meantime, I will be looking for reviewers.

@lucaferranti
Copy link
Member

@editorialbot assign @luraess as editor

@editorialbot editorialbot assigned luraess and unassigned luraess Jan 19, 2025
@editorialbot
Copy link
Collaborator Author

Assigned! @luraess is now the editor

@mofeing
Copy link

mofeing commented Jan 19, 2025

@luraess one question: changes like this should just be made to the repo where i have the paper uploaded (in this case, https://github.com/bsc-quantic/Extrae.jl) or do i need to submit it again?

@luraess
Copy link

luraess commented Jan 19, 2025

@luraess one question: changes like this should just be made to the repo where i have the paper uploaded (in this case, https://github.com/bsc-quantic/Extrae.jl) or do i need to submit it again?

No need to submit again. Ideally you'd provide a fix and ask the editorialbot to generate again the PDF. Thanks!

@mofeing
Copy link

mofeing commented Jan 20, 2025

@editorialbot commands

@editorialbot
Copy link
Collaborator Author

Hello @mofeing, here are the things you can ask me to do:


# List all available commands
@editorialbot commands

# Get a list of all editors's GitHub handles
@editorialbot list editors

# Adds a checklist for the reviewer using this command
@editorialbot generate my checklist

# Set a value for branch
@editorialbot set juliacon-paper as branch

# Run checks and provide information on the repository and the paper file
@editorialbot check repository

# Check the references of the paper for missing DOIs
@editorialbot check references

# Generates the pdf paper
@editorialbot generate pdf

# Generates a LaTeX preprint file
@editorialbot generate preprint

# Get a link to the complete list of reviewers
@editorialbot list reviewers

@mofeing
Copy link

mofeing commented Jan 20, 2025

@editorialbot check references

@editorialbot
Copy link
Collaborator Author 

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.1137/141000671 is OK
- 10.1177/1094342010391989 is OK
- 10.1016/j.procs.2017.05.203 is OK
- 10.1109/SC.2002.10004 is OK
- 10.1145/3404397.3404440 is OK
- 10.1016/j.future.2024.07.050 is OK
- 10.21105/jcon.00077 is OK
- 10.1016/j.jcp.2021.110467 is OK
- 10.5281/zenodo.3996439 is OK
- 10.5334/jors.151 is OK
- 10.1016/j.softx.2015.10.004 is OK
- 10.1177/109434200001400303 is OK

🟡 SKIP DOIs

- No DOI given, and none found for title: Paraver: A tool to visualize and analyze parallel ...
- No DOI given, and none found for title: Scalability of visualization and tracing tools
- No DOI given, and none found for title: Paraver: Reference Manual (Version 3.1)
- No DOI given, and none found for title: Extrae 4.2.3 documentation
- No DOI given, and none found for title: ScoreP.jl
- No DOI given, and none found for title: LIKWID.jl
- No DOI given, and none found for title: LinuxPerf.jl
- No DOI given, and none found for title: MPI.jl: Julia bindings for the Message Passing Int...
- No DOI given, and none found for title: IntelITT.jl
- No DOI given, and none found for title: MPITape.jl
- No DOI given, and none found for title: NVTX.jl
- No DOI given, and none found for title: Introduction to Paraver

❌ MISSING DOIs

- None

❌ INVALID DOIs

- None

@luraess
Copy link

luraess commented Jan 20, 2025

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

⚠️ An error happened when generating the pdf. Problem with affiliations for Sergio Sanchez-Ramirez, perhaps the affiliations index need quoting?.

@luraess
Copy link

luraess commented Jan 20, 2025

@mofeing you may need to remove the square brackets in the yml file for author affiliation to fix the error.

@mofeing
Copy link

mofeing commented Jan 20, 2025

@luraess DOIs are good now

@luraess
Copy link

luraess commented Jan 20, 2025

Yes - thanks! And PDF generation may be fixed upon formatting correctly the yaml file.

@mofeing
Copy link

mofeing commented Jan 20, 2025

sure, checking it now

@mofeing
Copy link

mofeing commented Jan 20, 2025

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

⚠️ An error happened when generating the pdf.

@luraess
Copy link

luraess commented Jan 20, 2025

Seems we're hitting

Package caption Warning: Unknown document class (or package),
(caption)                standard defaults will be used.
See the caption package documentation for explanation.

)

! LaTeX Error: Command \subcaption already defined.
               Or name \end... illegal, see p.192 of the manual.

in https://github.com/JuliaCon/proceedings-papers/actions/runs/12874309577/job/35893496045#step:3:222

@mofeing
Copy link

mofeing commented Jan 20, 2025

yes, the problem is that the JuliaCon document class defines \subcaption here
https://github.com/JuliaCon/JuliaConSubmission.jl/blob/8f2d1e7fc169d9622606b418768f429ce71bb390/paper/juliacon.cls#L138-L142

and it clashes with the subcaption package that i use for the subfigures...

let's see if undefining it before loading subcaption works

@mofeing
Copy link

mofeing commented Jan 20, 2025

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

⚠️ An error happened when generating the pdf.

@mofeing
Copy link

mofeing commented Jan 20, 2025

the problem now is that i'm using svg and i need to manually include the generated PDFs

@mofeing
Copy link

mofeing commented Jan 21, 2025

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

⚠️ An error happened when generating the pdf.

@mofeing
Copy link

mofeing commented Jan 21, 2025

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

⚠️ An error happened when generating the pdf.

@mofeing
Copy link

mofeing commented Jan 21, 2025

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@mofeing
Copy link

mofeing commented Jan 21, 2025

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

⚠️ An error happened when generating the pdf.

@mofeing
Copy link

mofeing commented Jan 21, 2025

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@mofeing
Copy link

mofeing commented Jan 21, 2025

i think everything is okay now @luraess

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@luraess luraess

Labels
Julia pre-review Ruby TeX
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mofeing @lucaferranti @luraess @editorialbot