Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW]: DistributedWorkflows.jl - A Julia interface to a task-based workflow management system. #181

Open
editorialbot opened this issue Feb 20, 2025 · 9 comments

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Feb 20, 2025

Submitting author: @FiroozehDastur (Firoozeh Dastur)
Repository: https://github.com/FiroozehDastur/DistributedWorkflows.jl.git
Branch with paper.md (empty if default branch): paper/juliacon2024
Version: v0.2.0
Editor: @luraess
Reviewers: @fieker, @fingolfin
Archive: Pending

Status

status

Status badge code:

HTML: <a href="https://proceedings.juliacon.org/papers/94cd77135d7372bab70cfc2f88db12f7"><img src="https://proceedings.juliacon.org/papers/94cd77135d7372bab70cfc2f88db12f7/status.svg"></a>
Markdown: [![status](https://proceedings.juliacon.org/papers/94cd77135d7372bab70cfc2f88db12f7/status.svg)](https://proceedings.juliacon.org/papers/94cd77135d7372bab70cfc2f88db12f7)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@fieker & @fingolfin, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @luraess know.

Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest

Checklists

📝 Checklist for @fieker

📝 Checklist for @fingolfin

@editorialbot
Copy link
Collaborator Author

Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper source files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.1007/978-1-4471-4276-8_10 is OK
- 10.1007/978-3-642-33278-4 is OK
- 10.1145/3452143.3465510 is OK
- 10.3847/1538-4357/aad8b4 is OK
- 10.1007/978-3-0348-8438-9_2 is OK
- 10.3997/2214-4609.20141914 is OK
- 10.1109/ISAV.2016.014 is OK
- 10.1007/978-3-030-43736-7_10 is OK
- 10.1109/5.24143 is OK
- 10.1371/journal.pone.0217913 is OK
- 10.1007/978-3-642-54420-0_5 is OK
- 10.1175/JCLI-D-21-0573.1 is OK
- 10.1109/TSMC.2012.2237549 is OK

🟡 SKIP DOIs

- No DOI given, and none found for title: ANTIC – Algebraic Number Theory In C
- No DOI given, and none found for title: ClusterManagers Julia Package
- No DOI given, and none found for title: CxxWrap.jl: Package to make C++ libraries availabl...
- No DOI given, and none found for title: Distributed.jl: Create and control multiple Julia ...
- No DOI given, and none found for title: Graphviz
- No DOI given, and none found for title: HDF5.jl File Format
- No DOI given, and none found for title: JLD2 File Format
- No DOI given, and none found for title: Pluto.jl — interactive Julia programming environme...
- No DOI given, and none found for title: Project Jupyter
- No DOI given, and none found for title: Dynamic Task Scheduling with Data Dependency Aware...
- No DOI given, and none found for title: Dask: Library for dynamic task scheduling
- No DOI given, and none found for title: DistributedWorkflows.jl - A Julia interface to a d...
- No DOI given, and none found for title: \sc Singular 4-4-0 — A computer algebra system for...
- No DOI given, and none found for title: GPI-Space
- No DOI given, and none found for title: GAP – Groups, Algorithms, and Programming, Version...
- No DOI given, and none found for title: OSCAR – Open Source Computer Algebra Research syst...
- No DOI given, and none found for title: Visualization and Analysis of Threats from Asteroi...
- No DOI given, and none found for title: Kommunikation mit Automaten
- No DOI given, and none found for title: Efficient Dynamic Task Scheduling in Heterogeneous...

❌ MISSING DOIs

- None

❌ INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.98  T=0.04 s (1530.7 files/s, 156126.7 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
TeX                              8            339            177           2797
Julia                           34            555            775           1146
Markdown                        11            157             12            385
YAML                             3              3              1             83
Ruby                             1              8              4             45
TOML                             3              2              0             26
SVG                              3              0              3              9
HTML                             1              0              0              1
-------------------------------------------------------------------------------
SUM:                            64           1064            972           4492
-------------------------------------------------------------------------------

Commit count by author:

    88	root
    53	FiroozehDastur
    11	Max Zeyen
     1	FiroozehAga

@editorialbot
Copy link
Collaborator Author

Paper file info:

🚨 Wordcount for paper.tex is 3818

🔴 Failed to discover a Statement of need section in paper

@editorialbot
Copy link
Collaborator Author

License info:

✅ License found: BSD 3-Clause "New" or "Revised" License (Valid open source OSI approved license)

@luraess
Copy link

luraess commented Feb 20, 2025

Hi all, thanks for following up here. Note that you can ignore the Failed to discover a Statement of need section in paper feedback as we do not explicitly enforce this in JCon submissions.

@fieker
Copy link

fieker commented Feb 20, 2025

Review checklist for @fieker

Conflict of interest

  • I confirm that I have read the JuliaCon conflict of interest policy and that: I have no COIs with reviewing this work or that any perceived COIs have been waived by JCon for the purpose of this review.

Code of Conduct

General checks

  • Repository: Is the source code for this software available at the https://github.com/FiroozehDastur/DistributedWorkflows.jl.git?
  • License: Does the repository contain a plain-text LICENSE or COPYING file with the contents of an OSI approved software license?
  • Contribution and authorship: Has the submitting author (@FiroozehDastur) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?

Functionality

  • Installation: Does installation proceed as outlined in the documentation?
  • Functionality: Have the functional claims of the software been confirmed?
  • Performance: If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)

Documentation

  • A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
  • Installation instructions: Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.
  • Example usage: Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).
  • Functionality documentation: Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?
  • Automated tests: Are there automated tests or manual steps described so that the functionality of the software can be verified?
  • Community guidelines: Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support

Paper format

  • Authors: Does the paper.pdf file include a list of authors with their affiliations?
  • A statement of need: Does the paper clearly explain the problem it addresses, its importance to the broader community, the intended audience, and how it connects to existing work in the field?
  • References: Do all archival references that should have a DOI list one (e.g., papers, datasets, software)?

Content

  • Context: is the scientific context motivating the work correctly presented?
  • Methodology: is the approach taken in the work justified, presented with enough details and reference to reproduce it?
  • Results: are the results presented and compared to approaches with similar goals?

@fingolfin
Copy link

fingolfin commented Feb 21, 2025

Review checklist for @fingolfin

Conflict of interest

  • I confirm that I have read the JuliaCon conflict of interest policy and that: I have no COIs with reviewing this work or that any perceived COIs have been waived by JCon for the purpose of this review.

Code of Conduct

General checks

  • Repository: Is the source code for this software available at the https://github.com/FiroozehDastur/DistributedWorkflows.jl.git?
  • License: Does the repository contain a plain-text LICENSE or COPYING file with the contents of an OSI approved software license?
  • Contribution and authorship: Has the submitting author (@FiroozehDastur) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?

Functionality

  • Installation: Does installation proceed as outlined in the documentation?
  • Functionality: Have the functional claims of the software been confirmed?
  • Performance: If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)

Documentation

  • A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
  • Installation instructions: Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.
  • Example usage: Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).
  • Functionality documentation: Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?
  • Automated tests: Are there automated tests or manual steps described so that the functionality of the software can be verified?
  • Community guidelines: Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support

Paper format

  • Authors: Does the paper.pdf file include a list of authors with their affiliations?
  • A statement of need: Does the paper clearly explain the problem it addresses, its importance to the broader community, the intended audience, and how it connects to existing work in the field?
  • References: Do all archival references that should have a DOI list one (e.g., papers, datasets, software)?

Content

  • Context: is the scientific context motivating the work correctly presented?
  • Methodology: is the approach taken in the work justified, presented with enough details and reference to reproduce it?
  • Results: are the results presented and compared to approaches with similar goals?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants