Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typejoin on Missing #63

Closed
bkamins opened this issue Dec 2, 2017 · 3 comments
Closed

typejoin on Missing #63

bkamins opened this issue Dec 2, 2017 · 3 comments

Comments

@bkamins
Copy link
Member

bkamins commented Dec 2, 2017

Currently:

julia> typejoin(Int, Missing)
Any

This is OK, but I guess we want Missing to be handled in a special way and it could be considered that typejoin returned Union{Int, Missing}. Any thoughts?

The rationale is that now unique with Missing union returns array of Any (and maybe there are other similar situations in other places):

julia> unique([missing,1, missing, 2, missing])
3-element Array{Any,1}:
  missing
 1
 2

This is not a huge problem, but it could be cleaner.

@nalimilan
Copy link
Member

Precisely. See JuliaLang/julia#24332. I'll update it once Missing will be merged in Base.

@bkamins
Copy link
Member Author

bkamins commented Dec 2, 2017

Close this issue then or keep for a reference?

@nalimilan
Copy link
Member

Given that there's an issue in Base, let's close this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants