promote_type -> promote_rule, add eltype for NoTangent

JuliaDiff · Sep 16, 2024 · 940d63f · 940d63f
1 parent b5396f7
commit 940d63f
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/src/rulesets/Base/indexing.jl b/src/rulesets/Base/indexing.jl
@@ -285,8 +285,9 @@ end
 _zero_fill!(dx::AbstractArray) = fill!(dx, zero(eltype(dx)))
 
 # Belong in ChainRulesCore
-Base.promote_type(T::Type{<:Number}, S::Type{<:AbstractZero}) = T
-Base.promote_type(T::Type{<:AbstractZero}, S::Type{<:Number}) = S
+Base.promote_rule(T::Type{<:Number}, S::Type{<:AbstractZero}) = T
+Base.promote_rule(T::Type{<:AbstractZero}, S::Type{<:Number}) = S
+Base.eltype(::Type{NoTangent}) = NoTangent
 
 function rrule(::typeof(∇eachslice), dys, x, vd::Val)
     function ∇∇eachslice(dz_raw)