From 940d63f866c037e15f2515d3cdf23cada9fe91ad Mon Sep 17 00:00:00 2001 From: Nicholas Bauer Date: Sun, 15 Sep 2024 23:55:44 -0400 Subject: [PATCH] promote_type -> promote_rule, add eltype for NoTangent --- src/rulesets/Base/indexing.jl | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/rulesets/Base/indexing.jl b/src/rulesets/Base/indexing.jl index e2523a8fa..430fd6f5b 100644 --- a/src/rulesets/Base/indexing.jl +++ b/src/rulesets/Base/indexing.jl @@ -285,8 +285,9 @@ end _zero_fill!(dx::AbstractArray) = fill!(dx, zero(eltype(dx))) # Belong in ChainRulesCore -Base.promote_type(T::Type{<:Number}, S::Type{<:AbstractZero}) = T -Base.promote_type(T::Type{<:AbstractZero}, S::Type{<:Number}) = S +Base.promote_rule(T::Type{<:Number}, S::Type{<:AbstractZero}) = T +Base.promote_rule(T::Type{<:AbstractZero}, S::Type{<:Number}) = S +Base.eltype(::Type{NoTangent}) = NoTangent function rrule(::typeof(∇eachslice), dys, x, vd::Val) function ∇∇eachslice(dz_raw)