Merge pull request #67 from devmotion/dw/remove_transpose_adjoint_conj

Remove rules for `conj`, `adjoint`, and `transpose`
JuliaDiff · Sep 18, 2021 · 6a001d2 · 6a001d2 · devmotion · Sep 18, 2021
2 parents d79d2d9 + 8dca5df
commit 6a001d2
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 4 deletions.
diff --git a/.github/workflows/downstream.yml b/.github/workflows/downstream.yml
@@ -18,6 +18,7 @@ jobs:
         os: [ubuntu-latest]
         package:
           - {user: JuliaDiff, repo: ForwardDiff.jl, group: All}
+          - {user: JuliaDiff, repo: ReverseDiff.jl, group: All}
           - {user: FluxML, repo: Tracker.jl, group: All}
           - {user: FluxML, repo: Zygote.jl, group: All}
           - {user: invenia, repo: Nabla.jl, group: All}

diff --git a/Project.toml b/Project.toml
@@ -1,6 +1,6 @@
 name = "DiffRules"
 uuid = "b552c78f-8df3-52c6-915a-8e097449b14b"
-version = "1.3.0"
+version = "1.3.1"
 
 [deps]
 NaNMath = "77ba4419-2d1f-58cd-9bb1-8ffee604a2e3"

diff --git a/src/rules.jl b/src/rules.jl
@@ -67,9 +67,6 @@
 @define_diffrule SpecialFunctions.loggamma(x) =
     :(  SpecialFunctions.digamma($x)  )
 
-@define_diffrule Base.conj(x)                 = :(  1                                  )
-@define_diffrule Base.adjoint(x)              = :(  1                                  )
-@define_diffrule Base.transpose(x)            = :(  1                                  )
 @define_diffrule Base.abs(x)                  = :( DiffRules._abs_deriv($x)            )
 
 # We provide this hook for special number types like `Interval`