Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for Flux in [weakdeps] to 0.15 for package DifferentiationInterfaceTest, (keep existing compat) #658

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Dec 6, 2024

This pull request changes the compat entry for the Flux package from 0.13,0.14 to 0.13,0.14, 0.15 for package DifferentiationInterfaceTest.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@github-actions github-actions bot requested a review from gdalle as a code owner December 6, 2024 01:54
…DifferentiationInterfaceTest, (keep existing compat)
@gdalle gdalle force-pushed the compathelper/new_version/2024-12-06-01-54-30-058-03062892327 branch from 76ad572 to 046963d Compare December 6, 2024 01:54
Copy link

codecov bot commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.88%. Comparing base (3abcee1) to head (046963d).

❗ There is a different number of reports uploaded between BASE (3abcee1) and HEAD (046963d). Click for more details.

HEAD has 67 uploads less than BASE
Flag BASE (3abcee1) HEAD (046963d)
DI 70 11
DIT 16 8
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #658       +/-   ##
===========================================
- Coverage   97.58%   79.88%   -17.70%     
===========================================
  Files         111      109        -2     
  Lines        5552     5514       -38     
===========================================
- Hits         5418     4405     -1013     
- Misses        134     1109      +975     
Flag Coverage Δ
DI 71.77% <ø> (-26.97%) ⬇️
DIT 95.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdalle
Copy link
Member

gdalle commented Dec 6, 2024

@CarloLucibello this is the offending PR, if you want to take a crack

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant