Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Good-Turing probabilities estimator #406

Open
kahaaga opened this issue Jun 4, 2024 · 2 comments
Open

Good-Turing probabilities estimator #406

kahaaga opened this issue Jun 4, 2024 · 2 comments
Labels
enhancement New feature or request that is non-breaking new probabilities New probabilities estimator

Comments

@kahaaga
Copy link
Member

kahaaga commented Jun 4, 2024

Describe the feature you'd like to have

At some point, I had implemented the Good-Turing probabilities estimator. I'm not sure if it disappeared from the list of estimators, or if I forgot to push a PR for it. In any case: we should include it.

Cite scientific papers related to the feature/algorithm

This paper, for example, uses a variant of it that we should implement.
This reference is also useful

@kahaaga kahaaga added enhancement New feature or request that is non-breaking new probabilities New probabilities estimator labels Jun 4, 2024
@Datseris
Copy link
Member

Datseris commented Jun 4, 2024

I didn't delete any branches, and the only other branch that is pushed is about Pal differential entropy estimator (2690eac) . Unfortunately you likely forgot to push :( I hope you can find the code!

@kahaaga
Copy link
Member Author

kahaaga commented Jun 4, 2024

:( Well well, no worries. I had a quite prolific period of implementing new things just before we started reorganising the package, so there's a bit of a backlog on things that should be included here. I'm sure I can dig up the code from somewhere :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request that is non-breaking new probabilities New probabilities estimator
Projects
None yet
Development

No branches or pull requests

2 participants