Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compat with SciMLBase 2.11 #132

Closed
hexaeder opened this issue Dec 15, 2023 · 3 comments
Closed

Fix compat with SciMLBase 2.11 #132

hexaeder opened this issue Dec 15, 2023 · 3 comments

Comments

@hexaeder
Copy link
Member

https://github.com/SciML/SymbolicIndexingInterface.jl

is the way to go to access symbols moving forward. would resolve the restriction introduced in #131

@Datseris
Copy link
Member

Hi @hexaeder can you please tell me how you learned of this package? I am trying to follow this as I also use symbolic indexing but I haven't heard of this package yet. Are there some specific channels you follow? E.g., this isn't posted in diffeq-bridged on slack.

@hexaeder
Copy link
Member Author

Well nothing of that sort, I just realized that it broke my docs in GraphMakie where I use NetworkDynamics and I was able to track it down to this SciMLBase-PR which altered the struct definition 3 days ago and asked there... Chris also posted a link to the docs of the new package there.

I think it's inevitable, the core mechanism of NetworkDynamics was written many years ago when the SciML ecosystem was in a completely different shape. Luckily next year we'll have funding to do a proper rework and hopefully get rid of those kind of hacks :)

@hexaeder
Copy link
Member Author

hexaeder commented Sep 4, 2024

fixed in #140

@hexaeder hexaeder closed this as completed Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants