Porting Schmelcher-Diakonos #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why? Why not in this PR? |
|
the docstring is already 90% of the documentation and that is here. |
|
I added the docs. |
|
I need to first look at the main interface and then I will review here. |
Datseris
approved these changes
Sep 17, 2024
|
I am approving this as it is for me easier to give a fresh review of the whole codebase later by opening an issue (unfortunately I am too busy now as the term started and i have to prepare courses) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EDIT: Porting Schmelcher-Diakonos algorithm that is currently in ChaosTools.jl into this repository. This PR contains algorithm, docs and tests.