Fix libhib discovery for Windows #722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BSchilperoort
approved these changes
Jan 11, 2025
There was a problem hiding this comment.
Tested it on my machine, works now with ROCm 6.2.
At first it grabbed my renamed copy of amdhip64, but after deleting that one it grabs the amdhip64_6 file.
I was also able to succesfully run a ParallelStencil workflow on my 7800XT
Thanks for fixing this! The code also looks a lot better now, and is much more concise.
|
Great! Thanks for testing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And remove some sketchy code for artifact loading.
Closes #721.
@BSchilperoort, hopefully fixes the issue. If you can test and confirm that'd be great!