Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LLVM 20: Adapt to LDG removal #2531

Open
maleadt opened this issue Oct 28, 2024 · 0 comments · May be fixed by #2655
Open

LLVM 20: Adapt to LDG removal #2531

maleadt opened this issue Oct 28, 2024 · 0 comments · May be fixed by #2655

Comments

@maleadt
Copy link
Member

maleadt commented Oct 28, 2024

It has been removed in favor of !invariant.load: llvm/llvm-project#112834
@vchuravy vchuravy linked a pull request Feb 13, 2025 that will close this issue
Draft
vchuravy added a commit to JuliaLang/julia that referenced this issue Feb 13, 2025
@vchuravy
Only strip invariant.load from special pointers
8d29aa2 
Other backends (in this case NVPTX) require that `invariant.load`
metadata is maintained to generate non-coherent loads.

Currently, we unconditionally strip that metadata from all loads,
since our other uses of it may have become invalid.

x-ref: llvm/llvm-project#112834 JuliaGPU/CUDA.jl#2531
@vchuravy vchuravy mentioned this issue Feb 13, 2025
Merged
vchuravy added a commit to JuliaLang/julia that referenced this issue Feb 18, 2025
@vchuravy @gbaraldi
Only strip invariant.load from special pointers (#57386)
29da86b 
Other backends (in this case NVPTX) require that `invariant.load`
metadata is maintained to generate non-coherent loads.

Currently, we unconditionally strip that metadata from all loads,
since our other uses of it may have become invalid.

x-ref: llvm/llvm-project#112834
JuliaGPU/CUDA.jl#2531

---------

Co-authored-by: Gabriel Baraldi <[email protected]>
KristofferC pushed a commit to JuliaLang/julia that referenced this issue Feb 21, 2025
@vchuravy @KristofferC
Only strip invariant.load from special pointers (#57386)
3c58c10 
Other backends (in this case NVPTX) require that `invariant.load`
metadata is maintained to generate non-coherent loads.

Currently, we unconditionally strip that metadata from all loads,
since our other uses of it may have become invalid.

x-ref: llvm/llvm-project#112834
JuliaGPU/CUDA.jl#2531

---------

Co-authored-by: Gabriel Baraldi <[email protected]>
(cherry picked from commit 29da86b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use invariant.load for ldg JuliaGPU/CUDA.jl
1 participant
@maleadt