More alloc cache improvements #583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's not safe to concurrently access a dict while it may be mutated.
|
Thanks! I'll take a look at it this evening |
pxl-th
reviewed
Jan 10, 2025
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
maleadt
force-pushed
the
tb/alloc_cache
branch
from
fbdc064 to
07571f8
Compare
pxl-th
approved these changes
Jan 14, 2025
| "Invalidating inside `@cached` is not allowed." | ||
| ) | ||
| for pool in values(cache.busy) | ||
| isempty(pool) || error("Cannot invalidate a cache that's in active use") |
There was a problem hiding this comment.
Maybe check that the pool is empty and that the cache is in use (reading ScopedValue). Otherwise, if an exception happens during @cached it will raise this in the cache finalizer.
There was a problem hiding this comment.
That sounds questionable. Shouldn't @cached instead have a try/catch (well, the scope-less variety) that wipes the cache in the finally block, making sure the cache is always in a known-good state outside of the @cached block?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The manual refcount fiddling is a bit dangerous (it should be compatible with manual
unsafe_free!s and the GC), but I think is correct. @pxl-th Maybe test with one of your apps using this? Ideally, first adapt your back-end to key on bufsize instead of dims and remove T.