Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add transform method for coordinate transformations #35

Merged
merged 6 commits into from
Jan 2, 2024
Merged

Conversation

rafaqz
Copy link
Member

@rafaqz rafaqz commented Dec 28, 2023

Closes #34

This PR adds a simple transform function that converts points to SVector on the fly, transforms them using some transformation from CoordinateTransformations.jl or Rotations.jl, and rebuilds the object around the new points.

Like a few of the other transformation methods, this function is a pretty basic use of apply. But I think it may not seem obvious to people that you can do this so easily so it's worth having.

@rafaqz rafaqz requested a review from skygering December 28, 2023 23:02
@rafaqz
Copy link
Member Author

rafaqz commented Jan 1, 2024

Any comments on this @skygering

@skygering
Copy link
Collaborator

@rafaqz Looks good other than my one comment. Sorry for the delay!

@rafaqz rafaqz merged commit 135be02 into main Jan 2, 2024
4 checks passed
@rafaqz rafaqz deleted the transform branch January 2, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support CoodinateTransformations.jl and Rotations.jl
2 participants