Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix testset string interpolation #198

Merged
merged 3 commits into from
Aug 10, 2024
Merged

fix testset string interpolation #198

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ab80ead
fix testset string interpolation
rafaqz Aug 10, 2024
a8f8dab
must be a string or string expression
rafaqz Aug 10, 2024
54562b6
use the LINE macro not manual
rafaqz Aug 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions test/helpers.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,8 +88,15 @@ function _testset_implementations_inner(title, modules::Union{Expr,Vector}, code
for (var, genkey) in pairs(vars)
push!(expr.args, :($genkey = $GeoInterface.convert($mod, $var)))
end
label = title == "" ? "$mod" : "$title: $mod"
push!(expr.args, :(@testset $label $code1))
# Manually define the testset macrocall and all string interpolation
testset = Expr(
:macrocall,
Symbol("@testset"),
LineNumberNode(@__LINE__, @__FILE__),
Expr(:string, mod, " ", title),
code1
)
push!(expr.args, testset)
push!(testsets.args, expr)
end

Expand Down
Loading