Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Letting users opt out of ExactPredicates? #122

Closed
DanielVandH opened this issue Jul 6, 2024 · 1 comment · Fixed by #131
Closed

Letting users opt out of ExactPredicates? #122

DanielVandH opened this issue Jul 6, 2024 · 1 comment · Fixed by #131
Labels
enhancement New feature or request good first issue Good for newcomers question Further information is requested

Comments

@DanielVandH
Copy link
Member

Should there be an option to allow users to opt out of ExactPredicates? It's a risky option but maybe if user's trust there are no issues with their data then it isn't too bad to let them do it. Could help users get more performance, e.g. in the case of DanielVandH/NaturalNeighbours.jl#34.

Not sure the best way to do this without worsening performance in general from the predicate functions having to do a check of whether exact predicates are allowed. I guess this is the point of Preferences.jl.

@DanielVandH DanielVandH added enhancement New feature or request good first issue Good for newcomers question Further information is requested labels Jul 6, 2024
@DanielVandH
Copy link
Member Author

I also note that, if we let this be an option, it needs to be made extremely clear to the users what the consequences could be. Infinite loops are likely to occur when dealing with cocircular point sets, collinear edges, and points that are extremely close to each other.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant