Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable deepcopy on PolygonTrees #129

Closed
DanielVandH opened this issue Jul 6, 2024 · 1 comment · Fixed by #199
Closed

Re-enable deepcopy on PolygonTrees #129

DanielVandH opened this issue Jul 6, 2024 · 1 comment · Fixed by #199
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@DanielVandH
Copy link
Member

Haven't been able to get a proper MWE yet. Running the polygon_hierarchy test file just sometimes segfaults in the first code block. Going to disable deepcopy temporarily, but a better fix is needed. (deepcopy isn't really the best thing to do on triangulations anyway [and probably is broken somewhere anyway due to some aliasing between fields], so I don't even hate the idea of throwing if someone tries to deepcopy a Triangulation but too late.)
@DanielVandH DanielVandH added the bug Something isn't working label Jul 6, 2024
@DanielVandH DanielVandH mentioned this issue Jul 6, 2024
Merged
@DanielVandH DanielVandH changed the title Deepcopy on PolygonHierarchys sometimes segfaults Re-enable deepcopy on PolygonTrees Jul 7, 2024
@DanielVandH
Copy link
Member Author

I think a solution to this is to just make deepcopy rebuild the PolygonTree directly? No need for recursive deepcopying. I think.

@DanielVandH DanielVandH added the good first issue Good for newcomers label Jul 16, 2024
@DanielVandH DanielVandH mentioned this issue Jul 21, 2024
Closed
@DanielVandH DanielVandH mentioned this issue Oct 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix copy and deepcopy for PolygonTrees and PolygonHierarchys JuliaGeometry/DelaunayTriangulation.jl
1 participant
@DanielVandH