Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for ExactPredicates to be toggled #131

Merged
merged 14 commits into from
Jul 8, 2024
Merged

Allow for ExactPredicates to be toggled #131

merged 14 commits into from
Jul 8, 2024

Conversation

DanielVandH
Copy link
Member

@DanielVandH DanielVandH commented Jul 7, 2024

Fixes #122

  • Adds Preferences.jl as a new dependency
  • Fixed the unused orient(p, q, r, s)
  • Added getz/_getz/getxyz/_getxyz
  • Added a missing license from ExactPredicates.jl
  • Allow users to toggle off ExactPredicates.jl using Preferences.jl, allowing simple determinant calculations to be used. This won't make much difference in most cases I imagine, except for the fact that when a user needs ExactPredicates.jl they will only be able to find out through an error (if they toggled it off).

TODO:

  • Document how to toggle it off
  • Add a warning to users about consequences of not using ExactPredicates
  • Put validate_triangulation into the package to allow users to make sure their triangulatiosn are sensible if they want that safety.
  • Fix CI to test preferences

Copy link

codecov bot commented Jul 7, 2024

Codecov Report

Attention: Patch coverage is 98.67257% with 3 lines in your changes missing coverage. Please review.

Project coverage is 94.57%. Comparing base (35b7ec2) to head (cea95ca).
Report is 2 commits behind head on main.

Files Patch % Lines
src/validation.jl 98.10% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #131      +/-   ##
==========================================
- Coverage   95.32%   94.57%   -0.76%     
==========================================
  Files          92       93       +1     
  Lines        9139     9785     +646     
==========================================
+ Hits         8712     9254     +542     
- Misses        427      531     +104     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DanielVandH DanielVandH merged commit 4a09945 into main Jul 8, 2024
9 of 10 checks passed
@DanielVandH DanielVandH deleted the preds branch July 8, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Letting users opt out of ExactPredicates?
1 participant