Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try out Runic formatting #138

Closed
wants to merge 1 commit into from
Closed

Try out Runic formatting #138

wants to merge 1 commit into from

Conversation

DanielVandH
Copy link
Member

Hopefully doesn't break everything

Will have to update the files again after fredrikekre/Runic.jl#15 is addressed

@codecov Codecov
Copy link

codecov bot commented Jul 12, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 95.89372% with 17 lines in your changes missing coverage. Please review.

Project coverage is 94.11%. Comparing base (49a6580) to head (f8b4105).

Files Patch % Lines
...orithms/triangulation/constrained_triangulation.jl 92.10% 3 Missing ⚠️
...c/data_structures/triangulation/adjacent2vertex.jl 92.85% 3 Missing ⚠️
src/algorithms/point_location/jump_and_march.jl 90.00% 2 Missing ⚠️
src/data_structures/polygon.jl 50.00% 2 Missing ⚠️
...c/data_structures/triangulation/methods/weights.jl 0.00% 2 Missing ⚠️
src/algorithms/point_location/brute_force.jl 50.00% 1 Missing ⚠️
...entative_coordinates/representative_coordinates.jl 80.00% 1 Missing ⚠️
src/data_structures/trees/polygon_hierarchy.jl 90.90% 1 Missing ⚠️
...triangulation/methods/representative_point_list.jl 75.00% 1 Missing ⚠️
src/validation.jl 92.85% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #138      +/-   ##
==========================================
- Coverage   94.59%   94.11%   -0.48%     
==========================================
  Files          94       94              
  Lines        9785     9786       +1     
==========================================
- Hits         9256     9210      -46     
- Misses        529      576      +47

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

fredrikekre
fredrikekre reviewed Jul 13, 2024
View reviewed changes
docs/liveserver.jl
Comment on lines +7 to +8
LiveServer.servedocs(
;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This look a bit stupid -- The ; should be directly after the opening ( I think.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that would be better

Copy link

@fredrikekre fredrikekre Jul 21, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed on Runic master

docs/make.jl
@@ -20,6 +24,7 @@ function safe_include(filename)
end
const session_tmp = mktempdir()


Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you manually insert all of these extra newlines? I am guessing this could be another Windows-related line ending bug if not.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't do anything after running the formatter. It looks like the bug since it looked fine originally https://github.com/JuliaGeometry/DelaunayTriangulation.jl/blob/main/docs/make.jl

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fixed in JuliaSyntax 0.4.9

src/algorithms/triangulation/basic_operations/add_point.jl
update_representative_point=update_representative_point,
store_event_history=store_event_history,
event_history=event_history,
is_true(peek) ? (new_point_x, new_point_y) : num_points(tri);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't be indented.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been fixed om Runic master

@fredrikekre fredrikekre mentioned this pull request Jul 17, 2024
Closed
@fredrikekre
Copy link

Try again with [email protected] and Runic master? Probably have to reset the commit first because Runic will not revert some of these changes once they are in the source.

@DanielVandH DanielVandH deleted the r2 branch August 16, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredrikekre fredrikekre fredrikekre left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DanielVandH @fredrikekre