Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try Runic formatting again #141

Closed
wants to merge 9 commits into from
Closed

Try Runic formatting again #141

wants to merge 9 commits into from

Conversation

DanielVandH
Copy link
Member

@fredrikekre

Seems much better now

@DanielVandH
Copy link
Member Author

Hmm seems to have introduced another parsing error

Copy link

codecov bot commented Jul 21, 2024

Codecov Report

Attention: Patch coverage is 96.22926% with 25 lines in your changes missing coverage. Please review.

Project coverage is 94.74%. Comparing base (49a6580) to head (b878880).

Files Patch % Lines
...orithms/triangulation/constrained_triangulation.jl 92.10% 3 Missing ⚠️
src/data_structures/triangulation/adjacent.jl 91.17% 3 Missing ⚠️
...c/data_structures/triangulation/adjacent2vertex.jl 92.85% 3 Missing ⚠️
src/algorithms/point_location/jump_and_march.jl 90.00% 2 Missing ⚠️
src/data_structures/polygon.jl 50.00% 2 Missing ⚠️
...c/data_structures/triangulation/methods/weights.jl 0.00% 2 Missing ⚠️
src/geometric_primitives/boundary_nodes.jl 91.66% 2 Missing ⚠️
src/algorithms/point_location/brute_force.jl 50.00% 1 Missing ⚠️
src/data_structures/mesh_refinement/curves.jl 98.90% 1 Missing ⚠️
...entative_coordinates/representative_coordinates.jl 80.00% 1 Missing ⚠️
... and 5 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #141      +/-   ##
==========================================
+ Coverage   94.59%   94.74%   +0.15%     
==========================================
  Files          94       94              
  Lines        9785     9789       +4     
==========================================
+ Hits         9256     9275      +19     
+ Misses        529      514      -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DanielVandH DanielVandH reopened this Jul 21, 2024
@DanielVandH
Copy link
Member Author

Seems great now! Thanks @fredrikekre for the help / fixing the issues. Going to close this and re-format later after some other changes I'm doing, but I really like the tool.

@fredrikekre
Copy link

Thanks for beta-testing and reporting issues! Keep pinging me if you find stuff.

@DanielVandH DanielVandH deleted the runic2 branch August 16, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants