Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #175

Merged
merged 3 commits into from
Sep 29, 2023
Merged

Update README.md #175

merged 3 commits into from
Sep 29, 2023

Conversation

ufechner7
Copy link
Member

Fix running the examples.

Fix running the examples.
@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (73b0707) 88.81% compared to head (202a139) 88.81%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #175   +/-   ##
=======================================
  Coverage   88.81%   88.81%           
=======================================
  Files           3        3           
  Lines         438      438           
=======================================
  Hits          389      389           
  Misses         49       49           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@barche
Copy link
Collaborator

barche commented Sep 28, 2023

What is wrong with the Makie examples? They run for me on Linux, Windows and Mac.

p.s. I gave you access to the repository

enable Makie examples
@ufechner7
Copy link
Member Author

Better now?

@barche
Copy link
Collaborator

barche commented Sep 29, 2023

Sorry, I totally misread this last night, I thought this was about running the examples in the CI. runexamples is actually intended to be used for CI, so maybe it's better to use uniform instructions based on the readme in the examples: https://github.com/barche/QmlJuliaExamples#qmljuliaexamples ? Maybe extend thos instructions a little to not use a temporary directory?

@ufechner7
Copy link
Member Author

I agree, that would be better. On the other hand I think it important the the first example in the README.md file works, and this commit would already fix it.

@barche
Copy link
Collaborator

barche commented Sep 29, 2023

I have removed the call to runexamples and used LibGit2 instead of the git command, since I'm not sure git will always be in the path. The runexamples function is meant for CI and not exported, so I prefer not to mention it at all. Is this OK for you?

1 similar comment
@barche
Copy link
Collaborator

barche commented Sep 29, 2023

I have removed the call to runexamples and used LibGit2 instead of the git command, since I'm not sure git will always be in the path. The runexamples function is meant for CI and not exported, so I prefer not to mention it at all. Is this OK for you?

@ufechner7
Copy link
Member Author

Perfect!

@ufechner7 ufechner7 merged commit 97e111d into JuliaGraphics:main Sep 29, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants