Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Metal #344

Open
CarloLucibello opened this issue Sep 18, 2023 · 8 comments
Open

Support Metal #344

CarloLucibello opened this issue Sep 18, 2023 · 8 comments

Comments

@CarloLucibello
Copy link
Member

Needs gather/scatter kernels in NNlib

@Dsantra92
Copy link
Collaborator

Is there a metal support planned for NNlib?

@CarloLucibello
Copy link
Member Author

It could be the case that gather/scatter already work on metal arrays thanks to FluxML/NNlib.jl#487, but it has not been tested yet. Do you have access to some apple silicon?

Or we can add some metal tests on NNlib and execute them on buildkite (e.g. Flux.jl is already testing metal support (https://github.com/FluxML/Flux.jl/blob/master/.buildkite/pipeline.yml)

@Dsantra92
Copy link
Collaborator

I have access to a base variant of apple silicon. I would be happy to test some of these out.

@CarloLucibello
Copy link
Member Author

See FluxML/NNlib.jl#534

@achiverram28
Copy link
Contributor

achiverram28 commented Mar 6, 2024

I am having the macbook pro m2 pro . I would like to test the metal support with this

@achiverram28
Copy link
Contributor

Checked out , gather works , but scatter fails due to ERROR: Compilation to native code failed
Yes , this is also pointed out in FluxML/NNlib.jl#534

@CarloLucibello
Copy link
Member Author

With JuliaConcurrent/Atomix.jl#39 maybe things should work

@CarloLucibello
Copy link
Member Author

Atomix 1.0 allows some progress but the scatter kernel still errors FluxML/NNlib.jl#534 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants