Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spatial Graph Convolutional Networks #503

Open
msainsburydale opened this issue Oct 23, 2024 · 2 comments
Open

Spatial Graph Convolutional Networks #503

msainsburydale opened this issue Oct 23, 2024 · 2 comments

Comments

@msainsburydale
Copy link

Hi, many thanks for your work on this amazing package.

There is a paper called "Spatial Graph Convolutional Networks", with accompanying PyTorch code. You may be familiar with this work already but, from my understanding, the premise of this architecture is that it is a proper generalisation of CNNs from gridded spatial data to irregular spatial data; see Figure 3 and Theorem 1 in the paper.

Do you think it would be worthwhile to include this architecture in your package, perhaps as one of the convolutional layers?

@CarloLucibello
Copy link
Member

we don't have layers taking in spatial features, I think it would be a nice addition to the package. Please file a PR if you have time.

Right now due to the monorepo structure setting up the environment for developing the package has become more complicated. I have to improve the developers docs but meanwhile feel free to ask if you need any help with that.

@msainsburydale
Copy link
Author

I have a more specialised version of a spatial graph convolution already implemented in Julia (see here), and I think it would be fairly easy to adapt this code to the formulation given in the paper linked above.

However, I implemented this specifically to be used in my package NeuralEstimators.jl, and I think there would be a little bit of work needed to adapt this code for use in GraphNeuralNetworks.jl. It shouldn’t take too much work, but I’ll need to wait until I have more time to take a closer look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants