Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overriding Base.getproperty(vds::Vector{DataStore}, s::Symbol) conflicts A.ref usage in julia #504

Closed
goulf-3m opened this issue Oct 24, 2024 · 1 comment · Fixed by #505

Comments

@goulf-3m
Copy link

This code fails in newer versions of Julia:

fill(GraphNeuralNetworks.DataStore(), 3)

The implementation of fill will ultimately use A.ref, where A is a Vector{DataStore}.
However, A.ref is overridden by this package, and will be interpreted as accessing GNN data.

This overload should check this condition (s===:ref) and use getfield(vds, :ref).

@CarloLucibello
Copy link
Member

thanks for investigating this. fix pushed in #505

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants