Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

displaying images #15

Open
ultradian opened this issue Mar 29, 2017 · 4 comments
Open

displaying images #15

ultradian opened this issue Mar 29, 2017 · 4 comments

Comments

@ultradian
Copy link
Contributor

I'm playing with DICOM.jl a bit and was writing some code to display raw images. Is this something useful to merge in with the package, and if so, what suggestions do people have about useful display formats or how this package should interface with other packages?

@ihnorton
Copy link
Collaborator

ihnorton commented Mar 29, 2017 via email

@ultradian
Copy link
Contributor Author

@ihnorton, I'm confused. When you talk about Images support, do you mean creating a display or show function in DICOM that uses Images.jl? That is the same thing I meant, when I was talking about raw image display. I'm not sure if that belongs here or in JuliaImages as you mentioned it was out of scope.

@SimonDanisch
Copy link
Contributor

I think @ihnorton meant, that if you create the integration with Images.jl, so that e.g. load("test.dicom") returns an image (which is nowadays just an array of colors), all plotting and visualization packages can already display those and defining show yourself isn't needed!

@ultradian
Copy link
Contributor Author

Thanks for the clarification, @SimonDanisch. I have created a new thread #16 with a proposal to split up the data to make this load/image display easier before creating a PR. What is the process to get push access here in JuliaIO? As a newbie, I appreciated your explanations of how thing work in #14. I don't really know who has push access for this repo besides @ihnorton which I assume you set up as the JuliaIO member who was most involved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants