Gtk4 port #284
Gtk4 port #284
Conversation
Ran into a new bug related to getting the screen size from the default Gdk display. screen_size() works early in the tests but fails later on. It looks like the GListModel of monitors is being unreferenced somewhere, whereas it should be left alone if we are respecting the introspection annotations (which it looks like we are).
seeing a freeze in the tests that needs looking into
|
Argh, sorry for triggering CI again -- I meant to add a [skip ci] to prevent that. I guess it's freezing because it's using the registered version of GtkObservables, which depends on Gtk (?) I've made some progress on the port of GtkObservables -- scroll-zoom now works. The missing piece is simulating mouse events with keyboard modifiers, which we need for testing and precompiling. I may need to add GdkEvent support to Gtk4. |
|
No worries. If there's any way that commit privileges here and in GtkObservables would help your work, just ask and it will be granted. |
I'll take you up on that for GtkObservables. I'd like to run the CI tests for all platforms. It's working well for me locally now. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #284 +/- ##
==========================================
+ Coverage 84.72% 84.76% +0.03%
==========================================
Files 6 6
Lines 838 840 +2
==========================================
+ Hits 710 712 +2
Misses 128 128
☔ View full report in Codecov by Sentry. |
When the canvas is put in a window such that it receives no allocated space, it is never realized, and this causes everything to freeze. It would be good to solve the underlying issue, but setting a small minimum size (10 by 10 pixels here) prevents it from ever happening.
|
All tests now pass, including the ones that were commented out before. I am going through the README and trying everything to make sure things work as advertised. I'm seeing a few things I want to fix before this is merged. |
|
I took a brief look and everything seems uncontroversial. You can merge whenever you feel comfortable. Many thanks, I've been moving my lab and its so kind for you to carry this forward! |
|
Great, thanks! One pesky issue remains -- when you zoom in on the pointer (control-scroll), it doesn't stay centered on the pointer. It zooms in and out and stays in the same general region as the pointer, but it's not as nice as before, and I haven't figured out why. I will give it another try this weekend, but if I can't fix it I may just merge and we can figure it out later. I generally have more time on weekends for Julia BTW. As someone who moved my lab a few years ago, I feel your pain! |
|
I did fix the zooming bug I mentioned, which was in GtkObservables. |
|
Amazing Job @jwahlstrand!!, Can you please make the new release? |
|
Sure, 0.12.0 I guess? I'll have time to do it tomorrow morning. |
|
Yep, 0.12.0 would work |
I think this is ready to be tried out. Tests pass for me.