Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contrast GUI: convert new minimum and maximum values to float #311

Merged
merged 2 commits into from
Jun 10, 2024

Conversation

jwahlstrand
Copy link
Collaborator

Implements suggestion from @kimikage

Fixes #310

I verified that this still avoids the crash in #308

Copy link

codecov bot commented Jun 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 85.74%. Comparing base (27fb192) to head (6f632bd).

Current head 6f632bd differs from pull request most recent head ca4de2b

Please upload reports for the commit ca4de2b to get more accurate results.

Files Patch % Lines
src/contrast_gui.jl 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #311      +/-   ##
==========================================
+ Coverage   85.01%   85.74%   +0.73%     
==========================================
  Files           6        6              
  Lines         814      870      +56     
==========================================
+ Hits          692      746      +54     
- Misses        122      124       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kimikage
Copy link

I have once again checked the implementation of the contrast GUI and noticed several design issues.
However, I think it is a good idea to release this first as a quick fix.

@jwahlstrand
Copy link
Collaborator Author

Thanks. The code does somehow seem a bit complicated for what it does. I'll merge this now and do another release.

@jwahlstrand jwahlstrand merged commit f82a240 into master Jun 10, 2024
10 checks passed
@jwahlstrand jwahlstrand deleted the jw/normed branch June 15, 2024 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improper Normed handling in the contrast GUI
2 participants