Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename eval_string #128

Open
musm opened this issue Oct 30, 2017 · 3 comments
Open

Rename eval_string #128

musm opened this issue Oct 30, 2017 · 3 comments

Comments

@musm
Copy link
Collaborator

musm commented Oct 30, 2017

eval_string is a pretty generic term to export. I propose we rename it to something more descriptive. Maybe matlab_eval or meval ? Suggestions welcome.

@musm
Copy link
Collaborator Author

musm commented Nov 4, 2017

# option 1  (similar to RCall.jl and JavaCall.jl)
meval("func([2 3 1])")
m"[x,y] = func([2 3 1])"
xx, yy = mcall(:meshgrid, 2, x, y)

# option 2
mateval("func([2 3 1])")
mat"[x,y] = func([2 3 1])"
xx, yy = matcall(:meshgrid, 2, x, y)

# option 3
matlab_eval("func([2 3 1])")
mat"[x,y] = func([2 3 1])"
xx, yy = matlabcall(:meshgrid, 2, x, y)

# option 4
mxeval("func([2 3 1])")
mx"[x,y] = func([2 3 1])"
xx, yy = mxcall(:meshgrid, 2, x, y)

My preference is for option 1 or option 4.

cc @simonster, @ChrisRackauckas , @yuyichao

@ChrisRackauckas
Copy link
Member

ChrisRackauckas commented Nov 4, 2017

They're all option 1 lol.

But I like the last (option 3) and see all of them as good.

edit to add the option number.

@goszlanyi
Copy link

goszlanyi commented Dec 28, 2017

I also prefer the matlab_eval option.
But why not call it simply matlab?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants