Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport "[SLP] Check for PHI nodes (potentially cycles!) when checking dependencies" #42

Merged
merged 1 commit into from
Feb 14, 2025
Merged

Backport "[SLP] Check for PHI nodes (potentially cycles!) when checking dependencies" #42

merged 1 commit into from
Feb 14, 2025

Conversation

Zentrik
Copy link
Member

@Zentrik Zentrik commented Feb 14, 2025 •
edited
Loading

@giordano
Copy link

Can you please cherry pick with the -x flag to automatically append a reference to the upstream commit? Note to self, we need to cherry pick it also in the llvm 20 branch

@alexey-bataev @Zentrik
[SLP] Check for PHI nodes (potentially cycles!) when checking depende…
7c6f2dd 
…ncies

When checking for dependecies for gather nodes with users with the same
last instruction, cannot rely on the index order, if there is (even
potential!) cycle in the graph, which may cause order not work correctly
and cause compiler crash.

Fixes llvm#127128

(cherry picked from commit ac217ee)
@Zentrik
Copy link
Member Author

Zentrik commented Feb 14, 2025

Note to self, we need to cherry pick it also in the llvm 20 branch

done in llvm#127267

@giordano giordano merged commit a9df916 into JuliaLang:julia-release/19.x Feb 14, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Zentrik @giordano @alexey-bataev