-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move LowRankMatrix to LowRankApprox (or new package LowRankMatrices.jl) #6
Comments
Probably could use an |
Why do you need to store the diagonal in |
Wait. your Why not use |
The diagonal doesn't matter for performance (because of https://github.com/JuliaMatrices/HierarchicalMatrices.jl/blob/master/src/blas06.jl#L40). Is it always an SVD? I don't think so, but the fields strongly hint that it should be. |
Your override of |
You're right. |
It overlaps with |
Do we have support for the CUR factorization anywhere? http://www.math.vt.edu/people/embree/cur_talk.pdf |
I wonder if that leads to a 'two-sided' butterfly algorithm |
Having its own version of |
LowRankMatrix is not actually a HierarchicalMatrix, so maybe it lives better in LowRankApprox. This would also make it easier to use the LowRankApprox algorithms.
The text was updated successfully, but these errors were encountered: