Split for OGBDatasets #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests and some fixes are left. |
Codecov Report
@@ Coverage Diff @@
## master #172 +/- ##
==========================================
+ Coverage 33.01% 37.12% +4.10%
==========================================
Files 41 42 +1
Lines 2084 2182 +98
==========================================
+ Hits 688 810 +122
+ Misses 1396 1372 -24
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
The split for heterogeneous datasets with edge-level tasks needs to be addressed. Now that I have had the chance to think about it, I really don't want to change HeteroGraph API. |
|
Can we add a test with the dataset mentioned in #107 (comment)?
it can be done in a separate PR if it is too involved |
|
Merge #170 before this |
|
I think we are in a good position to merge this @CarloLucibello |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pr adds support for simple graph link split (#107) as well as support for splits in Heterogeneous OGB Datasets.
Need Fixing before merge: #167