-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use GeodesicInterpolationWithinRadius for Circle mean #594
base: master
Are you sure you want to change the base?
Conversation
sethaxen
commented
Apr 28, 2023
- Replace default extrinsic mean with interpolation within radius
- Update docstring
- Increment patch number
Codecov Report
@@ Coverage Diff @@
## master #594 +/- ##
==========================================
- Coverage 98.90% 5.98% -92.92%
==========================================
Files 98 98
Lines 9897 9701 -196
==========================================
- Hits 9789 581 -9208
- Misses 108 9120 +9012
... and 92 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Manopt.jl is currently in the process of adding such workaround: JuliaManifolds/Manopt.jl#236 . Essentially it's wrapping points in one-element vectors. It's not ideal for performance, especially in the case of |
What I basically do is for any The only thing that is a bit tricky somewhen is that this also requires a small “post-processing” i.e. after computing the (one-vector) mean |
HI @sethaxen – do you still plan to continue this? (No pressure, just trying to keep an eye on what PRs we still have open here) |
As if right now, yes, but it's unclear when I will finish it. I have a private lightweight repo efficiently implementing various intrinsic circular statistics that I will eventually finish, and the plan is to then add that as a dependency here to deliver this functionality. If the plan changes, I'll post here. |
That sounds great! Looking forward to hearing from that :) |