Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make Accessors.jl tests run. #170

Closed
wants to merge 2 commits into from

Conversation

longemen3000
Copy link

at the moment, the current Accessors.jl tests are failing because of JuliaLang/julia#54664. While that issue needs to be resolved on the julia repository, i suppose that what the test is actually checking is that there is a documentation string present for the tested function.

@aplavin
Copy link
Member

aplavin commented Sep 1, 2024

It's always nice to have tests run successfully on nightlies, even though not a priority of course – tests already pass on all released julia versions.
I wonder if this hack using __string and Base.Docs.DocStr (non-public, julia internal) something recommended by julia devs? I didn't see it after a cursory look those issues... Would be nice if someone from Julia confirmed this is a reasonable solution.

@aplavin
Copy link
Member

aplavin commented Oct 16, 2024

Worked around in an (arguably) cleaner way #175

@aplavin aplavin closed this Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants