Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move away from Base.write(::IO, ::POMDP) #14

Open
zsunberg opened this issue Jun 6, 2023 · 0 comments
Open

Move away from Base.write(::IO, ::POMDP) #14

zsunberg opened this issue Jun 6, 2023 · 0 comments

Comments

@zsunberg
Copy link
Member

zsunberg commented Jun 6, 2023

I don't think specializing Base.write for POMDP is the correct way to implement the functionality in this package.

The docstring for write says "Write the canonical binary representation of a value to the given I/O stream or file." I don't think the pomdp file format is the canonical binary representation they are thinking of based on the rest of that documentation (it talks about endianness). Base.print may be more appropriate, but still probably not what we want.

I think we should look at how DataFrames are written to csv files or how excel files are read in for some inspiration. Or maybe if there is a package that saves neural networks to bson?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant