You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In discrete_explicit.jl, would it be possible to allow two different signatures for T (one taking s, a, and sp as inputs, and another taking only s and a), so it can skip the last inner loop when T returns a Distribution object?
If so, I could create a PR for it? Seems pretty straightforward.
The text was updated successfully, but these errors were encountered:
The DiscreteExplicit interface was really only meant for very simple problems, and even for those, as we found in class, it is fairly unweildy. I think maybe I should move it to another package to reduce confusion.
Hey Zach,
Referencing these lines:
https://github.com/JuliaPOMDP/QuickPOMDPs.jl/blob/master/src/discrete_explicit.jl#L162
Currently the inner
for xp in ss
loop evaluates the transition probabilities for each state-action combo, and populates aSparceCat
distribution.This creates a pretty big bottleneck, especially if the transition function itself is costly.
In your other models (e.g. https://github.com/JuliaPOMDP/POMDPModels.jl/blob/master/src/TigerPOMDPs.jl),
T
doesn't take a future state as a param. So they just returnDistribution
objects.In
discrete_explicit.jl
, would it be possible to allow two different signatures forT
(one takings
,a
, andsp
as inputs, and another taking onlys
anda
), so it can skip the last inner loop whenT
returns aDistribution
object?If so, I could create a PR for it? Seems pretty straightforward.
The text was updated successfully, but these errors were encountered: