Don't request username in init_jll_package #1304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The username might not be available if authentication as a GitHub App.
staticfloat
approved these changes
Nov 13, 2023
|
Do you think the time out is related to this change or was the machine busy with other stuff? |
|
It's still timing out even after I retried it. |
|
@staticfloat Any idea what's going on here? |
|
Looks like it just takes more than 120m to run the tests and download all the shards. :( |
|
I don't think it has to download anything. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The username might not be available if authenticating as a GitHub App. Also, when authenticating with a token, the username isn't necessary.