Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't query GitHub username and use dummy credentials when committing #1305

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

andreasnoack
Copy link
Contributor

This is a followup to #1304 since there were two more authentications that relied on querying the potentially non-existent GitHub username.

The second commit might not be the right approach but it allowed me to build new binaries while authenticating as a GitHub app. The issue is that

commit = LibGit2.commit(wrapper_repo, "$(name)_jll build $(build_version)")
ends up querying username information from the local git repo when calling https://github.com/JuliaLang/julia/blob/187e8c2222878c68b2afc9295ab8dc61773bd7f2/stdlib/LibGit2/src/signature.jl#L66-L72.

@andreasnoack andreasnoack changed the title An/noghusername Don't query GitHub username and use dummy credentials when committing Nov 24, 2023
@DilumAluthge DilumAluthge marked this pull request as draft November 26, 2023 21:21
@andreasnoack
Copy link
Contributor Author

After discussions with @DilumAluthge, I've dropped the second commit that used dummy credentials. Instead, the user should set the git default user because building the binaries.

@DilumAluthge DilumAluthge marked this pull request as ready for review November 27, 2023 14:30
@staticfloat staticfloat merged commit 3bdbf48 into JuliaPackaging:master Nov 27, 2023
6 of 9 checks passed
@DilumAluthge
Copy link
Member

Thanks Elliot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants