Skip to content
This repository has been archived by the owner on Aug 16, 2023. It is now read-only.

call to probe_platform_engines! will break in Julia 1.8 #204

Open
StefanKarpinski opened this issue Jul 2, 2021 · 2 comments
Open

call to probe_platform_engines! will break in Julia 1.8 #204

StefanKarpinski opened this issue Jul 2, 2021 · 2 comments

Comments

@StefanKarpinski
Copy link

JuliaLang/Pkg.jl#2641 deletes the internal probe_platform_engines! which this package calls. This has been a no-op for since Julia 1.6: you can now just download stuff without calling that. As a result:

  • Old versions of this package will break with Julia 1.8, so they will need to be capped in the registry
  • To support both Julia ≤ 1.5 and ≥ 1.6 at the same time, check if the function exists before calling it
  • To support only Julia ≥ 1.6 you can simply delete the call to probe_platform_engines!
@StefanKarpinski
Copy link
Author

Nevermind, this calls its own probe_platform_engines! which is unrelated.

@StefanKarpinski
Copy link
Author

No wait, that used to be the case but now this seems to call Pkg's version.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant