Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump compat for Adapt to 4, (keep existing compat) #39

Merged
merged 1 commit into from
Dec 29, 2023
Merged

Bump compat for Adapt to 4, (keep existing compat) #39

merged 1 commit into from
Dec 29, 2023

Conversation

fhagemann
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Dec 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (045a1dd) 52.94% compared to head (837da0a) 53.27%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #39      +/-   ##
==========================================
+ Coverage   52.94%   53.27%   +0.33%     
==========================================
  Files          29       29              
  Lines         986      993       +7     
==========================================
+ Hits          522      529       +7     
  Misses        464      464              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fhagemann
Copy link
Contributor Author

Re-run tests (seems to have run still with Adapt 3.7.2 due to ArraysOfArrays) and merge? @oschulz

@oschulz
Copy link
Member

oschulz commented Dec 29, 2023

It'll be fine. :-)

@oschulz oschulz merged commit da4c5f5 into JuliaPhysics:main Dec 29, 2023
9 checks passed
@fhagemann fhagemann deleted the adapt branch March 18, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants