Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vertical Unicode Histogram feature #219

Closed
Cvikli opened this issue Feb 3, 2022 · 3 comments · Fixed by #250
Closed

Vertical Unicode Histogram feature #219

Cvikli opened this issue Feb 3, 2022 · 3 comments · Fixed by #250

Comments

@Cvikli
Copy link

Cvikli commented Feb 3, 2022

Dear Julianners of UnicodePlots,

I just wanted to ask weather you want to merge this few lines of code of mine to your repository:
https://github.com/Cvikli/HistogramUnicode.jl
We were having discussion about this topic here: Julia Discourse - BenchmarkTools @benchmark beautiful histogram reuse

I don't know your standards, for me this function call was a really great fit to work with.

Bests,
Marcell

@t-bltg
Copy link
Member

t-bltg commented Feb 3, 2022

Hi !

Any contribution is welcome 👍
Plus I think this feature was requested before in #95.

You can open a Pull Request (PR) in this repository, and we can polish the integration details in your PR.

@Cvikli
Copy link
Author

Cvikli commented Feb 7, 2022

Okay, I added the code here:

vertical histrogram

I see there is a Plot{<:Canvas} standardised style, which isn't fully understandable for me, so I didn't finish properly.

@Cvikli
Copy link
Author

Cvikli commented Mar 7, 2022

Hey sorry for being this slow on responding. I think I let this work to be done by someone else as my free time got filled up with another project. I made a post here: https://www.reddit.com/r/Julia/comments/t8yp23/julia_simple_unicode_plotting/ I hope someone will take the effort and integrate it to the main UnicodePlot.jl repository by time.

(Also I think there are some standardization on the input and the printing mechanism have to be changed if someone wants to merge into this library as I think there are some custom style over there I guess.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants