Skip to content

Commit

Permalink
Merge #524
Browse files Browse the repository at this point in the history
524: When yanking a version, only `yanked = true` is correct; `yank = true` (and other variants) are incorrect, so we should detect them r=DilumAluthge a=DilumAluthge

Fixes #523

Co-authored-by: Dilum Aluthge <[email protected]>
  • Loading branch information
bors[bot] and DilumAluthge authored Oct 28, 2023
2 parents 3082b39 + 061b5f1 commit 64d788e
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
2 changes: 1 addition & 1 deletion Project.toml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "RegistryCI"
uuid = "0c95cc5f-2f7e-43fe-82dd-79dbcba86b32"
authors = ["Dilum Aluthge <[email protected]>", "Fredrik Ekre <[email protected]>", "contributors"]
version = "9.0.0"
version = "9.1.0"

[deps]
Base64 = "2a0f44e3-6c83-55bd-87e4-b1978d98bd5f"
Expand Down
5 changes: 5 additions & 0 deletions src/registry_testing.jl
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,11 @@ function test(path=pwd(); registry_deps::Vector{<:AbstractString}=String[])
for (v, data) in vers
Test.@test VersionNumber(v) isa VersionNumber
Test.@test haskey(data, "git-tree-sha1")

# https://github.com/JuliaRegistries/RegistryCI.jl/issues/523
# "yanked" is correct.
# "yank" (and all other variants) are incorrect.
Test.@test keys(data) ["git-tree-sha1", "yanked"]
end

# Deps.toml testing
Expand Down

2 comments on commit 64d788e

@DilumAluthge
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/94283

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v9.1.0 -m "<description of version>" 64d788e5b70f4e3f14b7ee101e0832ddb3dda5b3
git push origin v9.1.0

Please sign in to comment.