From 56a8e0fa3312f8fdcb568fbc07e4cf09f7b73f03 Mon Sep 17 00:00:00 2001 From: Eric Hanson <5846501+ericphanson@users.noreply.github.com> Date: Tue, 30 Jan 2024 21:13:43 +0100 Subject: [PATCH 01/11] add reference test for AutoMerge comment --- Project.toml | 4 +- test/automerge-unit.jl | 38 +++++++++++++++++++ ...alse_version_0.1.0_point_to_slack_false.md | 17 +++++++++ ...false_version_0.1.0_point_to_slack_true.md | 17 +++++++++ ...alse_version_1.0.0_point_to_slack_false.md | 17 +++++++++ ...false_version_1.0.0_point_to_slack_true.md | 17 +++++++++ ...true_version_0.1.0_point_to_slack_false.md | 24 ++++++++++++ ..._true_version_0.1.0_point_to_slack_true.md | 24 ++++++++++++ ...true_version_1.0.0_point_to_slack_false.md | 17 +++++++++ ..._true_version_1.0.0_point_to_slack_true.md | 17 +++++++++ ...alse_version_0.1.0_point_to_slack_false.md | 13 +++++++ ...false_version_0.1.0_point_to_slack_true.md | 13 +++++++ ...alse_version_1.0.0_point_to_slack_false.md | 13 +++++++ ...false_version_1.0.0_point_to_slack_true.md | 13 +++++++ ...true_version_0.1.0_point_to_slack_false.md | 20 ++++++++++ ..._true_version_0.1.0_point_to_slack_true.md | 20 ++++++++++ ...true_version_1.0.0_point_to_slack_false.md | 13 +++++++ ..._true_version_1.0.0_point_to_slack_true.md | 13 +++++++ ...ntzero_false_version_0.1.0_is_jll_false.md | 9 +++++ ...intzero_false_version_0.1.0_is_jll_true.md | 7 ++++ ...ntzero_false_version_1.0.0_is_jll_false.md | 9 +++++ ...intzero_false_version_1.0.0_is_jll_true.md | 7 ++++ ...intzero_true_version_0.1.0_is_jll_false.md | 16 ++++++++ ...ointzero_true_version_0.1.0_is_jll_true.md | 14 +++++++ ...intzero_true_version_1.0.0_is_jll_false.md | 9 +++++ ...ointzero_true_version_1.0.0_is_jll_true.md | 7 ++++ ...ntzero_false_version_0.1.0_is_jll_false.md | 5 +++ ...intzero_false_version_0.1.0_is_jll_true.md | 5 +++ ...ntzero_false_version_1.0.0_is_jll_false.md | 5 +++ ...intzero_false_version_1.0.0_is_jll_true.md | 5 +++ ...intzero_true_version_0.1.0_is_jll_false.md | 12 ++++++ ...ointzero_true_version_0.1.0_is_jll_true.md | 12 ++++++ ...intzero_true_version_1.0.0_is_jll_false.md | 5 +++ ...ointzero_true_version_1.0.0_is_jll_true.md | 5 +++ test/runtests.jl | 1 + 35 files changed, 442 insertions(+), 1 deletion(-) create mode 100644 test/reference_comments/comment_pass_false_type_new_package_suggest_onepointzero_false_version_0.1.0_point_to_slack_false.md create mode 100644 test/reference_comments/comment_pass_false_type_new_package_suggest_onepointzero_false_version_0.1.0_point_to_slack_true.md create mode 100644 test/reference_comments/comment_pass_false_type_new_package_suggest_onepointzero_false_version_1.0.0_point_to_slack_false.md create mode 100644 test/reference_comments/comment_pass_false_type_new_package_suggest_onepointzero_false_version_1.0.0_point_to_slack_true.md create mode 100644 test/reference_comments/comment_pass_false_type_new_package_suggest_onepointzero_true_version_0.1.0_point_to_slack_false.md create mode 100644 test/reference_comments/comment_pass_false_type_new_package_suggest_onepointzero_true_version_0.1.0_point_to_slack_true.md create mode 100644 test/reference_comments/comment_pass_false_type_new_package_suggest_onepointzero_true_version_1.0.0_point_to_slack_false.md create mode 100644 test/reference_comments/comment_pass_false_type_new_package_suggest_onepointzero_true_version_1.0.0_point_to_slack_true.md create mode 100644 test/reference_comments/comment_pass_false_type_new_version_suggest_onepointzero_false_version_0.1.0_point_to_slack_false.md create mode 100644 test/reference_comments/comment_pass_false_type_new_version_suggest_onepointzero_false_version_0.1.0_point_to_slack_true.md create mode 100644 test/reference_comments/comment_pass_false_type_new_version_suggest_onepointzero_false_version_1.0.0_point_to_slack_false.md create mode 100644 test/reference_comments/comment_pass_false_type_new_version_suggest_onepointzero_false_version_1.0.0_point_to_slack_true.md create mode 100644 test/reference_comments/comment_pass_false_type_new_version_suggest_onepointzero_true_version_0.1.0_point_to_slack_false.md create mode 100644 test/reference_comments/comment_pass_false_type_new_version_suggest_onepointzero_true_version_0.1.0_point_to_slack_true.md create mode 100644 test/reference_comments/comment_pass_false_type_new_version_suggest_onepointzero_true_version_1.0.0_point_to_slack_false.md create mode 100644 test/reference_comments/comment_pass_false_type_new_version_suggest_onepointzero_true_version_1.0.0_point_to_slack_true.md create mode 100644 test/reference_comments/comment_pass_true_type_new_package_suggest_onepointzero_false_version_0.1.0_is_jll_false.md create mode 100644 test/reference_comments/comment_pass_true_type_new_package_suggest_onepointzero_false_version_0.1.0_is_jll_true.md create mode 100644 test/reference_comments/comment_pass_true_type_new_package_suggest_onepointzero_false_version_1.0.0_is_jll_false.md create mode 100644 test/reference_comments/comment_pass_true_type_new_package_suggest_onepointzero_false_version_1.0.0_is_jll_true.md create mode 100644 test/reference_comments/comment_pass_true_type_new_package_suggest_onepointzero_true_version_0.1.0_is_jll_false.md create mode 100644 test/reference_comments/comment_pass_true_type_new_package_suggest_onepointzero_true_version_0.1.0_is_jll_true.md create mode 100644 test/reference_comments/comment_pass_true_type_new_package_suggest_onepointzero_true_version_1.0.0_is_jll_false.md create mode 100644 test/reference_comments/comment_pass_true_type_new_package_suggest_onepointzero_true_version_1.0.0_is_jll_true.md create mode 100644 test/reference_comments/comment_pass_true_type_new_version_suggest_onepointzero_false_version_0.1.0_is_jll_false.md create mode 100644 test/reference_comments/comment_pass_true_type_new_version_suggest_onepointzero_false_version_0.1.0_is_jll_true.md create mode 100644 test/reference_comments/comment_pass_true_type_new_version_suggest_onepointzero_false_version_1.0.0_is_jll_false.md create mode 100644 test/reference_comments/comment_pass_true_type_new_version_suggest_onepointzero_false_version_1.0.0_is_jll_true.md create mode 100644 test/reference_comments/comment_pass_true_type_new_version_suggest_onepointzero_true_version_0.1.0_is_jll_false.md create mode 100644 test/reference_comments/comment_pass_true_type_new_version_suggest_onepointzero_true_version_0.1.0_is_jll_true.md create mode 100644 test/reference_comments/comment_pass_true_type_new_version_suggest_onepointzero_true_version_1.0.0_is_jll_false.md create mode 100644 test/reference_comments/comment_pass_true_type_new_version_suggest_onepointzero_true_version_1.0.0_is_jll_true.md diff --git a/Project.toml b/Project.toml index b146336f..9252a0e6 100644 --- a/Project.toml +++ b/Project.toml @@ -34,6 +34,7 @@ LicenseCheck = "0.2" Pkg = "1" Printf = "<0.0.1, 1" Random = "<0.0.1, 1" +ReferenceTests = "0.9, 0.10" RegistryTools = "2.2" SHA = "<0.0.1, 0.7, 1" SimpleMock = "1" @@ -52,8 +53,9 @@ JSON = "682c06a0-de6a-54ab-a142-c8b1cf79cde6" Pkg = "44cfe95a-1eb2-52ea-b672-e2afdf69b78f" Printf = "de0858da-6303-5e67-8744-51eddeeeb8d7" SimpleMock = "a896ed2c-15a5-4479-b61d-a0e88e2a1d25" +ReferenceTests = "324d217c-45ce-50fc-942e-d289b448e8cf" Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40" TimeZones = "f269a46b-ccf7-5d73-abea-4c690281aa53" [targets] -test = ["Dates", "GitHub", "JSON", "Pkg", "Printf", "SimpleMock", "Test", "TimeZones"] +test = ["Dates", "GitHub", "JSON", "Pkg", "Printf", "SimpleMock", "ReferenceTests", "Test", "TimeZones"] diff --git a/test/automerge-unit.jl b/test/automerge-unit.jl index 28bb8e30..ce1a2e34 100644 --- a/test/automerge-unit.jl +++ b/test/automerge-unit.jl @@ -45,7 +45,45 @@ function pkgdir_from_depot(depot_path::String, pkg::String) return only_pkdir end +# Here we reference test all the permutations of the AutoMerge comments. +# This allows us to see the diffs in PRs that change the AutoMerge comment. +function comment_reference_test() + for pass in (true, false), + (type_name,type) in (("new_version", AutoMerge.NewVersion()), ("new_package", AutoMerge.NewPackage())), + suggest_onepointzero in (true, false), + # some code depends on above or below v"1" + version in (v"0.1.1", v"1.1.1") + + if pass + for is_jll in (true, false) + name = string("comment", "_pass_", pass, "_type_", type_name, + "_suggest_onepointzero_", suggest_onepointzero, + "_version_", version, "_is_jll_", is_jll) + @test_reference "reference_comments/$name.md" AutoMerge.comment_text_pass(type, suggest_onepointzero, version, is_jll) + end + else + for point_to_slack in (true, false) + name = string("comment", "_pass_", pass, "_type_", type_name, + "_suggest_onepointzero_", suggest_onepointzero, + "_version_", version, "_point_to_slack_", point_to_slack) + reasons = ["Example guideline failed. Please fix it."] + fail_text = AutoMerge.comment_text_fail(type, reasons, suggest_onepointzero, version; point_to_slack=point_to_slack) + + @test_reference "reference_comments/$name.md" fail_text + + # `point_to_slack=false` should yield no references to Slack in the text + if !point_to_slack + @test !contains(text, "slack") + end + end + end + end +end + @testset "Utilities" begin + @testset "comment_reference_test" begin + comment_reference_test() + end @testset "`AutoMerge.parse_registry_pkg_info`" begin registry_path = joinpath(DEPOT_PATH[1], "registries", "General") result = AutoMerge.parse_registry_pkg_info(registry_path, "RegistryCI", "1.0.0") diff --git a/test/reference_comments/comment_pass_false_type_new_package_suggest_onepointzero_false_version_0.1.0_point_to_slack_false.md b/test/reference_comments/comment_pass_false_type_new_package_suggest_onepointzero_false_version_0.1.0_point_to_slack_false.md new file mode 100644 index 00000000..c09d23d6 --- /dev/null +++ b/test/reference_comments/comment_pass_false_type_new_package_suggest_onepointzero_false_version_0.1.0_point_to_slack_false.md @@ -0,0 +1,17 @@ +Your `new package` pull request does not meet the guidelines for auto-merging. Please make sure that you have read the [General registry README](https://github.com/JuliaRegistries/General/blob/master/README.md) and the [AutoMerge guidelines](https://juliaregistries.github.io/RegistryCI.jl/stable/guidelines/). The following guidelines were not met: + +- no + +Note that the guidelines are only required for the pull request to be merged automatically. However, it is **strongly recommended** to follow them, since otherwise the pull request needs to be manually reviewed and merged by a human. + +After you have fixed the AutoMerge issues, simply retrigger Registrator, which will automatically update this pull request. You do not need to change the version number in your `Project.toml` file (unless of course the AutoMerge issue is that you skipped a version number, in which case you should change the version number). + +If you do not want to fix the AutoMerge issues, please post a comment explaining why you would like this pull request to be manually merged. + +Since you are registering a new package, please make sure that you have also read the package naming guidelines: https://pkgdocs.julialang.org/v1/creating-packages/#Package-naming-guidelines + + + +--- +If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text `[noblock]` in your comment. You can edit blocking comments, adding `[noblock]` to them in order to unblock auto-merging. + \ No newline at end of file diff --git a/test/reference_comments/comment_pass_false_type_new_package_suggest_onepointzero_false_version_0.1.0_point_to_slack_true.md b/test/reference_comments/comment_pass_false_type_new_package_suggest_onepointzero_false_version_0.1.0_point_to_slack_true.md new file mode 100644 index 00000000..100b3018 --- /dev/null +++ b/test/reference_comments/comment_pass_false_type_new_package_suggest_onepointzero_false_version_0.1.0_point_to_slack_true.md @@ -0,0 +1,17 @@ +Your `new package` pull request does not meet the guidelines for auto-merging. Please make sure that you have read the [General registry README](https://github.com/JuliaRegistries/General/blob/master/README.md) and the [AutoMerge guidelines](https://juliaregistries.github.io/RegistryCI.jl/stable/guidelines/). The following guidelines were not met: + +- no + +Note that the guidelines are only required for the pull request to be merged automatically. However, it is **strongly recommended** to follow them, since otherwise the pull request needs to be manually reviewed and merged by a human. + +After you have fixed the AutoMerge issues, simply retrigger Registrator, which will automatically update this pull request. You do not need to change the version number in your `Project.toml` file (unless of course the AutoMerge issue is that you skipped a version number, in which case you should change the version number). + +If you do not want to fix the AutoMerge issues, please post a comment explaining why you would like this pull request to be manually merged. Then, send a message to the `#pkg-registration` channel in the [Julia Slack](https://julialang.org/slack/) to ask for help. Include a link to this pull request. + +Since you are registering a new package, please make sure that you have also read the package naming guidelines: https://pkgdocs.julialang.org/v1/creating-packages/#Package-naming-guidelines + + + +--- +If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text `[noblock]` in your comment. You can edit blocking comments, adding `[noblock]` to them in order to unblock auto-merging. + \ No newline at end of file diff --git a/test/reference_comments/comment_pass_false_type_new_package_suggest_onepointzero_false_version_1.0.0_point_to_slack_false.md b/test/reference_comments/comment_pass_false_type_new_package_suggest_onepointzero_false_version_1.0.0_point_to_slack_false.md new file mode 100644 index 00000000..c09d23d6 --- /dev/null +++ b/test/reference_comments/comment_pass_false_type_new_package_suggest_onepointzero_false_version_1.0.0_point_to_slack_false.md @@ -0,0 +1,17 @@ +Your `new package` pull request does not meet the guidelines for auto-merging. Please make sure that you have read the [General registry README](https://github.com/JuliaRegistries/General/blob/master/README.md) and the [AutoMerge guidelines](https://juliaregistries.github.io/RegistryCI.jl/stable/guidelines/). The following guidelines were not met: + +- no + +Note that the guidelines are only required for the pull request to be merged automatically. However, it is **strongly recommended** to follow them, since otherwise the pull request needs to be manually reviewed and merged by a human. + +After you have fixed the AutoMerge issues, simply retrigger Registrator, which will automatically update this pull request. You do not need to change the version number in your `Project.toml` file (unless of course the AutoMerge issue is that you skipped a version number, in which case you should change the version number). + +If you do not want to fix the AutoMerge issues, please post a comment explaining why you would like this pull request to be manually merged. + +Since you are registering a new package, please make sure that you have also read the package naming guidelines: https://pkgdocs.julialang.org/v1/creating-packages/#Package-naming-guidelines + + + +--- +If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text `[noblock]` in your comment. You can edit blocking comments, adding `[noblock]` to them in order to unblock auto-merging. + \ No newline at end of file diff --git a/test/reference_comments/comment_pass_false_type_new_package_suggest_onepointzero_false_version_1.0.0_point_to_slack_true.md b/test/reference_comments/comment_pass_false_type_new_package_suggest_onepointzero_false_version_1.0.0_point_to_slack_true.md new file mode 100644 index 00000000..100b3018 --- /dev/null +++ b/test/reference_comments/comment_pass_false_type_new_package_suggest_onepointzero_false_version_1.0.0_point_to_slack_true.md @@ -0,0 +1,17 @@ +Your `new package` pull request does not meet the guidelines for auto-merging. Please make sure that you have read the [General registry README](https://github.com/JuliaRegistries/General/blob/master/README.md) and the [AutoMerge guidelines](https://juliaregistries.github.io/RegistryCI.jl/stable/guidelines/). The following guidelines were not met: + +- no + +Note that the guidelines are only required for the pull request to be merged automatically. However, it is **strongly recommended** to follow them, since otherwise the pull request needs to be manually reviewed and merged by a human. + +After you have fixed the AutoMerge issues, simply retrigger Registrator, which will automatically update this pull request. You do not need to change the version number in your `Project.toml` file (unless of course the AutoMerge issue is that you skipped a version number, in which case you should change the version number). + +If you do not want to fix the AutoMerge issues, please post a comment explaining why you would like this pull request to be manually merged. Then, send a message to the `#pkg-registration` channel in the [Julia Slack](https://julialang.org/slack/) to ask for help. Include a link to this pull request. + +Since you are registering a new package, please make sure that you have also read the package naming guidelines: https://pkgdocs.julialang.org/v1/creating-packages/#Package-naming-guidelines + + + +--- +If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text `[noblock]` in your comment. You can edit blocking comments, adding `[noblock]` to them in order to unblock auto-merging. + \ No newline at end of file diff --git a/test/reference_comments/comment_pass_false_type_new_package_suggest_onepointzero_true_version_0.1.0_point_to_slack_false.md b/test/reference_comments/comment_pass_false_type_new_package_suggest_onepointzero_true_version_0.1.0_point_to_slack_false.md new file mode 100644 index 00000000..0f052457 --- /dev/null +++ b/test/reference_comments/comment_pass_false_type_new_package_suggest_onepointzero_true_version_0.1.0_point_to_slack_false.md @@ -0,0 +1,24 @@ +Your `new package` pull request does not meet the guidelines for auto-merging. Please make sure that you have read the [General registry README](https://github.com/JuliaRegistries/General/blob/master/README.md) and the [AutoMerge guidelines](https://juliaregistries.github.io/RegistryCI.jl/stable/guidelines/). The following guidelines were not met: + +- no + +Note that the guidelines are only required for the pull request to be merged automatically. However, it is **strongly recommended** to follow them, since otherwise the pull request needs to be manually reviewed and merged by a human. + +After you have fixed the AutoMerge issues, simply retrigger Registrator, which will automatically update this pull request. You do not need to change the version number in your `Project.toml` file (unless of course the AutoMerge issue is that you skipped a version number, in which case you should change the version number). + +If you do not want to fix the AutoMerge issues, please post a comment explaining why you would like this pull request to be manually merged. + +Since you are registering a new package, please make sure that you have also read the package naming guidelines: https://pkgdocs.julialang.org/v1/creating-packages/#Package-naming-guidelines + + + +--- +If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text `[noblock]` in your comment. You can edit blocking comments, adding `[noblock]` to them in order to unblock auto-merging. + +--- +On a separate note, I see that you are registering a release with a version number of the form `v0.X.Y`. + +Does your package have a stable public API? If so, then it's time for you to register version `v1.0.0` of your package. (This is not a requirement. It's just a recommendation.) + +If your package does not yet have a stable public API, then of course you are not yet ready to release version `v1.0.0`. + \ No newline at end of file diff --git a/test/reference_comments/comment_pass_false_type_new_package_suggest_onepointzero_true_version_0.1.0_point_to_slack_true.md b/test/reference_comments/comment_pass_false_type_new_package_suggest_onepointzero_true_version_0.1.0_point_to_slack_true.md new file mode 100644 index 00000000..f1cc828b --- /dev/null +++ b/test/reference_comments/comment_pass_false_type_new_package_suggest_onepointzero_true_version_0.1.0_point_to_slack_true.md @@ -0,0 +1,24 @@ +Your `new package` pull request does not meet the guidelines for auto-merging. Please make sure that you have read the [General registry README](https://github.com/JuliaRegistries/General/blob/master/README.md) and the [AutoMerge guidelines](https://juliaregistries.github.io/RegistryCI.jl/stable/guidelines/). The following guidelines were not met: + +- no + +Note that the guidelines are only required for the pull request to be merged automatically. However, it is **strongly recommended** to follow them, since otherwise the pull request needs to be manually reviewed and merged by a human. + +After you have fixed the AutoMerge issues, simply retrigger Registrator, which will automatically update this pull request. You do not need to change the version number in your `Project.toml` file (unless of course the AutoMerge issue is that you skipped a version number, in which case you should change the version number). + +If you do not want to fix the AutoMerge issues, please post a comment explaining why you would like this pull request to be manually merged. Then, send a message to the `#pkg-registration` channel in the [Julia Slack](https://julialang.org/slack/) to ask for help. Include a link to this pull request. + +Since you are registering a new package, please make sure that you have also read the package naming guidelines: https://pkgdocs.julialang.org/v1/creating-packages/#Package-naming-guidelines + + + +--- +If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text `[noblock]` in your comment. You can edit blocking comments, adding `[noblock]` to them in order to unblock auto-merging. + +--- +On a separate note, I see that you are registering a release with a version number of the form `v0.X.Y`. + +Does your package have a stable public API? If so, then it's time for you to register version `v1.0.0` of your package. (This is not a requirement. It's just a recommendation.) + +If your package does not yet have a stable public API, then of course you are not yet ready to release version `v1.0.0`. + \ No newline at end of file diff --git a/test/reference_comments/comment_pass_false_type_new_package_suggest_onepointzero_true_version_1.0.0_point_to_slack_false.md b/test/reference_comments/comment_pass_false_type_new_package_suggest_onepointzero_true_version_1.0.0_point_to_slack_false.md new file mode 100644 index 00000000..c09d23d6 --- /dev/null +++ b/test/reference_comments/comment_pass_false_type_new_package_suggest_onepointzero_true_version_1.0.0_point_to_slack_false.md @@ -0,0 +1,17 @@ +Your `new package` pull request does not meet the guidelines for auto-merging. Please make sure that you have read the [General registry README](https://github.com/JuliaRegistries/General/blob/master/README.md) and the [AutoMerge guidelines](https://juliaregistries.github.io/RegistryCI.jl/stable/guidelines/). The following guidelines were not met: + +- no + +Note that the guidelines are only required for the pull request to be merged automatically. However, it is **strongly recommended** to follow them, since otherwise the pull request needs to be manually reviewed and merged by a human. + +After you have fixed the AutoMerge issues, simply retrigger Registrator, which will automatically update this pull request. You do not need to change the version number in your `Project.toml` file (unless of course the AutoMerge issue is that you skipped a version number, in which case you should change the version number). + +If you do not want to fix the AutoMerge issues, please post a comment explaining why you would like this pull request to be manually merged. + +Since you are registering a new package, please make sure that you have also read the package naming guidelines: https://pkgdocs.julialang.org/v1/creating-packages/#Package-naming-guidelines + + + +--- +If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text `[noblock]` in your comment. You can edit blocking comments, adding `[noblock]` to them in order to unblock auto-merging. + \ No newline at end of file diff --git a/test/reference_comments/comment_pass_false_type_new_package_suggest_onepointzero_true_version_1.0.0_point_to_slack_true.md b/test/reference_comments/comment_pass_false_type_new_package_suggest_onepointzero_true_version_1.0.0_point_to_slack_true.md new file mode 100644 index 00000000..100b3018 --- /dev/null +++ b/test/reference_comments/comment_pass_false_type_new_package_suggest_onepointzero_true_version_1.0.0_point_to_slack_true.md @@ -0,0 +1,17 @@ +Your `new package` pull request does not meet the guidelines for auto-merging. Please make sure that you have read the [General registry README](https://github.com/JuliaRegistries/General/blob/master/README.md) and the [AutoMerge guidelines](https://juliaregistries.github.io/RegistryCI.jl/stable/guidelines/). The following guidelines were not met: + +- no + +Note that the guidelines are only required for the pull request to be merged automatically. However, it is **strongly recommended** to follow them, since otherwise the pull request needs to be manually reviewed and merged by a human. + +After you have fixed the AutoMerge issues, simply retrigger Registrator, which will automatically update this pull request. You do not need to change the version number in your `Project.toml` file (unless of course the AutoMerge issue is that you skipped a version number, in which case you should change the version number). + +If you do not want to fix the AutoMerge issues, please post a comment explaining why you would like this pull request to be manually merged. Then, send a message to the `#pkg-registration` channel in the [Julia Slack](https://julialang.org/slack/) to ask for help. Include a link to this pull request. + +Since you are registering a new package, please make sure that you have also read the package naming guidelines: https://pkgdocs.julialang.org/v1/creating-packages/#Package-naming-guidelines + + + +--- +If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text `[noblock]` in your comment. You can edit blocking comments, adding `[noblock]` to them in order to unblock auto-merging. + \ No newline at end of file diff --git a/test/reference_comments/comment_pass_false_type_new_version_suggest_onepointzero_false_version_0.1.0_point_to_slack_false.md b/test/reference_comments/comment_pass_false_type_new_version_suggest_onepointzero_false_version_0.1.0_point_to_slack_false.md new file mode 100644 index 00000000..82f6ab67 --- /dev/null +++ b/test/reference_comments/comment_pass_false_type_new_version_suggest_onepointzero_false_version_0.1.0_point_to_slack_false.md @@ -0,0 +1,13 @@ +Your `new version` pull request does not meet the guidelines for auto-merging. Please make sure that you have read the [General registry README](https://github.com/JuliaRegistries/General/blob/master/README.md) and the [AutoMerge guidelines](https://juliaregistries.github.io/RegistryCI.jl/stable/guidelines/). The following guidelines were not met: + +- no + +Note that the guidelines are only required for the pull request to be merged automatically. However, it is **strongly recommended** to follow them, since otherwise the pull request needs to be manually reviewed and merged by a human. + +After you have fixed the AutoMerge issues, simply retrigger Registrator, which will automatically update this pull request. You do not need to change the version number in your `Project.toml` file (unless of course the AutoMerge issue is that you skipped a version number, in which case you should change the version number). + +If you do not want to fix the AutoMerge issues, please post a comment explaining why you would like this pull request to be manually merged. + +--- +If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text `[noblock]` in your comment. You can edit blocking comments, adding `[noblock]` to them in order to unblock auto-merging. + \ No newline at end of file diff --git a/test/reference_comments/comment_pass_false_type_new_version_suggest_onepointzero_false_version_0.1.0_point_to_slack_true.md b/test/reference_comments/comment_pass_false_type_new_version_suggest_onepointzero_false_version_0.1.0_point_to_slack_true.md new file mode 100644 index 00000000..6a620370 --- /dev/null +++ b/test/reference_comments/comment_pass_false_type_new_version_suggest_onepointzero_false_version_0.1.0_point_to_slack_true.md @@ -0,0 +1,13 @@ +Your `new version` pull request does not meet the guidelines for auto-merging. Please make sure that you have read the [General registry README](https://github.com/JuliaRegistries/General/blob/master/README.md) and the [AutoMerge guidelines](https://juliaregistries.github.io/RegistryCI.jl/stable/guidelines/). The following guidelines were not met: + +- no + +Note that the guidelines are only required for the pull request to be merged automatically. However, it is **strongly recommended** to follow them, since otherwise the pull request needs to be manually reviewed and merged by a human. + +After you have fixed the AutoMerge issues, simply retrigger Registrator, which will automatically update this pull request. You do not need to change the version number in your `Project.toml` file (unless of course the AutoMerge issue is that you skipped a version number, in which case you should change the version number). + +If you do not want to fix the AutoMerge issues, please post a comment explaining why you would like this pull request to be manually merged. Then, send a message to the `#pkg-registration` channel in the [Julia Slack](https://julialang.org/slack/) to ask for help. Include a link to this pull request. + +--- +If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text `[noblock]` in your comment. You can edit blocking comments, adding `[noblock]` to them in order to unblock auto-merging. + \ No newline at end of file diff --git a/test/reference_comments/comment_pass_false_type_new_version_suggest_onepointzero_false_version_1.0.0_point_to_slack_false.md b/test/reference_comments/comment_pass_false_type_new_version_suggest_onepointzero_false_version_1.0.0_point_to_slack_false.md new file mode 100644 index 00000000..82f6ab67 --- /dev/null +++ b/test/reference_comments/comment_pass_false_type_new_version_suggest_onepointzero_false_version_1.0.0_point_to_slack_false.md @@ -0,0 +1,13 @@ +Your `new version` pull request does not meet the guidelines for auto-merging. Please make sure that you have read the [General registry README](https://github.com/JuliaRegistries/General/blob/master/README.md) and the [AutoMerge guidelines](https://juliaregistries.github.io/RegistryCI.jl/stable/guidelines/). The following guidelines were not met: + +- no + +Note that the guidelines are only required for the pull request to be merged automatically. However, it is **strongly recommended** to follow them, since otherwise the pull request needs to be manually reviewed and merged by a human. + +After you have fixed the AutoMerge issues, simply retrigger Registrator, which will automatically update this pull request. You do not need to change the version number in your `Project.toml` file (unless of course the AutoMerge issue is that you skipped a version number, in which case you should change the version number). + +If you do not want to fix the AutoMerge issues, please post a comment explaining why you would like this pull request to be manually merged. + +--- +If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text `[noblock]` in your comment. You can edit blocking comments, adding `[noblock]` to them in order to unblock auto-merging. + \ No newline at end of file diff --git a/test/reference_comments/comment_pass_false_type_new_version_suggest_onepointzero_false_version_1.0.0_point_to_slack_true.md b/test/reference_comments/comment_pass_false_type_new_version_suggest_onepointzero_false_version_1.0.0_point_to_slack_true.md new file mode 100644 index 00000000..6a620370 --- /dev/null +++ b/test/reference_comments/comment_pass_false_type_new_version_suggest_onepointzero_false_version_1.0.0_point_to_slack_true.md @@ -0,0 +1,13 @@ +Your `new version` pull request does not meet the guidelines for auto-merging. Please make sure that you have read the [General registry README](https://github.com/JuliaRegistries/General/blob/master/README.md) and the [AutoMerge guidelines](https://juliaregistries.github.io/RegistryCI.jl/stable/guidelines/). The following guidelines were not met: + +- no + +Note that the guidelines are only required for the pull request to be merged automatically. However, it is **strongly recommended** to follow them, since otherwise the pull request needs to be manually reviewed and merged by a human. + +After you have fixed the AutoMerge issues, simply retrigger Registrator, which will automatically update this pull request. You do not need to change the version number in your `Project.toml` file (unless of course the AutoMerge issue is that you skipped a version number, in which case you should change the version number). + +If you do not want to fix the AutoMerge issues, please post a comment explaining why you would like this pull request to be manually merged. Then, send a message to the `#pkg-registration` channel in the [Julia Slack](https://julialang.org/slack/) to ask for help. Include a link to this pull request. + +--- +If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text `[noblock]` in your comment. You can edit blocking comments, adding `[noblock]` to them in order to unblock auto-merging. + \ No newline at end of file diff --git a/test/reference_comments/comment_pass_false_type_new_version_suggest_onepointzero_true_version_0.1.0_point_to_slack_false.md b/test/reference_comments/comment_pass_false_type_new_version_suggest_onepointzero_true_version_0.1.0_point_to_slack_false.md new file mode 100644 index 00000000..99a7a63b --- /dev/null +++ b/test/reference_comments/comment_pass_false_type_new_version_suggest_onepointzero_true_version_0.1.0_point_to_slack_false.md @@ -0,0 +1,20 @@ +Your `new version` pull request does not meet the guidelines for auto-merging. Please make sure that you have read the [General registry README](https://github.com/JuliaRegistries/General/blob/master/README.md) and the [AutoMerge guidelines](https://juliaregistries.github.io/RegistryCI.jl/stable/guidelines/). The following guidelines were not met: + +- no + +Note that the guidelines are only required for the pull request to be merged automatically. However, it is **strongly recommended** to follow them, since otherwise the pull request needs to be manually reviewed and merged by a human. + +After you have fixed the AutoMerge issues, simply retrigger Registrator, which will automatically update this pull request. You do not need to change the version number in your `Project.toml` file (unless of course the AutoMerge issue is that you skipped a version number, in which case you should change the version number). + +If you do not want to fix the AutoMerge issues, please post a comment explaining why you would like this pull request to be manually merged. + +--- +If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text `[noblock]` in your comment. You can edit blocking comments, adding `[noblock]` to them in order to unblock auto-merging. + +--- +On a separate note, I see that you are registering a release with a version number of the form `v0.X.Y`. + +Does your package have a stable public API? If so, then it's time for you to register version `v1.0.0` of your package. (This is not a requirement. It's just a recommendation.) + +If your package does not yet have a stable public API, then of course you are not yet ready to release version `v1.0.0`. + \ No newline at end of file diff --git a/test/reference_comments/comment_pass_false_type_new_version_suggest_onepointzero_true_version_0.1.0_point_to_slack_true.md b/test/reference_comments/comment_pass_false_type_new_version_suggest_onepointzero_true_version_0.1.0_point_to_slack_true.md new file mode 100644 index 00000000..e0dadb2e --- /dev/null +++ b/test/reference_comments/comment_pass_false_type_new_version_suggest_onepointzero_true_version_0.1.0_point_to_slack_true.md @@ -0,0 +1,20 @@ +Your `new version` pull request does not meet the guidelines for auto-merging. Please make sure that you have read the [General registry README](https://github.com/JuliaRegistries/General/blob/master/README.md) and the [AutoMerge guidelines](https://juliaregistries.github.io/RegistryCI.jl/stable/guidelines/). The following guidelines were not met: + +- no + +Note that the guidelines are only required for the pull request to be merged automatically. However, it is **strongly recommended** to follow them, since otherwise the pull request needs to be manually reviewed and merged by a human. + +After you have fixed the AutoMerge issues, simply retrigger Registrator, which will automatically update this pull request. You do not need to change the version number in your `Project.toml` file (unless of course the AutoMerge issue is that you skipped a version number, in which case you should change the version number). + +If you do not want to fix the AutoMerge issues, please post a comment explaining why you would like this pull request to be manually merged. Then, send a message to the `#pkg-registration` channel in the [Julia Slack](https://julialang.org/slack/) to ask for help. Include a link to this pull request. + +--- +If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text `[noblock]` in your comment. You can edit blocking comments, adding `[noblock]` to them in order to unblock auto-merging. + +--- +On a separate note, I see that you are registering a release with a version number of the form `v0.X.Y`. + +Does your package have a stable public API? If so, then it's time for you to register version `v1.0.0` of your package. (This is not a requirement. It's just a recommendation.) + +If your package does not yet have a stable public API, then of course you are not yet ready to release version `v1.0.0`. + \ No newline at end of file diff --git a/test/reference_comments/comment_pass_false_type_new_version_suggest_onepointzero_true_version_1.0.0_point_to_slack_false.md b/test/reference_comments/comment_pass_false_type_new_version_suggest_onepointzero_true_version_1.0.0_point_to_slack_false.md new file mode 100644 index 00000000..82f6ab67 --- /dev/null +++ b/test/reference_comments/comment_pass_false_type_new_version_suggest_onepointzero_true_version_1.0.0_point_to_slack_false.md @@ -0,0 +1,13 @@ +Your `new version` pull request does not meet the guidelines for auto-merging. Please make sure that you have read the [General registry README](https://github.com/JuliaRegistries/General/blob/master/README.md) and the [AutoMerge guidelines](https://juliaregistries.github.io/RegistryCI.jl/stable/guidelines/). The following guidelines were not met: + +- no + +Note that the guidelines are only required for the pull request to be merged automatically. However, it is **strongly recommended** to follow them, since otherwise the pull request needs to be manually reviewed and merged by a human. + +After you have fixed the AutoMerge issues, simply retrigger Registrator, which will automatically update this pull request. You do not need to change the version number in your `Project.toml` file (unless of course the AutoMerge issue is that you skipped a version number, in which case you should change the version number). + +If you do not want to fix the AutoMerge issues, please post a comment explaining why you would like this pull request to be manually merged. + +--- +If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text `[noblock]` in your comment. You can edit blocking comments, adding `[noblock]` to them in order to unblock auto-merging. + \ No newline at end of file diff --git a/test/reference_comments/comment_pass_false_type_new_version_suggest_onepointzero_true_version_1.0.0_point_to_slack_true.md b/test/reference_comments/comment_pass_false_type_new_version_suggest_onepointzero_true_version_1.0.0_point_to_slack_true.md new file mode 100644 index 00000000..6a620370 --- /dev/null +++ b/test/reference_comments/comment_pass_false_type_new_version_suggest_onepointzero_true_version_1.0.0_point_to_slack_true.md @@ -0,0 +1,13 @@ +Your `new version` pull request does not meet the guidelines for auto-merging. Please make sure that you have read the [General registry README](https://github.com/JuliaRegistries/General/blob/master/README.md) and the [AutoMerge guidelines](https://juliaregistries.github.io/RegistryCI.jl/stable/guidelines/). The following guidelines were not met: + +- no + +Note that the guidelines are only required for the pull request to be merged automatically. However, it is **strongly recommended** to follow them, since otherwise the pull request needs to be manually reviewed and merged by a human. + +After you have fixed the AutoMerge issues, simply retrigger Registrator, which will automatically update this pull request. You do not need to change the version number in your `Project.toml` file (unless of course the AutoMerge issue is that you skipped a version number, in which case you should change the version number). + +If you do not want to fix the AutoMerge issues, please post a comment explaining why you would like this pull request to be manually merged. Then, send a message to the `#pkg-registration` channel in the [Julia Slack](https://julialang.org/slack/) to ask for help. Include a link to this pull request. + +--- +If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text `[noblock]` in your comment. You can edit blocking comments, adding `[noblock]` to them in order to unblock auto-merging. + \ No newline at end of file diff --git a/test/reference_comments/comment_pass_true_type_new_package_suggest_onepointzero_false_version_0.1.0_is_jll_false.md b/test/reference_comments/comment_pass_true_type_new_package_suggest_onepointzero_false_version_0.1.0_is_jll_false.md new file mode 100644 index 00000000..2db19b5a --- /dev/null +++ b/test/reference_comments/comment_pass_true_type_new_package_suggest_onepointzero_false_version_0.1.0_is_jll_false.md @@ -0,0 +1,9 @@ +Your `new package` pull request met all of the guidelines for auto-merging and is scheduled to be merged when the mandatory waiting period (3 days) has elapsed. + +Since you are registering a new package, please make sure that you have read the package naming guidelines: https://pkgdocs.julialang.org/v1/creating-packages/#Package-naming-guidelines + + + +--- +If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text `[noblock]` in your comment. You can edit blocking comments, adding `[noblock]` to them in order to unblock auto-merging. + \ No newline at end of file diff --git a/test/reference_comments/comment_pass_true_type_new_package_suggest_onepointzero_false_version_0.1.0_is_jll_true.md b/test/reference_comments/comment_pass_true_type_new_package_suggest_onepointzero_false_version_0.1.0_is_jll_true.md new file mode 100644 index 00000000..a92361e0 --- /dev/null +++ b/test/reference_comments/comment_pass_true_type_new_package_suggest_onepointzero_false_version_0.1.0_is_jll_true.md @@ -0,0 +1,7 @@ +Your `new _jll package` pull request met all of the guidelines for auto-merging and is scheduled to be merged in the next round. + + + +--- +If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text `[noblock]` in your comment. You can edit blocking comments, adding `[noblock]` to them in order to unblock auto-merging. + \ No newline at end of file diff --git a/test/reference_comments/comment_pass_true_type_new_package_suggest_onepointzero_false_version_1.0.0_is_jll_false.md b/test/reference_comments/comment_pass_true_type_new_package_suggest_onepointzero_false_version_1.0.0_is_jll_false.md new file mode 100644 index 00000000..2db19b5a --- /dev/null +++ b/test/reference_comments/comment_pass_true_type_new_package_suggest_onepointzero_false_version_1.0.0_is_jll_false.md @@ -0,0 +1,9 @@ +Your `new package` pull request met all of the guidelines for auto-merging and is scheduled to be merged when the mandatory waiting period (3 days) has elapsed. + +Since you are registering a new package, please make sure that you have read the package naming guidelines: https://pkgdocs.julialang.org/v1/creating-packages/#Package-naming-guidelines + + + +--- +If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text `[noblock]` in your comment. You can edit blocking comments, adding `[noblock]` to them in order to unblock auto-merging. + \ No newline at end of file diff --git a/test/reference_comments/comment_pass_true_type_new_package_suggest_onepointzero_false_version_1.0.0_is_jll_true.md b/test/reference_comments/comment_pass_true_type_new_package_suggest_onepointzero_false_version_1.0.0_is_jll_true.md new file mode 100644 index 00000000..a92361e0 --- /dev/null +++ b/test/reference_comments/comment_pass_true_type_new_package_suggest_onepointzero_false_version_1.0.0_is_jll_true.md @@ -0,0 +1,7 @@ +Your `new _jll package` pull request met all of the guidelines for auto-merging and is scheduled to be merged in the next round. + + + +--- +If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text `[noblock]` in your comment. You can edit blocking comments, adding `[noblock]` to them in order to unblock auto-merging. + \ No newline at end of file diff --git a/test/reference_comments/comment_pass_true_type_new_package_suggest_onepointzero_true_version_0.1.0_is_jll_false.md b/test/reference_comments/comment_pass_true_type_new_package_suggest_onepointzero_true_version_0.1.0_is_jll_false.md new file mode 100644 index 00000000..3d4e1993 --- /dev/null +++ b/test/reference_comments/comment_pass_true_type_new_package_suggest_onepointzero_true_version_0.1.0_is_jll_false.md @@ -0,0 +1,16 @@ +Your `new package` pull request met all of the guidelines for auto-merging and is scheduled to be merged when the mandatory waiting period (3 days) has elapsed. + +Since you are registering a new package, please make sure that you have read the package naming guidelines: https://pkgdocs.julialang.org/v1/creating-packages/#Package-naming-guidelines + + + +--- +If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text `[noblock]` in your comment. You can edit blocking comments, adding `[noblock]` to them in order to unblock auto-merging. + +--- +On a separate note, I see that you are registering a release with a version number of the form `v0.X.Y`. + +Does your package have a stable public API? If so, then it's time for you to register version `v1.0.0` of your package. (This is not a requirement. It's just a recommendation.) + +If your package does not yet have a stable public API, then of course you are not yet ready to release version `v1.0.0`. + \ No newline at end of file diff --git a/test/reference_comments/comment_pass_true_type_new_package_suggest_onepointzero_true_version_0.1.0_is_jll_true.md b/test/reference_comments/comment_pass_true_type_new_package_suggest_onepointzero_true_version_0.1.0_is_jll_true.md new file mode 100644 index 00000000..8d857815 --- /dev/null +++ b/test/reference_comments/comment_pass_true_type_new_package_suggest_onepointzero_true_version_0.1.0_is_jll_true.md @@ -0,0 +1,14 @@ +Your `new _jll package` pull request met all of the guidelines for auto-merging and is scheduled to be merged in the next round. + + + +--- +If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text `[noblock]` in your comment. You can edit blocking comments, adding `[noblock]` to them in order to unblock auto-merging. + +--- +On a separate note, I see that you are registering a release with a version number of the form `v0.X.Y`. + +Does your package have a stable public API? If so, then it's time for you to register version `v1.0.0` of your package. (This is not a requirement. It's just a recommendation.) + +If your package does not yet have a stable public API, then of course you are not yet ready to release version `v1.0.0`. + \ No newline at end of file diff --git a/test/reference_comments/comment_pass_true_type_new_package_suggest_onepointzero_true_version_1.0.0_is_jll_false.md b/test/reference_comments/comment_pass_true_type_new_package_suggest_onepointzero_true_version_1.0.0_is_jll_false.md new file mode 100644 index 00000000..2db19b5a --- /dev/null +++ b/test/reference_comments/comment_pass_true_type_new_package_suggest_onepointzero_true_version_1.0.0_is_jll_false.md @@ -0,0 +1,9 @@ +Your `new package` pull request met all of the guidelines for auto-merging and is scheduled to be merged when the mandatory waiting period (3 days) has elapsed. + +Since you are registering a new package, please make sure that you have read the package naming guidelines: https://pkgdocs.julialang.org/v1/creating-packages/#Package-naming-guidelines + + + +--- +If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text `[noblock]` in your comment. You can edit blocking comments, adding `[noblock]` to them in order to unblock auto-merging. + \ No newline at end of file diff --git a/test/reference_comments/comment_pass_true_type_new_package_suggest_onepointzero_true_version_1.0.0_is_jll_true.md b/test/reference_comments/comment_pass_true_type_new_package_suggest_onepointzero_true_version_1.0.0_is_jll_true.md new file mode 100644 index 00000000..a92361e0 --- /dev/null +++ b/test/reference_comments/comment_pass_true_type_new_package_suggest_onepointzero_true_version_1.0.0_is_jll_true.md @@ -0,0 +1,7 @@ +Your `new _jll package` pull request met all of the guidelines for auto-merging and is scheduled to be merged in the next round. + + + +--- +If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text `[noblock]` in your comment. You can edit blocking comments, adding `[noblock]` to them in order to unblock auto-merging. + \ No newline at end of file diff --git a/test/reference_comments/comment_pass_true_type_new_version_suggest_onepointzero_false_version_0.1.0_is_jll_false.md b/test/reference_comments/comment_pass_true_type_new_version_suggest_onepointzero_false_version_0.1.0_is_jll_false.md new file mode 100644 index 00000000..4347fb6d --- /dev/null +++ b/test/reference_comments/comment_pass_true_type_new_version_suggest_onepointzero_false_version_0.1.0_is_jll_false.md @@ -0,0 +1,5 @@ +Your `new version` pull request met all of the guidelines for auto-merging and is scheduled to be merged in the next round. + +--- +If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text `[noblock]` in your comment. You can edit blocking comments, adding `[noblock]` to them in order to unblock auto-merging. + \ No newline at end of file diff --git a/test/reference_comments/comment_pass_true_type_new_version_suggest_onepointzero_false_version_0.1.0_is_jll_true.md b/test/reference_comments/comment_pass_true_type_new_version_suggest_onepointzero_false_version_0.1.0_is_jll_true.md new file mode 100644 index 00000000..4347fb6d --- /dev/null +++ b/test/reference_comments/comment_pass_true_type_new_version_suggest_onepointzero_false_version_0.1.0_is_jll_true.md @@ -0,0 +1,5 @@ +Your `new version` pull request met all of the guidelines for auto-merging and is scheduled to be merged in the next round. + +--- +If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text `[noblock]` in your comment. You can edit blocking comments, adding `[noblock]` to them in order to unblock auto-merging. + \ No newline at end of file diff --git a/test/reference_comments/comment_pass_true_type_new_version_suggest_onepointzero_false_version_1.0.0_is_jll_false.md b/test/reference_comments/comment_pass_true_type_new_version_suggest_onepointzero_false_version_1.0.0_is_jll_false.md new file mode 100644 index 00000000..4347fb6d --- /dev/null +++ b/test/reference_comments/comment_pass_true_type_new_version_suggest_onepointzero_false_version_1.0.0_is_jll_false.md @@ -0,0 +1,5 @@ +Your `new version` pull request met all of the guidelines for auto-merging and is scheduled to be merged in the next round. + +--- +If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text `[noblock]` in your comment. You can edit blocking comments, adding `[noblock]` to them in order to unblock auto-merging. + \ No newline at end of file diff --git a/test/reference_comments/comment_pass_true_type_new_version_suggest_onepointzero_false_version_1.0.0_is_jll_true.md b/test/reference_comments/comment_pass_true_type_new_version_suggest_onepointzero_false_version_1.0.0_is_jll_true.md new file mode 100644 index 00000000..4347fb6d --- /dev/null +++ b/test/reference_comments/comment_pass_true_type_new_version_suggest_onepointzero_false_version_1.0.0_is_jll_true.md @@ -0,0 +1,5 @@ +Your `new version` pull request met all of the guidelines for auto-merging and is scheduled to be merged in the next round. + +--- +If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text `[noblock]` in your comment. You can edit blocking comments, adding `[noblock]` to them in order to unblock auto-merging. + \ No newline at end of file diff --git a/test/reference_comments/comment_pass_true_type_new_version_suggest_onepointzero_true_version_0.1.0_is_jll_false.md b/test/reference_comments/comment_pass_true_type_new_version_suggest_onepointzero_true_version_0.1.0_is_jll_false.md new file mode 100644 index 00000000..db26cf44 --- /dev/null +++ b/test/reference_comments/comment_pass_true_type_new_version_suggest_onepointzero_true_version_0.1.0_is_jll_false.md @@ -0,0 +1,12 @@ +Your `new version` pull request met all of the guidelines for auto-merging and is scheduled to be merged in the next round. + +--- +If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text `[noblock]` in your comment. You can edit blocking comments, adding `[noblock]` to them in order to unblock auto-merging. + +--- +On a separate note, I see that you are registering a release with a version number of the form `v0.X.Y`. + +Does your package have a stable public API? If so, then it's time for you to register version `v1.0.0` of your package. (This is not a requirement. It's just a recommendation.) + +If your package does not yet have a stable public API, then of course you are not yet ready to release version `v1.0.0`. + \ No newline at end of file diff --git a/test/reference_comments/comment_pass_true_type_new_version_suggest_onepointzero_true_version_0.1.0_is_jll_true.md b/test/reference_comments/comment_pass_true_type_new_version_suggest_onepointzero_true_version_0.1.0_is_jll_true.md new file mode 100644 index 00000000..db26cf44 --- /dev/null +++ b/test/reference_comments/comment_pass_true_type_new_version_suggest_onepointzero_true_version_0.1.0_is_jll_true.md @@ -0,0 +1,12 @@ +Your `new version` pull request met all of the guidelines for auto-merging and is scheduled to be merged in the next round. + +--- +If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text `[noblock]` in your comment. You can edit blocking comments, adding `[noblock]` to them in order to unblock auto-merging. + +--- +On a separate note, I see that you are registering a release with a version number of the form `v0.X.Y`. + +Does your package have a stable public API? If so, then it's time for you to register version `v1.0.0` of your package. (This is not a requirement. It's just a recommendation.) + +If your package does not yet have a stable public API, then of course you are not yet ready to release version `v1.0.0`. + \ No newline at end of file diff --git a/test/reference_comments/comment_pass_true_type_new_version_suggest_onepointzero_true_version_1.0.0_is_jll_false.md b/test/reference_comments/comment_pass_true_type_new_version_suggest_onepointzero_true_version_1.0.0_is_jll_false.md new file mode 100644 index 00000000..4347fb6d --- /dev/null +++ b/test/reference_comments/comment_pass_true_type_new_version_suggest_onepointzero_true_version_1.0.0_is_jll_false.md @@ -0,0 +1,5 @@ +Your `new version` pull request met all of the guidelines for auto-merging and is scheduled to be merged in the next round. + +--- +If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text `[noblock]` in your comment. You can edit blocking comments, adding `[noblock]` to them in order to unblock auto-merging. + \ No newline at end of file diff --git a/test/reference_comments/comment_pass_true_type_new_version_suggest_onepointzero_true_version_1.0.0_is_jll_true.md b/test/reference_comments/comment_pass_true_type_new_version_suggest_onepointzero_true_version_1.0.0_is_jll_true.md new file mode 100644 index 00000000..4347fb6d --- /dev/null +++ b/test/reference_comments/comment_pass_true_type_new_version_suggest_onepointzero_true_version_1.0.0_is_jll_true.md @@ -0,0 +1,5 @@ +Your `new version` pull request met all of the guidelines for auto-merging and is scheduled to be merged in the next round. + +--- +If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text `[noblock]` in your comment. You can edit blocking comments, adding `[noblock]` to them in order to unblock auto-merging. + \ No newline at end of file diff --git a/test/runtests.jl b/test/runtests.jl index 00878980..c829b0a1 100644 --- a/test/runtests.jl +++ b/test/runtests.jl @@ -7,6 +7,7 @@ using Printf using RegistryCI using Test using TimeZones +using ReferenceTests const AutoMerge = RegistryCI.AutoMerge From 580b91c9b660d3b0a54c816f31898315525a0d69 Mon Sep 17 00:00:00 2001 From: Eric Hanson <5846501+ericphanson@users.noreply.github.com> Date: Tue, 30 Jan 2024 21:17:50 +0100 Subject: [PATCH 02/11] up --- test/automerge-unit.jl | 4 ++-- ...t_onepointzero_false_version_0.1.0_point_to_slack_false.md | 2 +- ...st_onepointzero_false_version_0.1.0_point_to_slack_true.md | 2 +- ...t_onepointzero_false_version_1.0.0_point_to_slack_false.md | 2 +- ...st_onepointzero_false_version_1.0.0_point_to_slack_true.md | 2 +- ...st_onepointzero_true_version_0.1.0_point_to_slack_false.md | 2 +- ...est_onepointzero_true_version_0.1.0_point_to_slack_true.md | 2 +- ...st_onepointzero_true_version_1.0.0_point_to_slack_false.md | 2 +- ...est_onepointzero_true_version_1.0.0_point_to_slack_true.md | 2 +- ...t_onepointzero_false_version_0.1.0_point_to_slack_false.md | 2 +- ...st_onepointzero_false_version_0.1.0_point_to_slack_true.md | 2 +- ...t_onepointzero_false_version_1.0.0_point_to_slack_false.md | 2 +- ...st_onepointzero_false_version_1.0.0_point_to_slack_true.md | 2 +- ...st_onepointzero_true_version_0.1.0_point_to_slack_false.md | 2 +- ...est_onepointzero_true_version_0.1.0_point_to_slack_true.md | 2 +- ...st_onepointzero_true_version_1.0.0_point_to_slack_false.md | 2 +- ...est_onepointzero_true_version_1.0.0_point_to_slack_true.md | 2 +- 17 files changed, 18 insertions(+), 18 deletions(-) diff --git a/test/automerge-unit.jl b/test/automerge-unit.jl index ce1a2e34..2b6c2e0b 100644 --- a/test/automerge-unit.jl +++ b/test/automerge-unit.jl @@ -52,7 +52,7 @@ function comment_reference_test() (type_name,type) in (("new_version", AutoMerge.NewVersion()), ("new_package", AutoMerge.NewPackage())), suggest_onepointzero in (true, false), # some code depends on above or below v"1" - version in (v"0.1.1", v"1.1.1") + version in (v"0.1", v"1") if pass for is_jll in (true, false) @@ -73,7 +73,7 @@ function comment_reference_test() # `point_to_slack=false` should yield no references to Slack in the text if !point_to_slack - @test !contains(text, "slack") + @test !contains(fail_text, "slack") end end end diff --git a/test/reference_comments/comment_pass_false_type_new_package_suggest_onepointzero_false_version_0.1.0_point_to_slack_false.md b/test/reference_comments/comment_pass_false_type_new_package_suggest_onepointzero_false_version_0.1.0_point_to_slack_false.md index c09d23d6..451fd363 100644 --- a/test/reference_comments/comment_pass_false_type_new_package_suggest_onepointzero_false_version_0.1.0_point_to_slack_false.md +++ b/test/reference_comments/comment_pass_false_type_new_package_suggest_onepointzero_false_version_0.1.0_point_to_slack_false.md @@ -1,6 +1,6 @@ Your `new package` pull request does not meet the guidelines for auto-merging. Please make sure that you have read the [General registry README](https://github.com/JuliaRegistries/General/blob/master/README.md) and the [AutoMerge guidelines](https://juliaregistries.github.io/RegistryCI.jl/stable/guidelines/). The following guidelines were not met: -- no +- Example guideline failed. Please fix it. Note that the guidelines are only required for the pull request to be merged automatically. However, it is **strongly recommended** to follow them, since otherwise the pull request needs to be manually reviewed and merged by a human. diff --git a/test/reference_comments/comment_pass_false_type_new_package_suggest_onepointzero_false_version_0.1.0_point_to_slack_true.md b/test/reference_comments/comment_pass_false_type_new_package_suggest_onepointzero_false_version_0.1.0_point_to_slack_true.md index 100b3018..7fee4fdb 100644 --- a/test/reference_comments/comment_pass_false_type_new_package_suggest_onepointzero_false_version_0.1.0_point_to_slack_true.md +++ b/test/reference_comments/comment_pass_false_type_new_package_suggest_onepointzero_false_version_0.1.0_point_to_slack_true.md @@ -1,6 +1,6 @@ Your `new package` pull request does not meet the guidelines for auto-merging. Please make sure that you have read the [General registry README](https://github.com/JuliaRegistries/General/blob/master/README.md) and the [AutoMerge guidelines](https://juliaregistries.github.io/RegistryCI.jl/stable/guidelines/). The following guidelines were not met: -- no +- Example guideline failed. Please fix it. Note that the guidelines are only required for the pull request to be merged automatically. However, it is **strongly recommended** to follow them, since otherwise the pull request needs to be manually reviewed and merged by a human. diff --git a/test/reference_comments/comment_pass_false_type_new_package_suggest_onepointzero_false_version_1.0.0_point_to_slack_false.md b/test/reference_comments/comment_pass_false_type_new_package_suggest_onepointzero_false_version_1.0.0_point_to_slack_false.md index c09d23d6..451fd363 100644 --- a/test/reference_comments/comment_pass_false_type_new_package_suggest_onepointzero_false_version_1.0.0_point_to_slack_false.md +++ b/test/reference_comments/comment_pass_false_type_new_package_suggest_onepointzero_false_version_1.0.0_point_to_slack_false.md @@ -1,6 +1,6 @@ Your `new package` pull request does not meet the guidelines for auto-merging. Please make sure that you have read the [General registry README](https://github.com/JuliaRegistries/General/blob/master/README.md) and the [AutoMerge guidelines](https://juliaregistries.github.io/RegistryCI.jl/stable/guidelines/). The following guidelines were not met: -- no +- Example guideline failed. Please fix it. Note that the guidelines are only required for the pull request to be merged automatically. However, it is **strongly recommended** to follow them, since otherwise the pull request needs to be manually reviewed and merged by a human. diff --git a/test/reference_comments/comment_pass_false_type_new_package_suggest_onepointzero_false_version_1.0.0_point_to_slack_true.md b/test/reference_comments/comment_pass_false_type_new_package_suggest_onepointzero_false_version_1.0.0_point_to_slack_true.md index 100b3018..7fee4fdb 100644 --- a/test/reference_comments/comment_pass_false_type_new_package_suggest_onepointzero_false_version_1.0.0_point_to_slack_true.md +++ b/test/reference_comments/comment_pass_false_type_new_package_suggest_onepointzero_false_version_1.0.0_point_to_slack_true.md @@ -1,6 +1,6 @@ Your `new package` pull request does not meet the guidelines for auto-merging. Please make sure that you have read the [General registry README](https://github.com/JuliaRegistries/General/blob/master/README.md) and the [AutoMerge guidelines](https://juliaregistries.github.io/RegistryCI.jl/stable/guidelines/). The following guidelines were not met: -- no +- Example guideline failed. Please fix it. Note that the guidelines are only required for the pull request to be merged automatically. However, it is **strongly recommended** to follow them, since otherwise the pull request needs to be manually reviewed and merged by a human. diff --git a/test/reference_comments/comment_pass_false_type_new_package_suggest_onepointzero_true_version_0.1.0_point_to_slack_false.md b/test/reference_comments/comment_pass_false_type_new_package_suggest_onepointzero_true_version_0.1.0_point_to_slack_false.md index 0f052457..84d0e07b 100644 --- a/test/reference_comments/comment_pass_false_type_new_package_suggest_onepointzero_true_version_0.1.0_point_to_slack_false.md +++ b/test/reference_comments/comment_pass_false_type_new_package_suggest_onepointzero_true_version_0.1.0_point_to_slack_false.md @@ -1,6 +1,6 @@ Your `new package` pull request does not meet the guidelines for auto-merging. Please make sure that you have read the [General registry README](https://github.com/JuliaRegistries/General/blob/master/README.md) and the [AutoMerge guidelines](https://juliaregistries.github.io/RegistryCI.jl/stable/guidelines/). The following guidelines were not met: -- no +- Example guideline failed. Please fix it. Note that the guidelines are only required for the pull request to be merged automatically. However, it is **strongly recommended** to follow them, since otherwise the pull request needs to be manually reviewed and merged by a human. diff --git a/test/reference_comments/comment_pass_false_type_new_package_suggest_onepointzero_true_version_0.1.0_point_to_slack_true.md b/test/reference_comments/comment_pass_false_type_new_package_suggest_onepointzero_true_version_0.1.0_point_to_slack_true.md index f1cc828b..5fa5a742 100644 --- a/test/reference_comments/comment_pass_false_type_new_package_suggest_onepointzero_true_version_0.1.0_point_to_slack_true.md +++ b/test/reference_comments/comment_pass_false_type_new_package_suggest_onepointzero_true_version_0.1.0_point_to_slack_true.md @@ -1,6 +1,6 @@ Your `new package` pull request does not meet the guidelines for auto-merging. Please make sure that you have read the [General registry README](https://github.com/JuliaRegistries/General/blob/master/README.md) and the [AutoMerge guidelines](https://juliaregistries.github.io/RegistryCI.jl/stable/guidelines/). The following guidelines were not met: -- no +- Example guideline failed. Please fix it. Note that the guidelines are only required for the pull request to be merged automatically. However, it is **strongly recommended** to follow them, since otherwise the pull request needs to be manually reviewed and merged by a human. diff --git a/test/reference_comments/comment_pass_false_type_new_package_suggest_onepointzero_true_version_1.0.0_point_to_slack_false.md b/test/reference_comments/comment_pass_false_type_new_package_suggest_onepointzero_true_version_1.0.0_point_to_slack_false.md index c09d23d6..451fd363 100644 --- a/test/reference_comments/comment_pass_false_type_new_package_suggest_onepointzero_true_version_1.0.0_point_to_slack_false.md +++ b/test/reference_comments/comment_pass_false_type_new_package_suggest_onepointzero_true_version_1.0.0_point_to_slack_false.md @@ -1,6 +1,6 @@ Your `new package` pull request does not meet the guidelines for auto-merging. Please make sure that you have read the [General registry README](https://github.com/JuliaRegistries/General/blob/master/README.md) and the [AutoMerge guidelines](https://juliaregistries.github.io/RegistryCI.jl/stable/guidelines/). The following guidelines were not met: -- no +- Example guideline failed. Please fix it. Note that the guidelines are only required for the pull request to be merged automatically. However, it is **strongly recommended** to follow them, since otherwise the pull request needs to be manually reviewed and merged by a human. diff --git a/test/reference_comments/comment_pass_false_type_new_package_suggest_onepointzero_true_version_1.0.0_point_to_slack_true.md b/test/reference_comments/comment_pass_false_type_new_package_suggest_onepointzero_true_version_1.0.0_point_to_slack_true.md index 100b3018..7fee4fdb 100644 --- a/test/reference_comments/comment_pass_false_type_new_package_suggest_onepointzero_true_version_1.0.0_point_to_slack_true.md +++ b/test/reference_comments/comment_pass_false_type_new_package_suggest_onepointzero_true_version_1.0.0_point_to_slack_true.md @@ -1,6 +1,6 @@ Your `new package` pull request does not meet the guidelines for auto-merging. Please make sure that you have read the [General registry README](https://github.com/JuliaRegistries/General/blob/master/README.md) and the [AutoMerge guidelines](https://juliaregistries.github.io/RegistryCI.jl/stable/guidelines/). The following guidelines were not met: -- no +- Example guideline failed. Please fix it. Note that the guidelines are only required for the pull request to be merged automatically. However, it is **strongly recommended** to follow them, since otherwise the pull request needs to be manually reviewed and merged by a human. diff --git a/test/reference_comments/comment_pass_false_type_new_version_suggest_onepointzero_false_version_0.1.0_point_to_slack_false.md b/test/reference_comments/comment_pass_false_type_new_version_suggest_onepointzero_false_version_0.1.0_point_to_slack_false.md index 82f6ab67..deb220d4 100644 --- a/test/reference_comments/comment_pass_false_type_new_version_suggest_onepointzero_false_version_0.1.0_point_to_slack_false.md +++ b/test/reference_comments/comment_pass_false_type_new_version_suggest_onepointzero_false_version_0.1.0_point_to_slack_false.md @@ -1,6 +1,6 @@ Your `new version` pull request does not meet the guidelines for auto-merging. Please make sure that you have read the [General registry README](https://github.com/JuliaRegistries/General/blob/master/README.md) and the [AutoMerge guidelines](https://juliaregistries.github.io/RegistryCI.jl/stable/guidelines/). The following guidelines were not met: -- no +- Example guideline failed. Please fix it. Note that the guidelines are only required for the pull request to be merged automatically. However, it is **strongly recommended** to follow them, since otherwise the pull request needs to be manually reviewed and merged by a human. diff --git a/test/reference_comments/comment_pass_false_type_new_version_suggest_onepointzero_false_version_0.1.0_point_to_slack_true.md b/test/reference_comments/comment_pass_false_type_new_version_suggest_onepointzero_false_version_0.1.0_point_to_slack_true.md index 6a620370..ec12ec1c 100644 --- a/test/reference_comments/comment_pass_false_type_new_version_suggest_onepointzero_false_version_0.1.0_point_to_slack_true.md +++ b/test/reference_comments/comment_pass_false_type_new_version_suggest_onepointzero_false_version_0.1.0_point_to_slack_true.md @@ -1,6 +1,6 @@ Your `new version` pull request does not meet the guidelines for auto-merging. Please make sure that you have read the [General registry README](https://github.com/JuliaRegistries/General/blob/master/README.md) and the [AutoMerge guidelines](https://juliaregistries.github.io/RegistryCI.jl/stable/guidelines/). The following guidelines were not met: -- no +- Example guideline failed. Please fix it. Note that the guidelines are only required for the pull request to be merged automatically. However, it is **strongly recommended** to follow them, since otherwise the pull request needs to be manually reviewed and merged by a human. diff --git a/test/reference_comments/comment_pass_false_type_new_version_suggest_onepointzero_false_version_1.0.0_point_to_slack_false.md b/test/reference_comments/comment_pass_false_type_new_version_suggest_onepointzero_false_version_1.0.0_point_to_slack_false.md index 82f6ab67..deb220d4 100644 --- a/test/reference_comments/comment_pass_false_type_new_version_suggest_onepointzero_false_version_1.0.0_point_to_slack_false.md +++ b/test/reference_comments/comment_pass_false_type_new_version_suggest_onepointzero_false_version_1.0.0_point_to_slack_false.md @@ -1,6 +1,6 @@ Your `new version` pull request does not meet the guidelines for auto-merging. Please make sure that you have read the [General registry README](https://github.com/JuliaRegistries/General/blob/master/README.md) and the [AutoMerge guidelines](https://juliaregistries.github.io/RegistryCI.jl/stable/guidelines/). The following guidelines were not met: -- no +- Example guideline failed. Please fix it. Note that the guidelines are only required for the pull request to be merged automatically. However, it is **strongly recommended** to follow them, since otherwise the pull request needs to be manually reviewed and merged by a human. diff --git a/test/reference_comments/comment_pass_false_type_new_version_suggest_onepointzero_false_version_1.0.0_point_to_slack_true.md b/test/reference_comments/comment_pass_false_type_new_version_suggest_onepointzero_false_version_1.0.0_point_to_slack_true.md index 6a620370..ec12ec1c 100644 --- a/test/reference_comments/comment_pass_false_type_new_version_suggest_onepointzero_false_version_1.0.0_point_to_slack_true.md +++ b/test/reference_comments/comment_pass_false_type_new_version_suggest_onepointzero_false_version_1.0.0_point_to_slack_true.md @@ -1,6 +1,6 @@ Your `new version` pull request does not meet the guidelines for auto-merging. Please make sure that you have read the [General registry README](https://github.com/JuliaRegistries/General/blob/master/README.md) and the [AutoMerge guidelines](https://juliaregistries.github.io/RegistryCI.jl/stable/guidelines/). The following guidelines were not met: -- no +- Example guideline failed. Please fix it. Note that the guidelines are only required for the pull request to be merged automatically. However, it is **strongly recommended** to follow them, since otherwise the pull request needs to be manually reviewed and merged by a human. diff --git a/test/reference_comments/comment_pass_false_type_new_version_suggest_onepointzero_true_version_0.1.0_point_to_slack_false.md b/test/reference_comments/comment_pass_false_type_new_version_suggest_onepointzero_true_version_0.1.0_point_to_slack_false.md index 99a7a63b..4c46efc0 100644 --- a/test/reference_comments/comment_pass_false_type_new_version_suggest_onepointzero_true_version_0.1.0_point_to_slack_false.md +++ b/test/reference_comments/comment_pass_false_type_new_version_suggest_onepointzero_true_version_0.1.0_point_to_slack_false.md @@ -1,6 +1,6 @@ Your `new version` pull request does not meet the guidelines for auto-merging. Please make sure that you have read the [General registry README](https://github.com/JuliaRegistries/General/blob/master/README.md) and the [AutoMerge guidelines](https://juliaregistries.github.io/RegistryCI.jl/stable/guidelines/). The following guidelines were not met: -- no +- Example guideline failed. Please fix it. Note that the guidelines are only required for the pull request to be merged automatically. However, it is **strongly recommended** to follow them, since otherwise the pull request needs to be manually reviewed and merged by a human. diff --git a/test/reference_comments/comment_pass_false_type_new_version_suggest_onepointzero_true_version_0.1.0_point_to_slack_true.md b/test/reference_comments/comment_pass_false_type_new_version_suggest_onepointzero_true_version_0.1.0_point_to_slack_true.md index e0dadb2e..c0332119 100644 --- a/test/reference_comments/comment_pass_false_type_new_version_suggest_onepointzero_true_version_0.1.0_point_to_slack_true.md +++ b/test/reference_comments/comment_pass_false_type_new_version_suggest_onepointzero_true_version_0.1.0_point_to_slack_true.md @@ -1,6 +1,6 @@ Your `new version` pull request does not meet the guidelines for auto-merging. Please make sure that you have read the [General registry README](https://github.com/JuliaRegistries/General/blob/master/README.md) and the [AutoMerge guidelines](https://juliaregistries.github.io/RegistryCI.jl/stable/guidelines/). The following guidelines were not met: -- no +- Example guideline failed. Please fix it. Note that the guidelines are only required for the pull request to be merged automatically. However, it is **strongly recommended** to follow them, since otherwise the pull request needs to be manually reviewed and merged by a human. diff --git a/test/reference_comments/comment_pass_false_type_new_version_suggest_onepointzero_true_version_1.0.0_point_to_slack_false.md b/test/reference_comments/comment_pass_false_type_new_version_suggest_onepointzero_true_version_1.0.0_point_to_slack_false.md index 82f6ab67..deb220d4 100644 --- a/test/reference_comments/comment_pass_false_type_new_version_suggest_onepointzero_true_version_1.0.0_point_to_slack_false.md +++ b/test/reference_comments/comment_pass_false_type_new_version_suggest_onepointzero_true_version_1.0.0_point_to_slack_false.md @@ -1,6 +1,6 @@ Your `new version` pull request does not meet the guidelines for auto-merging. Please make sure that you have read the [General registry README](https://github.com/JuliaRegistries/General/blob/master/README.md) and the [AutoMerge guidelines](https://juliaregistries.github.io/RegistryCI.jl/stable/guidelines/). The following guidelines were not met: -- no +- Example guideline failed. Please fix it. Note that the guidelines are only required for the pull request to be merged automatically. However, it is **strongly recommended** to follow them, since otherwise the pull request needs to be manually reviewed and merged by a human. diff --git a/test/reference_comments/comment_pass_false_type_new_version_suggest_onepointzero_true_version_1.0.0_point_to_slack_true.md b/test/reference_comments/comment_pass_false_type_new_version_suggest_onepointzero_true_version_1.0.0_point_to_slack_true.md index 6a620370..ec12ec1c 100644 --- a/test/reference_comments/comment_pass_false_type_new_version_suggest_onepointzero_true_version_1.0.0_point_to_slack_true.md +++ b/test/reference_comments/comment_pass_false_type_new_version_suggest_onepointzero_true_version_1.0.0_point_to_slack_true.md @@ -1,6 +1,6 @@ Your `new version` pull request does not meet the guidelines for auto-merging. Please make sure that you have read the [General registry README](https://github.com/JuliaRegistries/General/blob/master/README.md) and the [AutoMerge guidelines](https://juliaregistries.github.io/RegistryCI.jl/stable/guidelines/). The following guidelines were not met: -- no +- Example guideline failed. Please fix it. Note that the guidelines are only required for the pull request to be merged automatically. However, it is **strongly recommended** to follow them, since otherwise the pull request needs to be manually reviewed and merged by a human. From 1d483aff8f703e436388ea7665b9fa1a9f925fa9 Mon Sep 17 00:00:00 2001 From: Eric Hanson <5846501+ericphanson@users.noreply.github.com> Date: Tue, 30 Jan 2024 22:58:54 +0100 Subject: [PATCH 03/11] fix test on old Julia versions --- test/automerge-unit.jl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/automerge-unit.jl b/test/automerge-unit.jl index 2b6c2e0b..c449f77a 100644 --- a/test/automerge-unit.jl +++ b/test/automerge-unit.jl @@ -73,7 +73,7 @@ function comment_reference_test() # `point_to_slack=false` should yield no references to Slack in the text if !point_to_slack - @test !contains(fail_text, "slack") + @test !occursin("slack", fail_text) end end end From a1922de81c93b54ccdc917470f6d1cee72bf796e Mon Sep 17 00:00:00 2001 From: Eric Hanson <5846501+ericphanson@users.noreply.github.com> Date: Tue, 30 Jan 2024 22:59:21 +0100 Subject: [PATCH 04/11] refactor comment --- src/AutoMerge/util.jl | 179 ++++++++++-------- ...alse_version_0.1.0_point_to_slack_false.md | 21 +- ...false_version_0.1.0_point_to_slack_true.md | 21 +- ...alse_version_1.0.0_point_to_slack_false.md | 21 +- ...false_version_1.0.0_point_to_slack_true.md | 21 +- ...true_version_0.1.0_point_to_slack_false.md | 26 ++- ..._true_version_0.1.0_point_to_slack_true.md | 26 ++- ...true_version_1.0.0_point_to_slack_false.md | 21 +- ..._true_version_1.0.0_point_to_slack_true.md | 21 +- ...alse_version_0.1.0_point_to_slack_false.md | 15 +- ...false_version_0.1.0_point_to_slack_true.md | 17 +- ...alse_version_1.0.0_point_to_slack_false.md | 15 +- ...false_version_1.0.0_point_to_slack_true.md | 17 +- ...true_version_0.1.0_point_to_slack_false.md | 20 +- ..._true_version_0.1.0_point_to_slack_true.md | 22 ++- ...true_version_1.0.0_point_to_slack_false.md | 15 +- ..._true_version_1.0.0_point_to_slack_true.md | 17 +- ...ntzero_false_version_0.1.0_is_jll_false.md | 14 +- ...intzero_false_version_0.1.0_is_jll_true.md | 10 +- ...ntzero_false_version_1.0.0_is_jll_false.md | 14 +- ...intzero_false_version_1.0.0_is_jll_true.md | 10 +- ...intzero_true_version_0.1.0_is_jll_false.md | 19 +- ...ointzero_true_version_0.1.0_is_jll_true.md | 15 +- ...intzero_true_version_1.0.0_is_jll_false.md | 14 +- ...ointzero_true_version_1.0.0_is_jll_true.md | 10 +- ...ntzero_false_version_0.1.0_is_jll_false.md | 12 +- ...intzero_false_version_0.1.0_is_jll_true.md | 12 +- ...ntzero_false_version_1.0.0_is_jll_false.md | 12 +- ...intzero_false_version_1.0.0_is_jll_true.md | 12 +- ...intzero_true_version_0.1.0_is_jll_false.md | 17 +- ...ointzero_true_version_0.1.0_is_jll_true.md | 17 +- ...intzero_true_version_1.0.0_is_jll_false.md | 12 +- ...ointzero_true_version_1.0.0_is_jll_true.md | 12 +- 33 files changed, 481 insertions(+), 226 deletions(-) diff --git a/src/AutoMerge/util.jl b/src/AutoMerge/util.jl index 97cdf9b1..9286843a 100644 --- a/src/AutoMerge/util.jl +++ b/src/AutoMerge/util.jl @@ -84,44 +84,70 @@ function parse_registry_pkg_info(registry_path, pkg, version=nothing) return (; uuid=uuid, repo=repo, subdir=subdir, tree_hash=tree_hash) end -function _comment_disclaimer(; point_to_slack::Bool=false) - result = string( - "\n\n", - "Note that the guidelines are only required for the pull request ", - "to be merged automatically. However, it is **strongly recommended** ", - "to follow them, since otherwise the pull request needs to be ", - "manually reviewed and merged by a human.", - "\n\n", - "After you have fixed the AutoMerge issues, simply retrigger Registrator, ", - "which will automatically update this pull request. ", - "You do not need to change the version number in your `Project.toml` file ", - "(unless of course the AutoMerge issue is that you skipped a version number, ", - "in which case you should change the version number).", +##### +##### AutoMerge comment +##### + +# The AutoMerge comment is divided into numbered sections. +# Besides the "AutoMerge Guidelines which are not met" and "AutoMerge Guidelines have all passed!" +# sections, we keep these minimally customized, and instead simply include or exclude +# whole sections depending on the context. This way, users can understand the message +# without necessarily reading the details of each section each time. +# We hope they will at least read the section titles, and if they aren't +# familiar, hopefully they will also read the sections themselves. + +function _comment_bot_intro(n) + return string("## $n. Introduction\n\n", "Hello, I am an automated registration bot.", + " I help manage the registration process by checking your registration against a set of ","[AutoMerge guidelines](https://juliaregistries.github.io/RegistryCI.jl/stable/guidelines/). ", + "Meeting these guidelines is only required for the pull request to be **merged automatically**. ", + "However, it is **strongly recommended** to follow them, since otherwise ", + "the pull request needs to be manually reviewed and merged by a human.\n\n") +end + +function _new_package_section(n) + return string("## $n. New package registration", "\n\n", + "Since you are registering a new package, please make sure that you have read the ", + "[package naming guidelines](https://julialang.github.io/Pkg.jl/dev/creating-packages/#Package-naming-guidelines-1).\n\n") +end + +function _what_next_if_fail(n; point_to_slack=false) + msg = """ + ## $n. What to do next + + 1. Please try to update your package to conform to these guidelines. The [General registry's README](https://github.com/JuliaRegistries/General/blob/master/README.md) has an FAQ that can help figure out how to do so. You can also leave a comment on this PR (and include `[noblock]`)""" + if point_to_slack + msg = string(msg, " or send a message to the `#pkg-registration` channel in the [public Julia Slack](https://julialang.org/slack/) to ask for help. Include a link to this pull request if you do so!") + end + msg = string(msg, "\n", + "2. After you have fixed the AutoMerge issues, simply retrigger Registrator, the same way you did in the initial registration. This will automatically update this pull request. You do not need to change the version number in your `Project.toml` file (unless of course the AutoMerge issue is that you skipped a version number, in which case you should change the version number).", "\n\n", - "If you do not want to fix the AutoMerge issues, please post a comment ", - "explaining why you would like this pull request to be manually merged.", - ) + "If you do not want to fix the AutoMerge issues, please post a comment explaining why you would like this pull request to be manually merged.") + if point_to_slack - result *= string( - " ", - "Then, send a message to the `#pkg-registration` channel in the ", - "[Julia Slack](https://julialang.org/slack/) to ask for help. ", - "Include a link to this pull request.", - ) + msg = string(msg, " Then, send a message to the `#pkg-registration` channel in the [public Julia Slack](https://julialang.org/slack/) to ask for help.") end - return result + msg = string(msg, "\n\n") + return msg +end + +function _automerge_guidelines_failed_section_title(n) + return "## $n. [AutoMerge Guidelines](https://juliaregistries.github.io/RegistryCI.jl/stable/guidelines/) which are not met\n\n" end -function _comment_noblock() +function _automerge_guidelines_passed_section_title(n) + "## $n. [AutoMerge Guidelines](https://juliaregistries.github.io/RegistryCI.jl/stable/guidelines/) are all met!\n\n" +end + +function _comment_noblock(n) result = string( - "\n\n---\n", + "## $n. To pause or stop registration\n\n", "If you want to prevent this pull request from ", "being auto-merged, simply leave a comment. ", "If you want to post a comment without blocking ", "auto-merging, you must include the text ", "`[noblock]` in your comment. ", "You can edit blocking comments, adding `[noblock]` ", - "to them in order to unblock auto-merging.", + "to them in order to unblock auto-merging.\n\n", ) return result end @@ -129,13 +155,17 @@ end function comment_text_pass( ::NewVersion, suggest_onepointzero::Bool, version::VersionNumber, is_jll::Bool ) + # Need to know this ahead of time to get the section numbers right + suggest_onepointzero &= version < v"1.0.0" result = string( - "Your `new version` pull request met all of the ", + _comment_bot_intro(1), + _automerge_guidelines_passed_section_title(2), + "Your new version registration met all of the ", "guidelines for auto-merging and is scheduled to ", - "be merged in the next round.", - _comment_noblock(), - _onepointzero_suggestion(suggest_onepointzero, version), - "\n", + "be merged in the next round.\n\n", + _onepointzero_suggestion(3, suggest_onepointzero, version), + _comment_noblock(suggest_onepointzero ? 4 : 3), + "", ) return result end @@ -143,42 +173,34 @@ end function comment_text_pass( ::NewPackage, suggest_onepointzero::Bool, version::VersionNumber, is_jll::Bool ) + suggest_onepointzero &= version < v"1.0.0" if is_jll result = string( - "Your `new _jll package` pull request met all of the ", + _comment_bot_intro(1), + _automerge_guidelines_passed_section_title(2), + "Your new `_jll` package registration met all of the ", "guidelines for auto-merging and is scheduled to ", - "be merged in the next round.", - "\n\n", - _comment_noblock(), - _onepointzero_suggestion(suggest_onepointzero, version), - "\n", + "be merged in the next round.\n\n", + _onepointzero_suggestion(3, suggest_onepointzero, version), + _comment_noblock(suggest_onepointzero ? 4 : 3), + "", ) else result = string( - "Your `new package` pull request met all of the ", + _comment_bot_intro(1), + _new_package_section(2), + _automerge_guidelines_passed_section_title(3), + "Your new package registration met all of the ", "guidelines for auto-merging and is scheduled to ", - "be merged when the mandatory waiting period (3 days) has elapsed.", - "\n\n", - "Since you are registering a new package, ", - "please make sure that you have read the ", - "package naming guidelines: ", - "https://pkgdocs.julialang.org/v1/creating-packages/#Package-naming-guidelines", - "\n\n", - _comment_noblock(), - _onepointzero_suggestion(suggest_onepointzero, version), - "\n", + "be merged when the mandatory waiting period (3 days) has elapsed.\n\n", + _onepointzero_suggestion(4, suggest_onepointzero, version), + _comment_noblock(suggest_onepointzero ? 5 : 4), + "", ) end return result end -const _please_read_these_documents = string( - "Please make sure that you have read the ", - "[General registry README](https://github.com/JuliaRegistries/General/blob/master/README.md) ", - "and the ", - "[AutoMerge guidelines](https://juliaregistries.github.io/RegistryCI.jl/stable/guidelines/). ", -) - function comment_text_fail( ::NewPackage, reasons::Vector{String}, @@ -186,23 +208,17 @@ function comment_text_fail( version::VersionNumber; point_to_slack::Bool=false, ) - reasons_formatted = join(string.("- ", reasons), "\n") + suggest_onepointzero &= version < v"1.0.0" + reasons_formatted = string(join(string.("- ", reasons), "\n"), "\n\n") result = string( - "Your `new package` pull request does not meet ", - "the guidelines for auto-merging. ", - _please_read_these_documents, - "The following guidelines were not met:\n\n", + _comment_bot_intro(1), + _new_package_section(2), + _automerge_guidelines_failed_section_title(3), reasons_formatted, - _comment_disclaimer(; point_to_slack=point_to_slack), - "\n\n", - "Since you are registering a new package, ", - "please make sure that you have also read the ", - "package naming guidelines: ", - "https://pkgdocs.julialang.org/v1/creating-packages/#Package-naming-guidelines", - "\n\n", - _comment_noblock(), - _onepointzero_suggestion(suggest_onepointzero, version), - "\n", + _what_next_if_fail(4; point_to_slack=point_to_slack), + _onepointzero_suggestion(5, suggest_onepointzero, version), + _comment_noblock(suggest_onepointzero ? 6 : 5), + "", ) return result end @@ -214,17 +230,16 @@ function comment_text_fail( version::VersionNumber; point_to_slack::Bool=false, ) - reasons_formatted = join(string.("- ", reasons), "\n") + suggest_onepointzero &= version < v"1.0.0" + reasons_formatted = string(join(string.("- ", reasons), "\n"), "\n\n") result = string( - "Your `new version` pull request does not meet ", - "the guidelines for auto-merging. ", - _please_read_these_documents, - "The following guidelines were not met:\n\n", + _comment_bot_intro(1), + _automerge_guidelines_failed_section_title(2), reasons_formatted, - _comment_disclaimer(; point_to_slack=point_to_slack), - _comment_noblock(), - _onepointzero_suggestion(suggest_onepointzero, version), - "\n", + _what_next_if_fail(3; point_to_slack=point_to_slack), + _onepointzero_suggestion(4, suggest_onepointzero, version), + _comment_noblock(suggest_onepointzero ? 5 : 4), + "", ) return result end @@ -258,10 +273,10 @@ function now_utc() return Dates.now(utc) end -function _onepointzero_suggestion(suggest_onepointzero::Bool, version::VersionNumber) +function _onepointzero_suggestion(n, suggest_onepointzero::Bool, version::VersionNumber) if suggest_onepointzero && version < v"1.0.0" result = string( - "\n\n---\n", + "## $n. Declare v1.0?\n\n", "On a separate note, I see that you are registering ", "a release with a version number of the form ", "`v0.X.Y`.\n\n", @@ -272,7 +287,7 @@ function _onepointzero_suggestion(suggest_onepointzero::Bool, version::VersionNu "It's just a recommendation.)\n\n", "If your package does not yet have a stable public ", "API, then of course you are not yet ready to ", - "release version `v1.0.0`.", + "release version `v1.0.0`.\n\n", ) return result else diff --git a/test/reference_comments/comment_pass_false_type_new_package_suggest_onepointzero_false_version_0.1.0_point_to_slack_false.md b/test/reference_comments/comment_pass_false_type_new_package_suggest_onepointzero_false_version_0.1.0_point_to_slack_false.md index 451fd363..da864d4a 100644 --- a/test/reference_comments/comment_pass_false_type_new_package_suggest_onepointzero_false_version_0.1.0_point_to_slack_false.md +++ b/test/reference_comments/comment_pass_false_type_new_package_suggest_onepointzero_false_version_0.1.0_point_to_slack_false.md @@ -1,17 +1,24 @@ -Your `new package` pull request does not meet the guidelines for auto-merging. Please make sure that you have read the [General registry README](https://github.com/JuliaRegistries/General/blob/master/README.md) and the [AutoMerge guidelines](https://juliaregistries.github.io/RegistryCI.jl/stable/guidelines/). The following guidelines were not met: +## 1. Introduction -- Example guideline failed. Please fix it. +Hello, I am an automated registration bot. I help manage the registration process by checking your registration against a set of [AutoMerge guidelines](https://juliaregistries.github.io/RegistryCI.jl/stable/guidelines/). Meeting these guidelines is only required for the pull request to be **merged automatically**. However, it is **strongly recommended** to follow them, since otherwise the pull request needs to be manually reviewed and merged by a human. -Note that the guidelines are only required for the pull request to be merged automatically. However, it is **strongly recommended** to follow them, since otherwise the pull request needs to be manually reviewed and merged by a human. +## 2. New package registration -After you have fixed the AutoMerge issues, simply retrigger Registrator, which will automatically update this pull request. You do not need to change the version number in your `Project.toml` file (unless of course the AutoMerge issue is that you skipped a version number, in which case you should change the version number). +Since you are registering a new package, please make sure that you have read the [package naming guidelines](https://julialang.github.io/Pkg.jl/dev/creating-packages/#Package-naming-guidelines-1). -If you do not want to fix the AutoMerge issues, please post a comment explaining why you would like this pull request to be manually merged. +## 3. [AutoMerge Guidelines](https://juliaregistries.github.io/RegistryCI.jl/stable/guidelines/) which are not met -Since you are registering a new package, please make sure that you have also read the package naming guidelines: https://pkgdocs.julialang.org/v1/creating-packages/#Package-naming-guidelines +- Example guideline failed. Please fix it. +## 4. What to do next +1. Please try to update your package to conform to these guidelines. The [General registry's README](https://github.com/JuliaRegistries/General/blob/master/README.md) has an FAQ that can help figure out how to do so. You can also leave a comment on this PR (and include `[noblock]`) +2. After you have fixed the AutoMerge issues, simply retrigger Registrator, the same way you did in the initial registration. This will automatically update this pull request. You do not need to change the version number in your `Project.toml` file (unless of course the AutoMerge issue is that you skipped a version number, in which case you should change the version number). + +If you do not want to fix the AutoMerge issues, please post a comment explaining why you would like this pull request to be manually merged. + +## 5. To pause or stop registration ---- If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text `[noblock]` in your comment. You can edit blocking comments, adding `[noblock]` to them in order to unblock auto-merging. + \ No newline at end of file diff --git a/test/reference_comments/comment_pass_false_type_new_package_suggest_onepointzero_false_version_0.1.0_point_to_slack_true.md b/test/reference_comments/comment_pass_false_type_new_package_suggest_onepointzero_false_version_0.1.0_point_to_slack_true.md index 7fee4fdb..2dfb8a64 100644 --- a/test/reference_comments/comment_pass_false_type_new_package_suggest_onepointzero_false_version_0.1.0_point_to_slack_true.md +++ b/test/reference_comments/comment_pass_false_type_new_package_suggest_onepointzero_false_version_0.1.0_point_to_slack_true.md @@ -1,17 +1,24 @@ -Your `new package` pull request does not meet the guidelines for auto-merging. Please make sure that you have read the [General registry README](https://github.com/JuliaRegistries/General/blob/master/README.md) and the [AutoMerge guidelines](https://juliaregistries.github.io/RegistryCI.jl/stable/guidelines/). The following guidelines were not met: +## 1. Introduction -- Example guideline failed. Please fix it. +Hello, I am an automated registration bot. I help manage the registration process by checking your registration against a set of [AutoMerge guidelines](https://juliaregistries.github.io/RegistryCI.jl/stable/guidelines/). Meeting these guidelines is only required for the pull request to be **merged automatically**. However, it is **strongly recommended** to follow them, since otherwise the pull request needs to be manually reviewed and merged by a human. + +## 2. New package registration -Note that the guidelines are only required for the pull request to be merged automatically. However, it is **strongly recommended** to follow them, since otherwise the pull request needs to be manually reviewed and merged by a human. +Since you are registering a new package, please make sure that you have read the [package naming guidelines](https://julialang.github.io/Pkg.jl/dev/creating-packages/#Package-naming-guidelines-1). -After you have fixed the AutoMerge issues, simply retrigger Registrator, which will automatically update this pull request. You do not need to change the version number in your `Project.toml` file (unless of course the AutoMerge issue is that you skipped a version number, in which case you should change the version number). +## 3. [AutoMerge Guidelines](https://juliaregistries.github.io/RegistryCI.jl/stable/guidelines/) which are not met -If you do not want to fix the AutoMerge issues, please post a comment explaining why you would like this pull request to be manually merged. Then, send a message to the `#pkg-registration` channel in the [Julia Slack](https://julialang.org/slack/) to ask for help. Include a link to this pull request. +- Example guideline failed. Please fix it. -Since you are registering a new package, please make sure that you have also read the package naming guidelines: https://pkgdocs.julialang.org/v1/creating-packages/#Package-naming-guidelines +## 4. What to do next +1. Please try to update your package to conform to these guidelines. The [General registry's README](https://github.com/JuliaRegistries/General/blob/master/README.md) has an FAQ that can help figure out how to do so. You can also leave a comment on this PR (and include `[noblock]`) or send a message to the `#pkg-registration` channel in the [public Julia Slack](https://julialang.org/slack/) to ask for help. Include a link to this pull request if you do so! +2. After you have fixed the AutoMerge issues, simply retrigger Registrator, the same way you did in the initial registration. This will automatically update this pull request. You do not need to change the version number in your `Project.toml` file (unless of course the AutoMerge issue is that you skipped a version number, in which case you should change the version number). +If you do not want to fix the AutoMerge issues, please post a comment explaining why you would like this pull request to be manually merged. Then, send a message to the `#pkg-registration` channel in the [public Julia Slack](https://julialang.org/slack/) to ask for help. + +## 5. To pause or stop registration ---- If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text `[noblock]` in your comment. You can edit blocking comments, adding `[noblock]` to them in order to unblock auto-merging. + \ No newline at end of file diff --git a/test/reference_comments/comment_pass_false_type_new_package_suggest_onepointzero_false_version_1.0.0_point_to_slack_false.md b/test/reference_comments/comment_pass_false_type_new_package_suggest_onepointzero_false_version_1.0.0_point_to_slack_false.md index 451fd363..da864d4a 100644 --- a/test/reference_comments/comment_pass_false_type_new_package_suggest_onepointzero_false_version_1.0.0_point_to_slack_false.md +++ b/test/reference_comments/comment_pass_false_type_new_package_suggest_onepointzero_false_version_1.0.0_point_to_slack_false.md @@ -1,17 +1,24 @@ -Your `new package` pull request does not meet the guidelines for auto-merging. Please make sure that you have read the [General registry README](https://github.com/JuliaRegistries/General/blob/master/README.md) and the [AutoMerge guidelines](https://juliaregistries.github.io/RegistryCI.jl/stable/guidelines/). The following guidelines were not met: +## 1. Introduction -- Example guideline failed. Please fix it. +Hello, I am an automated registration bot. I help manage the registration process by checking your registration against a set of [AutoMerge guidelines](https://juliaregistries.github.io/RegistryCI.jl/stable/guidelines/). Meeting these guidelines is only required for the pull request to be **merged automatically**. However, it is **strongly recommended** to follow them, since otherwise the pull request needs to be manually reviewed and merged by a human. -Note that the guidelines are only required for the pull request to be merged automatically. However, it is **strongly recommended** to follow them, since otherwise the pull request needs to be manually reviewed and merged by a human. +## 2. New package registration -After you have fixed the AutoMerge issues, simply retrigger Registrator, which will automatically update this pull request. You do not need to change the version number in your `Project.toml` file (unless of course the AutoMerge issue is that you skipped a version number, in which case you should change the version number). +Since you are registering a new package, please make sure that you have read the [package naming guidelines](https://julialang.github.io/Pkg.jl/dev/creating-packages/#Package-naming-guidelines-1). -If you do not want to fix the AutoMerge issues, please post a comment explaining why you would like this pull request to be manually merged. +## 3. [AutoMerge Guidelines](https://juliaregistries.github.io/RegistryCI.jl/stable/guidelines/) which are not met -Since you are registering a new package, please make sure that you have also read the package naming guidelines: https://pkgdocs.julialang.org/v1/creating-packages/#Package-naming-guidelines +- Example guideline failed. Please fix it. +## 4. What to do next +1. Please try to update your package to conform to these guidelines. The [General registry's README](https://github.com/JuliaRegistries/General/blob/master/README.md) has an FAQ that can help figure out how to do so. You can also leave a comment on this PR (and include `[noblock]`) +2. After you have fixed the AutoMerge issues, simply retrigger Registrator, the same way you did in the initial registration. This will automatically update this pull request. You do not need to change the version number in your `Project.toml` file (unless of course the AutoMerge issue is that you skipped a version number, in which case you should change the version number). + +If you do not want to fix the AutoMerge issues, please post a comment explaining why you would like this pull request to be manually merged. + +## 5. To pause or stop registration ---- If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text `[noblock]` in your comment. You can edit blocking comments, adding `[noblock]` to them in order to unblock auto-merging. + \ No newline at end of file diff --git a/test/reference_comments/comment_pass_false_type_new_package_suggest_onepointzero_false_version_1.0.0_point_to_slack_true.md b/test/reference_comments/comment_pass_false_type_new_package_suggest_onepointzero_false_version_1.0.0_point_to_slack_true.md index 7fee4fdb..2dfb8a64 100644 --- a/test/reference_comments/comment_pass_false_type_new_package_suggest_onepointzero_false_version_1.0.0_point_to_slack_true.md +++ b/test/reference_comments/comment_pass_false_type_new_package_suggest_onepointzero_false_version_1.0.0_point_to_slack_true.md @@ -1,17 +1,24 @@ -Your `new package` pull request does not meet the guidelines for auto-merging. Please make sure that you have read the [General registry README](https://github.com/JuliaRegistries/General/blob/master/README.md) and the [AutoMerge guidelines](https://juliaregistries.github.io/RegistryCI.jl/stable/guidelines/). The following guidelines were not met: +## 1. Introduction -- Example guideline failed. Please fix it. +Hello, I am an automated registration bot. I help manage the registration process by checking your registration against a set of [AutoMerge guidelines](https://juliaregistries.github.io/RegistryCI.jl/stable/guidelines/). Meeting these guidelines is only required for the pull request to be **merged automatically**. However, it is **strongly recommended** to follow them, since otherwise the pull request needs to be manually reviewed and merged by a human. + +## 2. New package registration -Note that the guidelines are only required for the pull request to be merged automatically. However, it is **strongly recommended** to follow them, since otherwise the pull request needs to be manually reviewed and merged by a human. +Since you are registering a new package, please make sure that you have read the [package naming guidelines](https://julialang.github.io/Pkg.jl/dev/creating-packages/#Package-naming-guidelines-1). -After you have fixed the AutoMerge issues, simply retrigger Registrator, which will automatically update this pull request. You do not need to change the version number in your `Project.toml` file (unless of course the AutoMerge issue is that you skipped a version number, in which case you should change the version number). +## 3. [AutoMerge Guidelines](https://juliaregistries.github.io/RegistryCI.jl/stable/guidelines/) which are not met -If you do not want to fix the AutoMerge issues, please post a comment explaining why you would like this pull request to be manually merged. Then, send a message to the `#pkg-registration` channel in the [Julia Slack](https://julialang.org/slack/) to ask for help. Include a link to this pull request. +- Example guideline failed. Please fix it. -Since you are registering a new package, please make sure that you have also read the package naming guidelines: https://pkgdocs.julialang.org/v1/creating-packages/#Package-naming-guidelines +## 4. What to do next +1. Please try to update your package to conform to these guidelines. The [General registry's README](https://github.com/JuliaRegistries/General/blob/master/README.md) has an FAQ that can help figure out how to do so. You can also leave a comment on this PR (and include `[noblock]`) or send a message to the `#pkg-registration` channel in the [public Julia Slack](https://julialang.org/slack/) to ask for help. Include a link to this pull request if you do so! +2. After you have fixed the AutoMerge issues, simply retrigger Registrator, the same way you did in the initial registration. This will automatically update this pull request. You do not need to change the version number in your `Project.toml` file (unless of course the AutoMerge issue is that you skipped a version number, in which case you should change the version number). +If you do not want to fix the AutoMerge issues, please post a comment explaining why you would like this pull request to be manually merged. Then, send a message to the `#pkg-registration` channel in the [public Julia Slack](https://julialang.org/slack/) to ask for help. + +## 5. To pause or stop registration ---- If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text `[noblock]` in your comment. You can edit blocking comments, adding `[noblock]` to them in order to unblock auto-merging. + \ No newline at end of file diff --git a/test/reference_comments/comment_pass_false_type_new_package_suggest_onepointzero_true_version_0.1.0_point_to_slack_false.md b/test/reference_comments/comment_pass_false_type_new_package_suggest_onepointzero_true_version_0.1.0_point_to_slack_false.md index 84d0e07b..b3a73156 100644 --- a/test/reference_comments/comment_pass_false_type_new_package_suggest_onepointzero_true_version_0.1.0_point_to_slack_false.md +++ b/test/reference_comments/comment_pass_false_type_new_package_suggest_onepointzero_true_version_0.1.0_point_to_slack_false.md @@ -1,24 +1,32 @@ -Your `new package` pull request does not meet the guidelines for auto-merging. Please make sure that you have read the [General registry README](https://github.com/JuliaRegistries/General/blob/master/README.md) and the [AutoMerge guidelines](https://juliaregistries.github.io/RegistryCI.jl/stable/guidelines/). The following guidelines were not met: +## 1. Introduction -- Example guideline failed. Please fix it. +Hello, I am an automated registration bot. I help manage the registration process by checking your registration against a set of [AutoMerge guidelines](https://juliaregistries.github.io/RegistryCI.jl/stable/guidelines/). Meeting these guidelines is only required for the pull request to be **merged automatically**. However, it is **strongly recommended** to follow them, since otherwise the pull request needs to be manually reviewed and merged by a human. -Note that the guidelines are only required for the pull request to be merged automatically. However, it is **strongly recommended** to follow them, since otherwise the pull request needs to be manually reviewed and merged by a human. +## 2. New package registration -After you have fixed the AutoMerge issues, simply retrigger Registrator, which will automatically update this pull request. You do not need to change the version number in your `Project.toml` file (unless of course the AutoMerge issue is that you skipped a version number, in which case you should change the version number). +Since you are registering a new package, please make sure that you have read the [package naming guidelines](https://julialang.github.io/Pkg.jl/dev/creating-packages/#Package-naming-guidelines-1). -If you do not want to fix the AutoMerge issues, please post a comment explaining why you would like this pull request to be manually merged. +## 3. [AutoMerge Guidelines](https://juliaregistries.github.io/RegistryCI.jl/stable/guidelines/) which are not met -Since you are registering a new package, please make sure that you have also read the package naming guidelines: https://pkgdocs.julialang.org/v1/creating-packages/#Package-naming-guidelines +- Example guideline failed. Please fix it. +## 4. What to do next +1. Please try to update your package to conform to these guidelines. The [General registry's README](https://github.com/JuliaRegistries/General/blob/master/README.md) has an FAQ that can help figure out how to do so. You can also leave a comment on this PR (and include `[noblock]`) +2. After you have fixed the AutoMerge issues, simply retrigger Registrator, the same way you did in the initial registration. This will automatically update this pull request. You do not need to change the version number in your `Project.toml` file (unless of course the AutoMerge issue is that you skipped a version number, in which case you should change the version number). ---- -If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text `[noblock]` in your comment. You can edit blocking comments, adding `[noblock]` to them in order to unblock auto-merging. +If you do not want to fix the AutoMerge issues, please post a comment explaining why you would like this pull request to be manually merged. + +## 5. Declare v1.0? ---- On a separate note, I see that you are registering a release with a version number of the form `v0.X.Y`. Does your package have a stable public API? If so, then it's time for you to register version `v1.0.0` of your package. (This is not a requirement. It's just a recommendation.) If your package does not yet have a stable public API, then of course you are not yet ready to release version `v1.0.0`. + +## 6. To pause or stop registration + +If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text `[noblock]` in your comment. You can edit blocking comments, adding `[noblock]` to them in order to unblock auto-merging. + \ No newline at end of file diff --git a/test/reference_comments/comment_pass_false_type_new_package_suggest_onepointzero_true_version_0.1.0_point_to_slack_true.md b/test/reference_comments/comment_pass_false_type_new_package_suggest_onepointzero_true_version_0.1.0_point_to_slack_true.md index 5fa5a742..f64de56c 100644 --- a/test/reference_comments/comment_pass_false_type_new_package_suggest_onepointzero_true_version_0.1.0_point_to_slack_true.md +++ b/test/reference_comments/comment_pass_false_type_new_package_suggest_onepointzero_true_version_0.1.0_point_to_slack_true.md @@ -1,24 +1,32 @@ -Your `new package` pull request does not meet the guidelines for auto-merging. Please make sure that you have read the [General registry README](https://github.com/JuliaRegistries/General/blob/master/README.md) and the [AutoMerge guidelines](https://juliaregistries.github.io/RegistryCI.jl/stable/guidelines/). The following guidelines were not met: +## 1. Introduction -- Example guideline failed. Please fix it. +Hello, I am an automated registration bot. I help manage the registration process by checking your registration against a set of [AutoMerge guidelines](https://juliaregistries.github.io/RegistryCI.jl/stable/guidelines/). Meeting these guidelines is only required for the pull request to be **merged automatically**. However, it is **strongly recommended** to follow them, since otherwise the pull request needs to be manually reviewed and merged by a human. + +## 2. New package registration -Note that the guidelines are only required for the pull request to be merged automatically. However, it is **strongly recommended** to follow them, since otherwise the pull request needs to be manually reviewed and merged by a human. +Since you are registering a new package, please make sure that you have read the [package naming guidelines](https://julialang.github.io/Pkg.jl/dev/creating-packages/#Package-naming-guidelines-1). -After you have fixed the AutoMerge issues, simply retrigger Registrator, which will automatically update this pull request. You do not need to change the version number in your `Project.toml` file (unless of course the AutoMerge issue is that you skipped a version number, in which case you should change the version number). +## 3. [AutoMerge Guidelines](https://juliaregistries.github.io/RegistryCI.jl/stable/guidelines/) which are not met -If you do not want to fix the AutoMerge issues, please post a comment explaining why you would like this pull request to be manually merged. Then, send a message to the `#pkg-registration` channel in the [Julia Slack](https://julialang.org/slack/) to ask for help. Include a link to this pull request. +- Example guideline failed. Please fix it. -Since you are registering a new package, please make sure that you have also read the package naming guidelines: https://pkgdocs.julialang.org/v1/creating-packages/#Package-naming-guidelines +## 4. What to do next +1. Please try to update your package to conform to these guidelines. The [General registry's README](https://github.com/JuliaRegistries/General/blob/master/README.md) has an FAQ that can help figure out how to do so. You can also leave a comment on this PR (and include `[noblock]`) or send a message to the `#pkg-registration` channel in the [public Julia Slack](https://julialang.org/slack/) to ask for help. Include a link to this pull request if you do so! +2. After you have fixed the AutoMerge issues, simply retrigger Registrator, the same way you did in the initial registration. This will automatically update this pull request. You do not need to change the version number in your `Project.toml` file (unless of course the AutoMerge issue is that you skipped a version number, in which case you should change the version number). +If you do not want to fix the AutoMerge issues, please post a comment explaining why you would like this pull request to be manually merged. Then, send a message to the `#pkg-registration` channel in the [public Julia Slack](https://julialang.org/slack/) to ask for help. ---- -If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text `[noblock]` in your comment. You can edit blocking comments, adding `[noblock]` to them in order to unblock auto-merging. +## 5. Declare v1.0? ---- On a separate note, I see that you are registering a release with a version number of the form `v0.X.Y`. Does your package have a stable public API? If so, then it's time for you to register version `v1.0.0` of your package. (This is not a requirement. It's just a recommendation.) If your package does not yet have a stable public API, then of course you are not yet ready to release version `v1.0.0`. + +## 6. To pause or stop registration + +If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text `[noblock]` in your comment. You can edit blocking comments, adding `[noblock]` to them in order to unblock auto-merging. + \ No newline at end of file diff --git a/test/reference_comments/comment_pass_false_type_new_package_suggest_onepointzero_true_version_1.0.0_point_to_slack_false.md b/test/reference_comments/comment_pass_false_type_new_package_suggest_onepointzero_true_version_1.0.0_point_to_slack_false.md index 451fd363..da864d4a 100644 --- a/test/reference_comments/comment_pass_false_type_new_package_suggest_onepointzero_true_version_1.0.0_point_to_slack_false.md +++ b/test/reference_comments/comment_pass_false_type_new_package_suggest_onepointzero_true_version_1.0.0_point_to_slack_false.md @@ -1,17 +1,24 @@ -Your `new package` pull request does not meet the guidelines for auto-merging. Please make sure that you have read the [General registry README](https://github.com/JuliaRegistries/General/blob/master/README.md) and the [AutoMerge guidelines](https://juliaregistries.github.io/RegistryCI.jl/stable/guidelines/). The following guidelines were not met: +## 1. Introduction -- Example guideline failed. Please fix it. +Hello, I am an automated registration bot. I help manage the registration process by checking your registration against a set of [AutoMerge guidelines](https://juliaregistries.github.io/RegistryCI.jl/stable/guidelines/). Meeting these guidelines is only required for the pull request to be **merged automatically**. However, it is **strongly recommended** to follow them, since otherwise the pull request needs to be manually reviewed and merged by a human. -Note that the guidelines are only required for the pull request to be merged automatically. However, it is **strongly recommended** to follow them, since otherwise the pull request needs to be manually reviewed and merged by a human. +## 2. New package registration -After you have fixed the AutoMerge issues, simply retrigger Registrator, which will automatically update this pull request. You do not need to change the version number in your `Project.toml` file (unless of course the AutoMerge issue is that you skipped a version number, in which case you should change the version number). +Since you are registering a new package, please make sure that you have read the [package naming guidelines](https://julialang.github.io/Pkg.jl/dev/creating-packages/#Package-naming-guidelines-1). -If you do not want to fix the AutoMerge issues, please post a comment explaining why you would like this pull request to be manually merged. +## 3. [AutoMerge Guidelines](https://juliaregistries.github.io/RegistryCI.jl/stable/guidelines/) which are not met -Since you are registering a new package, please make sure that you have also read the package naming guidelines: https://pkgdocs.julialang.org/v1/creating-packages/#Package-naming-guidelines +- Example guideline failed. Please fix it. +## 4. What to do next +1. Please try to update your package to conform to these guidelines. The [General registry's README](https://github.com/JuliaRegistries/General/blob/master/README.md) has an FAQ that can help figure out how to do so. You can also leave a comment on this PR (and include `[noblock]`) +2. After you have fixed the AutoMerge issues, simply retrigger Registrator, the same way you did in the initial registration. This will automatically update this pull request. You do not need to change the version number in your `Project.toml` file (unless of course the AutoMerge issue is that you skipped a version number, in which case you should change the version number). + +If you do not want to fix the AutoMerge issues, please post a comment explaining why you would like this pull request to be manually merged. + +## 5. To pause or stop registration ---- If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text `[noblock]` in your comment. You can edit blocking comments, adding `[noblock]` to them in order to unblock auto-merging. + \ No newline at end of file diff --git a/test/reference_comments/comment_pass_false_type_new_package_suggest_onepointzero_true_version_1.0.0_point_to_slack_true.md b/test/reference_comments/comment_pass_false_type_new_package_suggest_onepointzero_true_version_1.0.0_point_to_slack_true.md index 7fee4fdb..2dfb8a64 100644 --- a/test/reference_comments/comment_pass_false_type_new_package_suggest_onepointzero_true_version_1.0.0_point_to_slack_true.md +++ b/test/reference_comments/comment_pass_false_type_new_package_suggest_onepointzero_true_version_1.0.0_point_to_slack_true.md @@ -1,17 +1,24 @@ -Your `new package` pull request does not meet the guidelines for auto-merging. Please make sure that you have read the [General registry README](https://github.com/JuliaRegistries/General/blob/master/README.md) and the [AutoMerge guidelines](https://juliaregistries.github.io/RegistryCI.jl/stable/guidelines/). The following guidelines were not met: +## 1. Introduction -- Example guideline failed. Please fix it. +Hello, I am an automated registration bot. I help manage the registration process by checking your registration against a set of [AutoMerge guidelines](https://juliaregistries.github.io/RegistryCI.jl/stable/guidelines/). Meeting these guidelines is only required for the pull request to be **merged automatically**. However, it is **strongly recommended** to follow them, since otherwise the pull request needs to be manually reviewed and merged by a human. + +## 2. New package registration -Note that the guidelines are only required for the pull request to be merged automatically. However, it is **strongly recommended** to follow them, since otherwise the pull request needs to be manually reviewed and merged by a human. +Since you are registering a new package, please make sure that you have read the [package naming guidelines](https://julialang.github.io/Pkg.jl/dev/creating-packages/#Package-naming-guidelines-1). -After you have fixed the AutoMerge issues, simply retrigger Registrator, which will automatically update this pull request. You do not need to change the version number in your `Project.toml` file (unless of course the AutoMerge issue is that you skipped a version number, in which case you should change the version number). +## 3. [AutoMerge Guidelines](https://juliaregistries.github.io/RegistryCI.jl/stable/guidelines/) which are not met -If you do not want to fix the AutoMerge issues, please post a comment explaining why you would like this pull request to be manually merged. Then, send a message to the `#pkg-registration` channel in the [Julia Slack](https://julialang.org/slack/) to ask for help. Include a link to this pull request. +- Example guideline failed. Please fix it. -Since you are registering a new package, please make sure that you have also read the package naming guidelines: https://pkgdocs.julialang.org/v1/creating-packages/#Package-naming-guidelines +## 4. What to do next +1. Please try to update your package to conform to these guidelines. The [General registry's README](https://github.com/JuliaRegistries/General/blob/master/README.md) has an FAQ that can help figure out how to do so. You can also leave a comment on this PR (and include `[noblock]`) or send a message to the `#pkg-registration` channel in the [public Julia Slack](https://julialang.org/slack/) to ask for help. Include a link to this pull request if you do so! +2. After you have fixed the AutoMerge issues, simply retrigger Registrator, the same way you did in the initial registration. This will automatically update this pull request. You do not need to change the version number in your `Project.toml` file (unless of course the AutoMerge issue is that you skipped a version number, in which case you should change the version number). +If you do not want to fix the AutoMerge issues, please post a comment explaining why you would like this pull request to be manually merged. Then, send a message to the `#pkg-registration` channel in the [public Julia Slack](https://julialang.org/slack/) to ask for help. + +## 5. To pause or stop registration ---- If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text `[noblock]` in your comment. You can edit blocking comments, adding `[noblock]` to them in order to unblock auto-merging. + \ No newline at end of file diff --git a/test/reference_comments/comment_pass_false_type_new_version_suggest_onepointzero_false_version_0.1.0_point_to_slack_false.md b/test/reference_comments/comment_pass_false_type_new_version_suggest_onepointzero_false_version_0.1.0_point_to_slack_false.md index deb220d4..e66f2acd 100644 --- a/test/reference_comments/comment_pass_false_type_new_version_suggest_onepointzero_false_version_0.1.0_point_to_slack_false.md +++ b/test/reference_comments/comment_pass_false_type_new_version_suggest_onepointzero_false_version_0.1.0_point_to_slack_false.md @@ -1,13 +1,20 @@ -Your `new version` pull request does not meet the guidelines for auto-merging. Please make sure that you have read the [General registry README](https://github.com/JuliaRegistries/General/blob/master/README.md) and the [AutoMerge guidelines](https://juliaregistries.github.io/RegistryCI.jl/stable/guidelines/). The following guidelines were not met: +## 1. Introduction + +Hello, I am an automated registration bot. I help manage the registration process by checking your registration against a set of [AutoMerge guidelines](https://juliaregistries.github.io/RegistryCI.jl/stable/guidelines/). Meeting these guidelines is only required for the pull request to be **merged automatically**. However, it is **strongly recommended** to follow them, since otherwise the pull request needs to be manually reviewed and merged by a human. + +## 2. [AutoMerge Guidelines](https://juliaregistries.github.io/RegistryCI.jl/stable/guidelines/) which are not met - Example guideline failed. Please fix it. -Note that the guidelines are only required for the pull request to be merged automatically. However, it is **strongly recommended** to follow them, since otherwise the pull request needs to be manually reviewed and merged by a human. +## 3. What to do next -After you have fixed the AutoMerge issues, simply retrigger Registrator, which will automatically update this pull request. You do not need to change the version number in your `Project.toml` file (unless of course the AutoMerge issue is that you skipped a version number, in which case you should change the version number). +1. Please try to update your package to conform to these guidelines. The [General registry's README](https://github.com/JuliaRegistries/General/blob/master/README.md) has an FAQ that can help figure out how to do so. You can also leave a comment on this PR (and include `[noblock]`) +2. After you have fixed the AutoMerge issues, simply retrigger Registrator, the same way you did in the initial registration. This will automatically update this pull request. You do not need to change the version number in your `Project.toml` file (unless of course the AutoMerge issue is that you skipped a version number, in which case you should change the version number). If you do not want to fix the AutoMerge issues, please post a comment explaining why you would like this pull request to be manually merged. ---- +## 4. To pause or stop registration + If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text `[noblock]` in your comment. You can edit blocking comments, adding `[noblock]` to them in order to unblock auto-merging. + \ No newline at end of file diff --git a/test/reference_comments/comment_pass_false_type_new_version_suggest_onepointzero_false_version_0.1.0_point_to_slack_true.md b/test/reference_comments/comment_pass_false_type_new_version_suggest_onepointzero_false_version_0.1.0_point_to_slack_true.md index ec12ec1c..f8555ccd 100644 --- a/test/reference_comments/comment_pass_false_type_new_version_suggest_onepointzero_false_version_0.1.0_point_to_slack_true.md +++ b/test/reference_comments/comment_pass_false_type_new_version_suggest_onepointzero_false_version_0.1.0_point_to_slack_true.md @@ -1,13 +1,20 @@ -Your `new version` pull request does not meet the guidelines for auto-merging. Please make sure that you have read the [General registry README](https://github.com/JuliaRegistries/General/blob/master/README.md) and the [AutoMerge guidelines](https://juliaregistries.github.io/RegistryCI.jl/stable/guidelines/). The following guidelines were not met: +## 1. Introduction + +Hello, I am an automated registration bot. I help manage the registration process by checking your registration against a set of [AutoMerge guidelines](https://juliaregistries.github.io/RegistryCI.jl/stable/guidelines/). Meeting these guidelines is only required for the pull request to be **merged automatically**. However, it is **strongly recommended** to follow them, since otherwise the pull request needs to be manually reviewed and merged by a human. + +## 2. [AutoMerge Guidelines](https://juliaregistries.github.io/RegistryCI.jl/stable/guidelines/) which are not met - Example guideline failed. Please fix it. -Note that the guidelines are only required for the pull request to be merged automatically. However, it is **strongly recommended** to follow them, since otherwise the pull request needs to be manually reviewed and merged by a human. +## 3. What to do next -After you have fixed the AutoMerge issues, simply retrigger Registrator, which will automatically update this pull request. You do not need to change the version number in your `Project.toml` file (unless of course the AutoMerge issue is that you skipped a version number, in which case you should change the version number). +1. Please try to update your package to conform to these guidelines. The [General registry's README](https://github.com/JuliaRegistries/General/blob/master/README.md) has an FAQ that can help figure out how to do so. You can also leave a comment on this PR (and include `[noblock]`) or send a message to the `#pkg-registration` channel in the [public Julia Slack](https://julialang.org/slack/) to ask for help. Include a link to this pull request if you do so! +2. After you have fixed the AutoMerge issues, simply retrigger Registrator, the same way you did in the initial registration. This will automatically update this pull request. You do not need to change the version number in your `Project.toml` file (unless of course the AutoMerge issue is that you skipped a version number, in which case you should change the version number). -If you do not want to fix the AutoMerge issues, please post a comment explaining why you would like this pull request to be manually merged. Then, send a message to the `#pkg-registration` channel in the [Julia Slack](https://julialang.org/slack/) to ask for help. Include a link to this pull request. +If you do not want to fix the AutoMerge issues, please post a comment explaining why you would like this pull request to be manually merged. Then, send a message to the `#pkg-registration` channel in the [public Julia Slack](https://julialang.org/slack/) to ask for help. + +## 4. To pause or stop registration ---- If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text `[noblock]` in your comment. You can edit blocking comments, adding `[noblock]` to them in order to unblock auto-merging. + \ No newline at end of file diff --git a/test/reference_comments/comment_pass_false_type_new_version_suggest_onepointzero_false_version_1.0.0_point_to_slack_false.md b/test/reference_comments/comment_pass_false_type_new_version_suggest_onepointzero_false_version_1.0.0_point_to_slack_false.md index deb220d4..e66f2acd 100644 --- a/test/reference_comments/comment_pass_false_type_new_version_suggest_onepointzero_false_version_1.0.0_point_to_slack_false.md +++ b/test/reference_comments/comment_pass_false_type_new_version_suggest_onepointzero_false_version_1.0.0_point_to_slack_false.md @@ -1,13 +1,20 @@ -Your `new version` pull request does not meet the guidelines for auto-merging. Please make sure that you have read the [General registry README](https://github.com/JuliaRegistries/General/blob/master/README.md) and the [AutoMerge guidelines](https://juliaregistries.github.io/RegistryCI.jl/stable/guidelines/). The following guidelines were not met: +## 1. Introduction + +Hello, I am an automated registration bot. I help manage the registration process by checking your registration against a set of [AutoMerge guidelines](https://juliaregistries.github.io/RegistryCI.jl/stable/guidelines/). Meeting these guidelines is only required for the pull request to be **merged automatically**. However, it is **strongly recommended** to follow them, since otherwise the pull request needs to be manually reviewed and merged by a human. + +## 2. [AutoMerge Guidelines](https://juliaregistries.github.io/RegistryCI.jl/stable/guidelines/) which are not met - Example guideline failed. Please fix it. -Note that the guidelines are only required for the pull request to be merged automatically. However, it is **strongly recommended** to follow them, since otherwise the pull request needs to be manually reviewed and merged by a human. +## 3. What to do next -After you have fixed the AutoMerge issues, simply retrigger Registrator, which will automatically update this pull request. You do not need to change the version number in your `Project.toml` file (unless of course the AutoMerge issue is that you skipped a version number, in which case you should change the version number). +1. Please try to update your package to conform to these guidelines. The [General registry's README](https://github.com/JuliaRegistries/General/blob/master/README.md) has an FAQ that can help figure out how to do so. You can also leave a comment on this PR (and include `[noblock]`) +2. After you have fixed the AutoMerge issues, simply retrigger Registrator, the same way you did in the initial registration. This will automatically update this pull request. You do not need to change the version number in your `Project.toml` file (unless of course the AutoMerge issue is that you skipped a version number, in which case you should change the version number). If you do not want to fix the AutoMerge issues, please post a comment explaining why you would like this pull request to be manually merged. ---- +## 4. To pause or stop registration + If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text `[noblock]` in your comment. You can edit blocking comments, adding `[noblock]` to them in order to unblock auto-merging. + \ No newline at end of file diff --git a/test/reference_comments/comment_pass_false_type_new_version_suggest_onepointzero_false_version_1.0.0_point_to_slack_true.md b/test/reference_comments/comment_pass_false_type_new_version_suggest_onepointzero_false_version_1.0.0_point_to_slack_true.md index ec12ec1c..f8555ccd 100644 --- a/test/reference_comments/comment_pass_false_type_new_version_suggest_onepointzero_false_version_1.0.0_point_to_slack_true.md +++ b/test/reference_comments/comment_pass_false_type_new_version_suggest_onepointzero_false_version_1.0.0_point_to_slack_true.md @@ -1,13 +1,20 @@ -Your `new version` pull request does not meet the guidelines for auto-merging. Please make sure that you have read the [General registry README](https://github.com/JuliaRegistries/General/blob/master/README.md) and the [AutoMerge guidelines](https://juliaregistries.github.io/RegistryCI.jl/stable/guidelines/). The following guidelines were not met: +## 1. Introduction + +Hello, I am an automated registration bot. I help manage the registration process by checking your registration against a set of [AutoMerge guidelines](https://juliaregistries.github.io/RegistryCI.jl/stable/guidelines/). Meeting these guidelines is only required for the pull request to be **merged automatically**. However, it is **strongly recommended** to follow them, since otherwise the pull request needs to be manually reviewed and merged by a human. + +## 2. [AutoMerge Guidelines](https://juliaregistries.github.io/RegistryCI.jl/stable/guidelines/) which are not met - Example guideline failed. Please fix it. -Note that the guidelines are only required for the pull request to be merged automatically. However, it is **strongly recommended** to follow them, since otherwise the pull request needs to be manually reviewed and merged by a human. +## 3. What to do next -After you have fixed the AutoMerge issues, simply retrigger Registrator, which will automatically update this pull request. You do not need to change the version number in your `Project.toml` file (unless of course the AutoMerge issue is that you skipped a version number, in which case you should change the version number). +1. Please try to update your package to conform to these guidelines. The [General registry's README](https://github.com/JuliaRegistries/General/blob/master/README.md) has an FAQ that can help figure out how to do so. You can also leave a comment on this PR (and include `[noblock]`) or send a message to the `#pkg-registration` channel in the [public Julia Slack](https://julialang.org/slack/) to ask for help. Include a link to this pull request if you do so! +2. After you have fixed the AutoMerge issues, simply retrigger Registrator, the same way you did in the initial registration. This will automatically update this pull request. You do not need to change the version number in your `Project.toml` file (unless of course the AutoMerge issue is that you skipped a version number, in which case you should change the version number). -If you do not want to fix the AutoMerge issues, please post a comment explaining why you would like this pull request to be manually merged. Then, send a message to the `#pkg-registration` channel in the [Julia Slack](https://julialang.org/slack/) to ask for help. Include a link to this pull request. +If you do not want to fix the AutoMerge issues, please post a comment explaining why you would like this pull request to be manually merged. Then, send a message to the `#pkg-registration` channel in the [public Julia Slack](https://julialang.org/slack/) to ask for help. + +## 4. To pause or stop registration ---- If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text `[noblock]` in your comment. You can edit blocking comments, adding `[noblock]` to them in order to unblock auto-merging. + \ No newline at end of file diff --git a/test/reference_comments/comment_pass_false_type_new_version_suggest_onepointzero_true_version_0.1.0_point_to_slack_false.md b/test/reference_comments/comment_pass_false_type_new_version_suggest_onepointzero_true_version_0.1.0_point_to_slack_false.md index 4c46efc0..91262b2f 100644 --- a/test/reference_comments/comment_pass_false_type_new_version_suggest_onepointzero_true_version_0.1.0_point_to_slack_false.md +++ b/test/reference_comments/comment_pass_false_type_new_version_suggest_onepointzero_true_version_0.1.0_point_to_slack_false.md @@ -1,20 +1,28 @@ -Your `new version` pull request does not meet the guidelines for auto-merging. Please make sure that you have read the [General registry README](https://github.com/JuliaRegistries/General/blob/master/README.md) and the [AutoMerge guidelines](https://juliaregistries.github.io/RegistryCI.jl/stable/guidelines/). The following guidelines were not met: +## 1. Introduction + +Hello, I am an automated registration bot. I help manage the registration process by checking your registration against a set of [AutoMerge guidelines](https://juliaregistries.github.io/RegistryCI.jl/stable/guidelines/). Meeting these guidelines is only required for the pull request to be **merged automatically**. However, it is **strongly recommended** to follow them, since otherwise the pull request needs to be manually reviewed and merged by a human. + +## 2. [AutoMerge Guidelines](https://juliaregistries.github.io/RegistryCI.jl/stable/guidelines/) which are not met - Example guideline failed. Please fix it. -Note that the guidelines are only required for the pull request to be merged automatically. However, it is **strongly recommended** to follow them, since otherwise the pull request needs to be manually reviewed and merged by a human. +## 3. What to do next -After you have fixed the AutoMerge issues, simply retrigger Registrator, which will automatically update this pull request. You do not need to change the version number in your `Project.toml` file (unless of course the AutoMerge issue is that you skipped a version number, in which case you should change the version number). +1. Please try to update your package to conform to these guidelines. The [General registry's README](https://github.com/JuliaRegistries/General/blob/master/README.md) has an FAQ that can help figure out how to do so. You can also leave a comment on this PR (and include `[noblock]`) +2. After you have fixed the AutoMerge issues, simply retrigger Registrator, the same way you did in the initial registration. This will automatically update this pull request. You do not need to change the version number in your `Project.toml` file (unless of course the AutoMerge issue is that you skipped a version number, in which case you should change the version number). If you do not want to fix the AutoMerge issues, please post a comment explaining why you would like this pull request to be manually merged. ---- -If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text `[noblock]` in your comment. You can edit blocking comments, adding `[noblock]` to them in order to unblock auto-merging. +## 4. Declare v1.0? ---- On a separate note, I see that you are registering a release with a version number of the form `v0.X.Y`. Does your package have a stable public API? If so, then it's time for you to register version `v1.0.0` of your package. (This is not a requirement. It's just a recommendation.) If your package does not yet have a stable public API, then of course you are not yet ready to release version `v1.0.0`. + +## 5. To pause or stop registration + +If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text `[noblock]` in your comment. You can edit blocking comments, adding `[noblock]` to them in order to unblock auto-merging. + \ No newline at end of file diff --git a/test/reference_comments/comment_pass_false_type_new_version_suggest_onepointzero_true_version_0.1.0_point_to_slack_true.md b/test/reference_comments/comment_pass_false_type_new_version_suggest_onepointzero_true_version_0.1.0_point_to_slack_true.md index c0332119..00e338b4 100644 --- a/test/reference_comments/comment_pass_false_type_new_version_suggest_onepointzero_true_version_0.1.0_point_to_slack_true.md +++ b/test/reference_comments/comment_pass_false_type_new_version_suggest_onepointzero_true_version_0.1.0_point_to_slack_true.md @@ -1,20 +1,28 @@ -Your `new version` pull request does not meet the guidelines for auto-merging. Please make sure that you have read the [General registry README](https://github.com/JuliaRegistries/General/blob/master/README.md) and the [AutoMerge guidelines](https://juliaregistries.github.io/RegistryCI.jl/stable/guidelines/). The following guidelines were not met: +## 1. Introduction + +Hello, I am an automated registration bot. I help manage the registration process by checking your registration against a set of [AutoMerge guidelines](https://juliaregistries.github.io/RegistryCI.jl/stable/guidelines/). Meeting these guidelines is only required for the pull request to be **merged automatically**. However, it is **strongly recommended** to follow them, since otherwise the pull request needs to be manually reviewed and merged by a human. + +## 2. [AutoMerge Guidelines](https://juliaregistries.github.io/RegistryCI.jl/stable/guidelines/) which are not met - Example guideline failed. Please fix it. -Note that the guidelines are only required for the pull request to be merged automatically. However, it is **strongly recommended** to follow them, since otherwise the pull request needs to be manually reviewed and merged by a human. +## 3. What to do next -After you have fixed the AutoMerge issues, simply retrigger Registrator, which will automatically update this pull request. You do not need to change the version number in your `Project.toml` file (unless of course the AutoMerge issue is that you skipped a version number, in which case you should change the version number). +1. Please try to update your package to conform to these guidelines. The [General registry's README](https://github.com/JuliaRegistries/General/blob/master/README.md) has an FAQ that can help figure out how to do so. You can also leave a comment on this PR (and include `[noblock]`) or send a message to the `#pkg-registration` channel in the [public Julia Slack](https://julialang.org/slack/) to ask for help. Include a link to this pull request if you do so! +2. After you have fixed the AutoMerge issues, simply retrigger Registrator, the same way you did in the initial registration. This will automatically update this pull request. You do not need to change the version number in your `Project.toml` file (unless of course the AutoMerge issue is that you skipped a version number, in which case you should change the version number). -If you do not want to fix the AutoMerge issues, please post a comment explaining why you would like this pull request to be manually merged. Then, send a message to the `#pkg-registration` channel in the [Julia Slack](https://julialang.org/slack/) to ask for help. Include a link to this pull request. +If you do not want to fix the AutoMerge issues, please post a comment explaining why you would like this pull request to be manually merged. Then, send a message to the `#pkg-registration` channel in the [public Julia Slack](https://julialang.org/slack/) to ask for help. ---- -If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text `[noblock]` in your comment. You can edit blocking comments, adding `[noblock]` to them in order to unblock auto-merging. +## 4. Declare v1.0? ---- On a separate note, I see that you are registering a release with a version number of the form `v0.X.Y`. Does your package have a stable public API? If so, then it's time for you to register version `v1.0.0` of your package. (This is not a requirement. It's just a recommendation.) If your package does not yet have a stable public API, then of course you are not yet ready to release version `v1.0.0`. + +## 5. To pause or stop registration + +If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text `[noblock]` in your comment. You can edit blocking comments, adding `[noblock]` to them in order to unblock auto-merging. + \ No newline at end of file diff --git a/test/reference_comments/comment_pass_false_type_new_version_suggest_onepointzero_true_version_1.0.0_point_to_slack_false.md b/test/reference_comments/comment_pass_false_type_new_version_suggest_onepointzero_true_version_1.0.0_point_to_slack_false.md index deb220d4..e66f2acd 100644 --- a/test/reference_comments/comment_pass_false_type_new_version_suggest_onepointzero_true_version_1.0.0_point_to_slack_false.md +++ b/test/reference_comments/comment_pass_false_type_new_version_suggest_onepointzero_true_version_1.0.0_point_to_slack_false.md @@ -1,13 +1,20 @@ -Your `new version` pull request does not meet the guidelines for auto-merging. Please make sure that you have read the [General registry README](https://github.com/JuliaRegistries/General/blob/master/README.md) and the [AutoMerge guidelines](https://juliaregistries.github.io/RegistryCI.jl/stable/guidelines/). The following guidelines were not met: +## 1. Introduction + +Hello, I am an automated registration bot. I help manage the registration process by checking your registration against a set of [AutoMerge guidelines](https://juliaregistries.github.io/RegistryCI.jl/stable/guidelines/). Meeting these guidelines is only required for the pull request to be **merged automatically**. However, it is **strongly recommended** to follow them, since otherwise the pull request needs to be manually reviewed and merged by a human. + +## 2. [AutoMerge Guidelines](https://juliaregistries.github.io/RegistryCI.jl/stable/guidelines/) which are not met - Example guideline failed. Please fix it. -Note that the guidelines are only required for the pull request to be merged automatically. However, it is **strongly recommended** to follow them, since otherwise the pull request needs to be manually reviewed and merged by a human. +## 3. What to do next -After you have fixed the AutoMerge issues, simply retrigger Registrator, which will automatically update this pull request. You do not need to change the version number in your `Project.toml` file (unless of course the AutoMerge issue is that you skipped a version number, in which case you should change the version number). +1. Please try to update your package to conform to these guidelines. The [General registry's README](https://github.com/JuliaRegistries/General/blob/master/README.md) has an FAQ that can help figure out how to do so. You can also leave a comment on this PR (and include `[noblock]`) +2. After you have fixed the AutoMerge issues, simply retrigger Registrator, the same way you did in the initial registration. This will automatically update this pull request. You do not need to change the version number in your `Project.toml` file (unless of course the AutoMerge issue is that you skipped a version number, in which case you should change the version number). If you do not want to fix the AutoMerge issues, please post a comment explaining why you would like this pull request to be manually merged. ---- +## 4. To pause or stop registration + If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text `[noblock]` in your comment. You can edit blocking comments, adding `[noblock]` to them in order to unblock auto-merging. + \ No newline at end of file diff --git a/test/reference_comments/comment_pass_false_type_new_version_suggest_onepointzero_true_version_1.0.0_point_to_slack_true.md b/test/reference_comments/comment_pass_false_type_new_version_suggest_onepointzero_true_version_1.0.0_point_to_slack_true.md index ec12ec1c..f8555ccd 100644 --- a/test/reference_comments/comment_pass_false_type_new_version_suggest_onepointzero_true_version_1.0.0_point_to_slack_true.md +++ b/test/reference_comments/comment_pass_false_type_new_version_suggest_onepointzero_true_version_1.0.0_point_to_slack_true.md @@ -1,13 +1,20 @@ -Your `new version` pull request does not meet the guidelines for auto-merging. Please make sure that you have read the [General registry README](https://github.com/JuliaRegistries/General/blob/master/README.md) and the [AutoMerge guidelines](https://juliaregistries.github.io/RegistryCI.jl/stable/guidelines/). The following guidelines were not met: +## 1. Introduction + +Hello, I am an automated registration bot. I help manage the registration process by checking your registration against a set of [AutoMerge guidelines](https://juliaregistries.github.io/RegistryCI.jl/stable/guidelines/). Meeting these guidelines is only required for the pull request to be **merged automatically**. However, it is **strongly recommended** to follow them, since otherwise the pull request needs to be manually reviewed and merged by a human. + +## 2. [AutoMerge Guidelines](https://juliaregistries.github.io/RegistryCI.jl/stable/guidelines/) which are not met - Example guideline failed. Please fix it. -Note that the guidelines are only required for the pull request to be merged automatically. However, it is **strongly recommended** to follow them, since otherwise the pull request needs to be manually reviewed and merged by a human. +## 3. What to do next -After you have fixed the AutoMerge issues, simply retrigger Registrator, which will automatically update this pull request. You do not need to change the version number in your `Project.toml` file (unless of course the AutoMerge issue is that you skipped a version number, in which case you should change the version number). +1. Please try to update your package to conform to these guidelines. The [General registry's README](https://github.com/JuliaRegistries/General/blob/master/README.md) has an FAQ that can help figure out how to do so. You can also leave a comment on this PR (and include `[noblock]`) or send a message to the `#pkg-registration` channel in the [public Julia Slack](https://julialang.org/slack/) to ask for help. Include a link to this pull request if you do so! +2. After you have fixed the AutoMerge issues, simply retrigger Registrator, the same way you did in the initial registration. This will automatically update this pull request. You do not need to change the version number in your `Project.toml` file (unless of course the AutoMerge issue is that you skipped a version number, in which case you should change the version number). -If you do not want to fix the AutoMerge issues, please post a comment explaining why you would like this pull request to be manually merged. Then, send a message to the `#pkg-registration` channel in the [Julia Slack](https://julialang.org/slack/) to ask for help. Include a link to this pull request. +If you do not want to fix the AutoMerge issues, please post a comment explaining why you would like this pull request to be manually merged. Then, send a message to the `#pkg-registration` channel in the [public Julia Slack](https://julialang.org/slack/) to ask for help. + +## 4. To pause or stop registration ---- If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text `[noblock]` in your comment. You can edit blocking comments, adding `[noblock]` to them in order to unblock auto-merging. + \ No newline at end of file diff --git a/test/reference_comments/comment_pass_true_type_new_package_suggest_onepointzero_false_version_0.1.0_is_jll_false.md b/test/reference_comments/comment_pass_true_type_new_package_suggest_onepointzero_false_version_0.1.0_is_jll_false.md index 2db19b5a..de881647 100644 --- a/test/reference_comments/comment_pass_true_type_new_package_suggest_onepointzero_false_version_0.1.0_is_jll_false.md +++ b/test/reference_comments/comment_pass_true_type_new_package_suggest_onepointzero_false_version_0.1.0_is_jll_false.md @@ -1,9 +1,17 @@ -Your `new package` pull request met all of the guidelines for auto-merging and is scheduled to be merged when the mandatory waiting period (3 days) has elapsed. +## 1. Introduction -Since you are registering a new package, please make sure that you have read the package naming guidelines: https://pkgdocs.julialang.org/v1/creating-packages/#Package-naming-guidelines +Hello, I am an automated registration bot. I help manage the registration process by checking your registration against a set of [AutoMerge guidelines](https://juliaregistries.github.io/RegistryCI.jl/stable/guidelines/). Meeting these guidelines is only required for the pull request to be **merged automatically**. However, it is **strongly recommended** to follow them, since otherwise the pull request needs to be manually reviewed and merged by a human. +## 2. New package registration +Since you are registering a new package, please make sure that you have read the [package naming guidelines](https://julialang.github.io/Pkg.jl/dev/creating-packages/#Package-naming-guidelines-1). + +## 3. [AutoMerge Guidelines](https://juliaregistries.github.io/RegistryCI.jl/stable/guidelines/) are all met! + +Your new package registration met all of the guidelines for auto-merging and is scheduled to be merged when the mandatory waiting period (3 days) has elapsed. + +## 4. To pause or stop registration ---- If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text `[noblock]` in your comment. You can edit blocking comments, adding `[noblock]` to them in order to unblock auto-merging. + \ No newline at end of file diff --git a/test/reference_comments/comment_pass_true_type_new_package_suggest_onepointzero_false_version_0.1.0_is_jll_true.md b/test/reference_comments/comment_pass_true_type_new_package_suggest_onepointzero_false_version_0.1.0_is_jll_true.md index a92361e0..64a30117 100644 --- a/test/reference_comments/comment_pass_true_type_new_package_suggest_onepointzero_false_version_0.1.0_is_jll_true.md +++ b/test/reference_comments/comment_pass_true_type_new_package_suggest_onepointzero_false_version_0.1.0_is_jll_true.md @@ -1,7 +1,13 @@ -Your `new _jll package` pull request met all of the guidelines for auto-merging and is scheduled to be merged in the next round. +## 1. Introduction +Hello, I am an automated registration bot. I help manage the registration process by checking your registration against a set of [AutoMerge guidelines](https://juliaregistries.github.io/RegistryCI.jl/stable/guidelines/). Meeting these guidelines is only required for the pull request to be **merged automatically**. However, it is **strongly recommended** to follow them, since otherwise the pull request needs to be manually reviewed and merged by a human. +## 2. [AutoMerge Guidelines](https://juliaregistries.github.io/RegistryCI.jl/stable/guidelines/) are all met! + +Your new `_jll` package registration met all of the guidelines for auto-merging and is scheduled to be merged in the next round. + +## 3. To pause or stop registration ---- If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text `[noblock]` in your comment. You can edit blocking comments, adding `[noblock]` to them in order to unblock auto-merging. + \ No newline at end of file diff --git a/test/reference_comments/comment_pass_true_type_new_package_suggest_onepointzero_false_version_1.0.0_is_jll_false.md b/test/reference_comments/comment_pass_true_type_new_package_suggest_onepointzero_false_version_1.0.0_is_jll_false.md index 2db19b5a..de881647 100644 --- a/test/reference_comments/comment_pass_true_type_new_package_suggest_onepointzero_false_version_1.0.0_is_jll_false.md +++ b/test/reference_comments/comment_pass_true_type_new_package_suggest_onepointzero_false_version_1.0.0_is_jll_false.md @@ -1,9 +1,17 @@ -Your `new package` pull request met all of the guidelines for auto-merging and is scheduled to be merged when the mandatory waiting period (3 days) has elapsed. +## 1. Introduction -Since you are registering a new package, please make sure that you have read the package naming guidelines: https://pkgdocs.julialang.org/v1/creating-packages/#Package-naming-guidelines +Hello, I am an automated registration bot. I help manage the registration process by checking your registration against a set of [AutoMerge guidelines](https://juliaregistries.github.io/RegistryCI.jl/stable/guidelines/). Meeting these guidelines is only required for the pull request to be **merged automatically**. However, it is **strongly recommended** to follow them, since otherwise the pull request needs to be manually reviewed and merged by a human. +## 2. New package registration +Since you are registering a new package, please make sure that you have read the [package naming guidelines](https://julialang.github.io/Pkg.jl/dev/creating-packages/#Package-naming-guidelines-1). + +## 3. [AutoMerge Guidelines](https://juliaregistries.github.io/RegistryCI.jl/stable/guidelines/) are all met! + +Your new package registration met all of the guidelines for auto-merging and is scheduled to be merged when the mandatory waiting period (3 days) has elapsed. + +## 4. To pause or stop registration ---- If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text `[noblock]` in your comment. You can edit blocking comments, adding `[noblock]` to them in order to unblock auto-merging. + \ No newline at end of file diff --git a/test/reference_comments/comment_pass_true_type_new_package_suggest_onepointzero_false_version_1.0.0_is_jll_true.md b/test/reference_comments/comment_pass_true_type_new_package_suggest_onepointzero_false_version_1.0.0_is_jll_true.md index a92361e0..64a30117 100644 --- a/test/reference_comments/comment_pass_true_type_new_package_suggest_onepointzero_false_version_1.0.0_is_jll_true.md +++ b/test/reference_comments/comment_pass_true_type_new_package_suggest_onepointzero_false_version_1.0.0_is_jll_true.md @@ -1,7 +1,13 @@ -Your `new _jll package` pull request met all of the guidelines for auto-merging and is scheduled to be merged in the next round. +## 1. Introduction +Hello, I am an automated registration bot. I help manage the registration process by checking your registration against a set of [AutoMerge guidelines](https://juliaregistries.github.io/RegistryCI.jl/stable/guidelines/). Meeting these guidelines is only required for the pull request to be **merged automatically**. However, it is **strongly recommended** to follow them, since otherwise the pull request needs to be manually reviewed and merged by a human. +## 2. [AutoMerge Guidelines](https://juliaregistries.github.io/RegistryCI.jl/stable/guidelines/) are all met! + +Your new `_jll` package registration met all of the guidelines for auto-merging and is scheduled to be merged in the next round. + +## 3. To pause or stop registration ---- If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text `[noblock]` in your comment. You can edit blocking comments, adding `[noblock]` to them in order to unblock auto-merging. + \ No newline at end of file diff --git a/test/reference_comments/comment_pass_true_type_new_package_suggest_onepointzero_true_version_0.1.0_is_jll_false.md b/test/reference_comments/comment_pass_true_type_new_package_suggest_onepointzero_true_version_0.1.0_is_jll_false.md index 3d4e1993..afc45052 100644 --- a/test/reference_comments/comment_pass_true_type_new_package_suggest_onepointzero_true_version_0.1.0_is_jll_false.md +++ b/test/reference_comments/comment_pass_true_type_new_package_suggest_onepointzero_true_version_0.1.0_is_jll_false.md @@ -1,16 +1,25 @@ -Your `new package` pull request met all of the guidelines for auto-merging and is scheduled to be merged when the mandatory waiting period (3 days) has elapsed. +## 1. Introduction -Since you are registering a new package, please make sure that you have read the package naming guidelines: https://pkgdocs.julialang.org/v1/creating-packages/#Package-naming-guidelines +Hello, I am an automated registration bot. I help manage the registration process by checking your registration against a set of [AutoMerge guidelines](https://juliaregistries.github.io/RegistryCI.jl/stable/guidelines/). Meeting these guidelines is only required for the pull request to be **merged automatically**. However, it is **strongly recommended** to follow them, since otherwise the pull request needs to be manually reviewed and merged by a human. +## 2. New package registration +Since you are registering a new package, please make sure that you have read the [package naming guidelines](https://julialang.github.io/Pkg.jl/dev/creating-packages/#Package-naming-guidelines-1). ---- -If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text `[noblock]` in your comment. You can edit blocking comments, adding `[noblock]` to them in order to unblock auto-merging. +## 3. [AutoMerge Guidelines](https://juliaregistries.github.io/RegistryCI.jl/stable/guidelines/) are all met! + +Your new package registration met all of the guidelines for auto-merging and is scheduled to be merged when the mandatory waiting period (3 days) has elapsed. + +## 4. Declare v1.0? ---- On a separate note, I see that you are registering a release with a version number of the form `v0.X.Y`. Does your package have a stable public API? If so, then it's time for you to register version `v1.0.0` of your package. (This is not a requirement. It's just a recommendation.) If your package does not yet have a stable public API, then of course you are not yet ready to release version `v1.0.0`. + +## 5. To pause or stop registration + +If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text `[noblock]` in your comment. You can edit blocking comments, adding `[noblock]` to them in order to unblock auto-merging. + \ No newline at end of file diff --git a/test/reference_comments/comment_pass_true_type_new_package_suggest_onepointzero_true_version_0.1.0_is_jll_true.md b/test/reference_comments/comment_pass_true_type_new_package_suggest_onepointzero_true_version_0.1.0_is_jll_true.md index 8d857815..53a29ac7 100644 --- a/test/reference_comments/comment_pass_true_type_new_package_suggest_onepointzero_true_version_0.1.0_is_jll_true.md +++ b/test/reference_comments/comment_pass_true_type_new_package_suggest_onepointzero_true_version_0.1.0_is_jll_true.md @@ -1,14 +1,21 @@ -Your `new _jll package` pull request met all of the guidelines for auto-merging and is scheduled to be merged in the next round. +## 1. Introduction +Hello, I am an automated registration bot. I help manage the registration process by checking your registration against a set of [AutoMerge guidelines](https://juliaregistries.github.io/RegistryCI.jl/stable/guidelines/). Meeting these guidelines is only required for the pull request to be **merged automatically**. However, it is **strongly recommended** to follow them, since otherwise the pull request needs to be manually reviewed and merged by a human. +## 2. [AutoMerge Guidelines](https://juliaregistries.github.io/RegistryCI.jl/stable/guidelines/) are all met! ---- -If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text `[noblock]` in your comment. You can edit blocking comments, adding `[noblock]` to them in order to unblock auto-merging. +Your new `_jll` package registration met all of the guidelines for auto-merging and is scheduled to be merged in the next round. + +## 3. Declare v1.0? ---- On a separate note, I see that you are registering a release with a version number of the form `v0.X.Y`. Does your package have a stable public API? If so, then it's time for you to register version `v1.0.0` of your package. (This is not a requirement. It's just a recommendation.) If your package does not yet have a stable public API, then of course you are not yet ready to release version `v1.0.0`. + +## 4. To pause or stop registration + +If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text `[noblock]` in your comment. You can edit blocking comments, adding `[noblock]` to them in order to unblock auto-merging. + \ No newline at end of file diff --git a/test/reference_comments/comment_pass_true_type_new_package_suggest_onepointzero_true_version_1.0.0_is_jll_false.md b/test/reference_comments/comment_pass_true_type_new_package_suggest_onepointzero_true_version_1.0.0_is_jll_false.md index 2db19b5a..de881647 100644 --- a/test/reference_comments/comment_pass_true_type_new_package_suggest_onepointzero_true_version_1.0.0_is_jll_false.md +++ b/test/reference_comments/comment_pass_true_type_new_package_suggest_onepointzero_true_version_1.0.0_is_jll_false.md @@ -1,9 +1,17 @@ -Your `new package` pull request met all of the guidelines for auto-merging and is scheduled to be merged when the mandatory waiting period (3 days) has elapsed. +## 1. Introduction -Since you are registering a new package, please make sure that you have read the package naming guidelines: https://pkgdocs.julialang.org/v1/creating-packages/#Package-naming-guidelines +Hello, I am an automated registration bot. I help manage the registration process by checking your registration against a set of [AutoMerge guidelines](https://juliaregistries.github.io/RegistryCI.jl/stable/guidelines/). Meeting these guidelines is only required for the pull request to be **merged automatically**. However, it is **strongly recommended** to follow them, since otherwise the pull request needs to be manually reviewed and merged by a human. +## 2. New package registration +Since you are registering a new package, please make sure that you have read the [package naming guidelines](https://julialang.github.io/Pkg.jl/dev/creating-packages/#Package-naming-guidelines-1). + +## 3. [AutoMerge Guidelines](https://juliaregistries.github.io/RegistryCI.jl/stable/guidelines/) are all met! + +Your new package registration met all of the guidelines for auto-merging and is scheduled to be merged when the mandatory waiting period (3 days) has elapsed. + +## 4. To pause or stop registration ---- If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text `[noblock]` in your comment. You can edit blocking comments, adding `[noblock]` to them in order to unblock auto-merging. + \ No newline at end of file diff --git a/test/reference_comments/comment_pass_true_type_new_package_suggest_onepointzero_true_version_1.0.0_is_jll_true.md b/test/reference_comments/comment_pass_true_type_new_package_suggest_onepointzero_true_version_1.0.0_is_jll_true.md index a92361e0..64a30117 100644 --- a/test/reference_comments/comment_pass_true_type_new_package_suggest_onepointzero_true_version_1.0.0_is_jll_true.md +++ b/test/reference_comments/comment_pass_true_type_new_package_suggest_onepointzero_true_version_1.0.0_is_jll_true.md @@ -1,7 +1,13 @@ -Your `new _jll package` pull request met all of the guidelines for auto-merging and is scheduled to be merged in the next round. +## 1. Introduction +Hello, I am an automated registration bot. I help manage the registration process by checking your registration against a set of [AutoMerge guidelines](https://juliaregistries.github.io/RegistryCI.jl/stable/guidelines/). Meeting these guidelines is only required for the pull request to be **merged automatically**. However, it is **strongly recommended** to follow them, since otherwise the pull request needs to be manually reviewed and merged by a human. +## 2. [AutoMerge Guidelines](https://juliaregistries.github.io/RegistryCI.jl/stable/guidelines/) are all met! + +Your new `_jll` package registration met all of the guidelines for auto-merging and is scheduled to be merged in the next round. + +## 3. To pause or stop registration ---- If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text `[noblock]` in your comment. You can edit blocking comments, adding `[noblock]` to them in order to unblock auto-merging. + \ No newline at end of file diff --git a/test/reference_comments/comment_pass_true_type_new_version_suggest_onepointzero_false_version_0.1.0_is_jll_false.md b/test/reference_comments/comment_pass_true_type_new_version_suggest_onepointzero_false_version_0.1.0_is_jll_false.md index 4347fb6d..897d6ae1 100644 --- a/test/reference_comments/comment_pass_true_type_new_version_suggest_onepointzero_false_version_0.1.0_is_jll_false.md +++ b/test/reference_comments/comment_pass_true_type_new_version_suggest_onepointzero_false_version_0.1.0_is_jll_false.md @@ -1,5 +1,13 @@ -Your `new version` pull request met all of the guidelines for auto-merging and is scheduled to be merged in the next round. +## 1. Introduction + +Hello, I am an automated registration bot. I help manage the registration process by checking your registration against a set of [AutoMerge guidelines](https://juliaregistries.github.io/RegistryCI.jl/stable/guidelines/). Meeting these guidelines is only required for the pull request to be **merged automatically**. However, it is **strongly recommended** to follow them, since otherwise the pull request needs to be manually reviewed and merged by a human. + +## 2. [AutoMerge Guidelines](https://juliaregistries.github.io/RegistryCI.jl/stable/guidelines/) are all met! + +Your new version registration met all of the guidelines for auto-merging and is scheduled to be merged in the next round. + +## 3. To pause or stop registration ---- If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text `[noblock]` in your comment. You can edit blocking comments, adding `[noblock]` to them in order to unblock auto-merging. + \ No newline at end of file diff --git a/test/reference_comments/comment_pass_true_type_new_version_suggest_onepointzero_false_version_0.1.0_is_jll_true.md b/test/reference_comments/comment_pass_true_type_new_version_suggest_onepointzero_false_version_0.1.0_is_jll_true.md index 4347fb6d..897d6ae1 100644 --- a/test/reference_comments/comment_pass_true_type_new_version_suggest_onepointzero_false_version_0.1.0_is_jll_true.md +++ b/test/reference_comments/comment_pass_true_type_new_version_suggest_onepointzero_false_version_0.1.0_is_jll_true.md @@ -1,5 +1,13 @@ -Your `new version` pull request met all of the guidelines for auto-merging and is scheduled to be merged in the next round. +## 1. Introduction + +Hello, I am an automated registration bot. I help manage the registration process by checking your registration against a set of [AutoMerge guidelines](https://juliaregistries.github.io/RegistryCI.jl/stable/guidelines/). Meeting these guidelines is only required for the pull request to be **merged automatically**. However, it is **strongly recommended** to follow them, since otherwise the pull request needs to be manually reviewed and merged by a human. + +## 2. [AutoMerge Guidelines](https://juliaregistries.github.io/RegistryCI.jl/stable/guidelines/) are all met! + +Your new version registration met all of the guidelines for auto-merging and is scheduled to be merged in the next round. + +## 3. To pause or stop registration ---- If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text `[noblock]` in your comment. You can edit blocking comments, adding `[noblock]` to them in order to unblock auto-merging. + \ No newline at end of file diff --git a/test/reference_comments/comment_pass_true_type_new_version_suggest_onepointzero_false_version_1.0.0_is_jll_false.md b/test/reference_comments/comment_pass_true_type_new_version_suggest_onepointzero_false_version_1.0.0_is_jll_false.md index 4347fb6d..897d6ae1 100644 --- a/test/reference_comments/comment_pass_true_type_new_version_suggest_onepointzero_false_version_1.0.0_is_jll_false.md +++ b/test/reference_comments/comment_pass_true_type_new_version_suggest_onepointzero_false_version_1.0.0_is_jll_false.md @@ -1,5 +1,13 @@ -Your `new version` pull request met all of the guidelines for auto-merging and is scheduled to be merged in the next round. +## 1. Introduction + +Hello, I am an automated registration bot. I help manage the registration process by checking your registration against a set of [AutoMerge guidelines](https://juliaregistries.github.io/RegistryCI.jl/stable/guidelines/). Meeting these guidelines is only required for the pull request to be **merged automatically**. However, it is **strongly recommended** to follow them, since otherwise the pull request needs to be manually reviewed and merged by a human. + +## 2. [AutoMerge Guidelines](https://juliaregistries.github.io/RegistryCI.jl/stable/guidelines/) are all met! + +Your new version registration met all of the guidelines for auto-merging and is scheduled to be merged in the next round. + +## 3. To pause or stop registration ---- If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text `[noblock]` in your comment. You can edit blocking comments, adding `[noblock]` to them in order to unblock auto-merging. + \ No newline at end of file diff --git a/test/reference_comments/comment_pass_true_type_new_version_suggest_onepointzero_false_version_1.0.0_is_jll_true.md b/test/reference_comments/comment_pass_true_type_new_version_suggest_onepointzero_false_version_1.0.0_is_jll_true.md index 4347fb6d..897d6ae1 100644 --- a/test/reference_comments/comment_pass_true_type_new_version_suggest_onepointzero_false_version_1.0.0_is_jll_true.md +++ b/test/reference_comments/comment_pass_true_type_new_version_suggest_onepointzero_false_version_1.0.0_is_jll_true.md @@ -1,5 +1,13 @@ -Your `new version` pull request met all of the guidelines for auto-merging and is scheduled to be merged in the next round. +## 1. Introduction + +Hello, I am an automated registration bot. I help manage the registration process by checking your registration against a set of [AutoMerge guidelines](https://juliaregistries.github.io/RegistryCI.jl/stable/guidelines/). Meeting these guidelines is only required for the pull request to be **merged automatically**. However, it is **strongly recommended** to follow them, since otherwise the pull request needs to be manually reviewed and merged by a human. + +## 2. [AutoMerge Guidelines](https://juliaregistries.github.io/RegistryCI.jl/stable/guidelines/) are all met! + +Your new version registration met all of the guidelines for auto-merging and is scheduled to be merged in the next round. + +## 3. To pause or stop registration ---- If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text `[noblock]` in your comment. You can edit blocking comments, adding `[noblock]` to them in order to unblock auto-merging. + \ No newline at end of file diff --git a/test/reference_comments/comment_pass_true_type_new_version_suggest_onepointzero_true_version_0.1.0_is_jll_false.md b/test/reference_comments/comment_pass_true_type_new_version_suggest_onepointzero_true_version_0.1.0_is_jll_false.md index db26cf44..ec269cff 100644 --- a/test/reference_comments/comment_pass_true_type_new_version_suggest_onepointzero_true_version_0.1.0_is_jll_false.md +++ b/test/reference_comments/comment_pass_true_type_new_version_suggest_onepointzero_true_version_0.1.0_is_jll_false.md @@ -1,12 +1,21 @@ -Your `new version` pull request met all of the guidelines for auto-merging and is scheduled to be merged in the next round. +## 1. Introduction ---- -If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text `[noblock]` in your comment. You can edit blocking comments, adding `[noblock]` to them in order to unblock auto-merging. +Hello, I am an automated registration bot. I help manage the registration process by checking your registration against a set of [AutoMerge guidelines](https://juliaregistries.github.io/RegistryCI.jl/stable/guidelines/). Meeting these guidelines is only required for the pull request to be **merged automatically**. However, it is **strongly recommended** to follow them, since otherwise the pull request needs to be manually reviewed and merged by a human. + +## 2. [AutoMerge Guidelines](https://juliaregistries.github.io/RegistryCI.jl/stable/guidelines/) are all met! + +Your new version registration met all of the guidelines for auto-merging and is scheduled to be merged in the next round. + +## 3. Declare v1.0? ---- On a separate note, I see that you are registering a release with a version number of the form `v0.X.Y`. Does your package have a stable public API? If so, then it's time for you to register version `v1.0.0` of your package. (This is not a requirement. It's just a recommendation.) If your package does not yet have a stable public API, then of course you are not yet ready to release version `v1.0.0`. + +## 4. To pause or stop registration + +If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text `[noblock]` in your comment. You can edit blocking comments, adding `[noblock]` to them in order to unblock auto-merging. + \ No newline at end of file diff --git a/test/reference_comments/comment_pass_true_type_new_version_suggest_onepointzero_true_version_0.1.0_is_jll_true.md b/test/reference_comments/comment_pass_true_type_new_version_suggest_onepointzero_true_version_0.1.0_is_jll_true.md index db26cf44..ec269cff 100644 --- a/test/reference_comments/comment_pass_true_type_new_version_suggest_onepointzero_true_version_0.1.0_is_jll_true.md +++ b/test/reference_comments/comment_pass_true_type_new_version_suggest_onepointzero_true_version_0.1.0_is_jll_true.md @@ -1,12 +1,21 @@ -Your `new version` pull request met all of the guidelines for auto-merging and is scheduled to be merged in the next round. +## 1. Introduction ---- -If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text `[noblock]` in your comment. You can edit blocking comments, adding `[noblock]` to them in order to unblock auto-merging. +Hello, I am an automated registration bot. I help manage the registration process by checking your registration against a set of [AutoMerge guidelines](https://juliaregistries.github.io/RegistryCI.jl/stable/guidelines/). Meeting these guidelines is only required for the pull request to be **merged automatically**. However, it is **strongly recommended** to follow them, since otherwise the pull request needs to be manually reviewed and merged by a human. + +## 2. [AutoMerge Guidelines](https://juliaregistries.github.io/RegistryCI.jl/stable/guidelines/) are all met! + +Your new version registration met all of the guidelines for auto-merging and is scheduled to be merged in the next round. + +## 3. Declare v1.0? ---- On a separate note, I see that you are registering a release with a version number of the form `v0.X.Y`. Does your package have a stable public API? If so, then it's time for you to register version `v1.0.0` of your package. (This is not a requirement. It's just a recommendation.) If your package does not yet have a stable public API, then of course you are not yet ready to release version `v1.0.0`. + +## 4. To pause or stop registration + +If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text `[noblock]` in your comment. You can edit blocking comments, adding `[noblock]` to them in order to unblock auto-merging. + \ No newline at end of file diff --git a/test/reference_comments/comment_pass_true_type_new_version_suggest_onepointzero_true_version_1.0.0_is_jll_false.md b/test/reference_comments/comment_pass_true_type_new_version_suggest_onepointzero_true_version_1.0.0_is_jll_false.md index 4347fb6d..897d6ae1 100644 --- a/test/reference_comments/comment_pass_true_type_new_version_suggest_onepointzero_true_version_1.0.0_is_jll_false.md +++ b/test/reference_comments/comment_pass_true_type_new_version_suggest_onepointzero_true_version_1.0.0_is_jll_false.md @@ -1,5 +1,13 @@ -Your `new version` pull request met all of the guidelines for auto-merging and is scheduled to be merged in the next round. +## 1. Introduction + +Hello, I am an automated registration bot. I help manage the registration process by checking your registration against a set of [AutoMerge guidelines](https://juliaregistries.github.io/RegistryCI.jl/stable/guidelines/). Meeting these guidelines is only required for the pull request to be **merged automatically**. However, it is **strongly recommended** to follow them, since otherwise the pull request needs to be manually reviewed and merged by a human. + +## 2. [AutoMerge Guidelines](https://juliaregistries.github.io/RegistryCI.jl/stable/guidelines/) are all met! + +Your new version registration met all of the guidelines for auto-merging and is scheduled to be merged in the next round. + +## 3. To pause or stop registration ---- If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text `[noblock]` in your comment. You can edit blocking comments, adding `[noblock]` to them in order to unblock auto-merging. + \ No newline at end of file diff --git a/test/reference_comments/comment_pass_true_type_new_version_suggest_onepointzero_true_version_1.0.0_is_jll_true.md b/test/reference_comments/comment_pass_true_type_new_version_suggest_onepointzero_true_version_1.0.0_is_jll_true.md index 4347fb6d..897d6ae1 100644 --- a/test/reference_comments/comment_pass_true_type_new_version_suggest_onepointzero_true_version_1.0.0_is_jll_true.md +++ b/test/reference_comments/comment_pass_true_type_new_version_suggest_onepointzero_true_version_1.0.0_is_jll_true.md @@ -1,5 +1,13 @@ -Your `new version` pull request met all of the guidelines for auto-merging and is scheduled to be merged in the next round. +## 1. Introduction + +Hello, I am an automated registration bot. I help manage the registration process by checking your registration against a set of [AutoMerge guidelines](https://juliaregistries.github.io/RegistryCI.jl/stable/guidelines/). Meeting these guidelines is only required for the pull request to be **merged automatically**. However, it is **strongly recommended** to follow them, since otherwise the pull request needs to be manually reviewed and merged by a human. + +## 2. [AutoMerge Guidelines](https://juliaregistries.github.io/RegistryCI.jl/stable/guidelines/) are all met! + +Your new version registration met all of the guidelines for auto-merging and is scheduled to be merged in the next round. + +## 3. To pause or stop registration ---- If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text `[noblock]` in your comment. You can edit blocking comments, adding `[noblock]` to them in order to unblock auto-merging. + \ No newline at end of file From 0ffe65f14fcfb6998e4b3ed85e04eab860990fa5 Mon Sep 17 00:00:00 2001 From: Eric Hanson <5846501+ericphanson@users.noreply.github.com> Date: Wed, 31 Jan 2024 00:51:27 +0100 Subject: [PATCH 05/11] thread `new_package_waiting_period` through to AutoMerge comment --- src/AutoMerge/public.jl | 3 ++- src/AutoMerge/pull_requests.jl | 8 +++++--- src/AutoMerge/util.jl | 6 +++--- test/automerge-unit.jl | 6 +++++- 4 files changed, 15 insertions(+), 8 deletions(-) diff --git a/src/AutoMerge/public.jl b/src/AutoMerge/public.jl index 2bf9fab3..807caa8a 100644 --- a/src/AutoMerge/public.jl +++ b/src/AutoMerge/public.jl @@ -71,7 +71,7 @@ function run(; cicfg::CIService=auto_detect_ci_service(; env=env), merge_new_packages::Bool, merge_new_versions::Bool, - new_package_waiting_period, + new_package_waiting_period::Dates.TimePeriod, new_jll_package_waiting_period, new_version_waiting_period, new_jll_version_waiting_period, @@ -161,6 +161,7 @@ function run(; public_registries=public_registries, read_only=read_only, environment_variables_to_pass=environment_variables_to_pass, + new_package_waiting_period=new_package_waiting_period, ) else always_assert(run_merge_build) diff --git a/src/AutoMerge/pull_requests.jl b/src/AutoMerge/pull_requests.jl index 72570f29..28f91a6d 100644 --- a/src/AutoMerge/pull_requests.jl +++ b/src/AutoMerge/pull_requests.jl @@ -89,6 +89,7 @@ function pull_request_build( public_registries::Vector{<:AbstractString}=String[], read_only::Bool, environment_variables_to_pass::Vector{<:AbstractString}=String[], + new_package_waiting_period::Dates.TimePeriod=new_package_waiting_period, )::Nothing pr = my_retry(() -> GitHub.pull_request(api, registry, pr_number; auth=auth)) _github_api_pr_head_commit_sha = pull_request_head_sha(pr) @@ -165,12 +166,12 @@ function pull_request_build( read_only=read_only, environment_variables_to_pass=environment_variables_to_pass, ) - pull_request_build(data; check_license=check_license) + pull_request_build(data; check_license=check_license, new_package_waiting_period=new_package_waiting_period) rm(registry_master; force=true, recursive=true) return nothing end -function pull_request_build(data::GitHubAutoMergeData; check_license)::Nothing +function pull_request_build(data::GitHubAutoMergeData; check_license, new_package_waiting_period::Dates.TimePeriod)::Nothing kind = package_or_version(data.registration_type) this_is_jll_package = is_jll_name(data.pkg) @info( @@ -231,7 +232,8 @@ function pull_request_build(data::GitHubAutoMergeData; check_license)::Nothing data.registration_type, data.suggest_onepointzero, data.version, - this_pr_can_use_special_jll_exceptions, + this_pr_can_use_special_jll_exceptions; + new_package_waiting_period ) my_retry(() -> update_automerge_comment!(data, this_pr_comment_pass)) else # failure diff --git a/src/AutoMerge/util.jl b/src/AutoMerge/util.jl index 9286843a..4caec442 100644 --- a/src/AutoMerge/util.jl +++ b/src/AutoMerge/util.jl @@ -153,7 +153,7 @@ function _comment_noblock(n) end function comment_text_pass( - ::NewVersion, suggest_onepointzero::Bool, version::VersionNumber, is_jll::Bool + ::NewVersion, suggest_onepointzero::Bool, version::VersionNumber, is_jll::Bool; new_package_waiting_period=nothing ) # Need to know this ahead of time to get the section numbers right suggest_onepointzero &= version < v"1.0.0" @@ -171,7 +171,7 @@ function comment_text_pass( end function comment_text_pass( - ::NewPackage, suggest_onepointzero::Bool, version::VersionNumber, is_jll::Bool + ::NewPackage, suggest_onepointzero::Bool, version::VersionNumber, is_jll::Bool; new_package_waiting_period::Dates.TimePeriod ) suggest_onepointzero &= version < v"1.0.0" if is_jll @@ -192,7 +192,7 @@ function comment_text_pass( _automerge_guidelines_passed_section_title(3), "Your new package registration met all of the ", "guidelines for auto-merging and is scheduled to ", - "be merged when the mandatory waiting period (3 days) has elapsed.\n\n", + "be merged when the mandatory waiting period ($new_package_waiting_period) has elapsed.\n\n", _onepointzero_suggestion(4, suggest_onepointzero, version), _comment_noblock(suggest_onepointzero ? 5 : 4), "", diff --git a/test/automerge-unit.jl b/test/automerge-unit.jl index c449f77a..c0390af2 100644 --- a/test/automerge-unit.jl +++ b/test/automerge-unit.jl @@ -59,7 +59,7 @@ function comment_reference_test() name = string("comment", "_pass_", pass, "_type_", type_name, "_suggest_onepointzero_", suggest_onepointzero, "_version_", version, "_is_jll_", is_jll) - @test_reference "reference_comments/$name.md" AutoMerge.comment_text_pass(type, suggest_onepointzero, version, is_jll) + @test_reference "reference_comments/$name.md" AutoMerge.comment_text_pass(type, suggest_onepointzero, version, is_jll; new_package_waiting_period=Day(3)) end else for point_to_slack in (true, false) @@ -84,6 +84,10 @@ end @testset "comment_reference_test" begin comment_reference_test() end + @testset "Customized `new_package_waiting_period` in AutoMerge comment " begin + text = AutoMerge.comment_text_pass(AutoMerge.NewPackage(), false, v"1", false; new_package_waiting_period=Minute(45)) + @test occursin("(45 minutes)", text) + end @testset "`AutoMerge.parse_registry_pkg_info`" begin registry_path = joinpath(DEPOT_PATH[1], "registries", "General") result = AutoMerge.parse_registry_pkg_info(registry_path, "RegistryCI", "1.0.0") From 8c39c37bdbd5aaee514c28d461c8f894d47b9801 Mon Sep 17 00:00:00 2001 From: Eric Hanson <5846501+ericphanson@users.noreply.github.com> Date: Wed, 31 Jan 2024 01:01:16 +0100 Subject: [PATCH 06/11] rm type annotation --- src/AutoMerge/public.jl | 2 +- src/AutoMerge/pull_requests.jl | 4 ++-- src/AutoMerge/util.jl | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/AutoMerge/public.jl b/src/AutoMerge/public.jl index 807caa8a..f759fe27 100644 --- a/src/AutoMerge/public.jl +++ b/src/AutoMerge/public.jl @@ -71,7 +71,7 @@ function run(; cicfg::CIService=auto_detect_ci_service(; env=env), merge_new_packages::Bool, merge_new_versions::Bool, - new_package_waiting_period::Dates.TimePeriod, + new_package_waiting_period, new_jll_package_waiting_period, new_version_waiting_period, new_jll_version_waiting_period, diff --git a/src/AutoMerge/pull_requests.jl b/src/AutoMerge/pull_requests.jl index 28f91a6d..53336e01 100644 --- a/src/AutoMerge/pull_requests.jl +++ b/src/AutoMerge/pull_requests.jl @@ -89,7 +89,7 @@ function pull_request_build( public_registries::Vector{<:AbstractString}=String[], read_only::Bool, environment_variables_to_pass::Vector{<:AbstractString}=String[], - new_package_waiting_period::Dates.TimePeriod=new_package_waiting_period, + new_package_waiting_period=new_package_waiting_period, )::Nothing pr = my_retry(() -> GitHub.pull_request(api, registry, pr_number; auth=auth)) _github_api_pr_head_commit_sha = pull_request_head_sha(pr) @@ -171,7 +171,7 @@ function pull_request_build( return nothing end -function pull_request_build(data::GitHubAutoMergeData; check_license, new_package_waiting_period::Dates.TimePeriod)::Nothing +function pull_request_build(data::GitHubAutoMergeData; check_license, new_package_waiting_period)::Nothing kind = package_or_version(data.registration_type) this_is_jll_package = is_jll_name(data.pkg) @info( diff --git a/src/AutoMerge/util.jl b/src/AutoMerge/util.jl index 4caec442..7b8b176e 100644 --- a/src/AutoMerge/util.jl +++ b/src/AutoMerge/util.jl @@ -171,7 +171,7 @@ function comment_text_pass( end function comment_text_pass( - ::NewPackage, suggest_onepointzero::Bool, version::VersionNumber, is_jll::Bool; new_package_waiting_period::Dates.TimePeriod + ::NewPackage, suggest_onepointzero::Bool, version::VersionNumber, is_jll::Bool; new_package_waiting_period, ) suggest_onepointzero &= version < v"1.0.0" if is_jll From 964524f1fc4df45078bf454dd80c2e217a763b6b Mon Sep 17 00:00:00 2001 From: Eric Hanson <5846501+ericphanson@users.noreply.github.com> Date: Wed, 31 Jan 2024 01:29:29 +0100 Subject: [PATCH 07/11] try to make old Julia's happy --- src/AutoMerge/util.jl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/AutoMerge/util.jl b/src/AutoMerge/util.jl index 7b8b176e..797ec712 100644 --- a/src/AutoMerge/util.jl +++ b/src/AutoMerge/util.jl @@ -171,7 +171,7 @@ function comment_text_pass( end function comment_text_pass( - ::NewPackage, suggest_onepointzero::Bool, version::VersionNumber, is_jll::Bool; new_package_waiting_period, + ::NewPackage, suggest_onepointzero::Bool, version::VersionNumber, is_jll::Bool; new_package_waiting_period=nothing, ) suggest_onepointzero &= version < v"1.0.0" if is_jll From 78bb751f70c20e35bda0cf557fedd7335024f0f7 Mon Sep 17 00:00:00 2001 From: Eric Hanson <5846501+ericphanson@users.noreply.github.com> Date: Wed, 31 Jan 2024 01:42:23 +0100 Subject: [PATCH 08/11] fix? --- src/AutoMerge/util.jl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/AutoMerge/util.jl b/src/AutoMerge/util.jl index 797ec712..7d07e5ca 100644 --- a/src/AutoMerge/util.jl +++ b/src/AutoMerge/util.jl @@ -171,7 +171,7 @@ function comment_text_pass( end function comment_text_pass( - ::NewPackage, suggest_onepointzero::Bool, version::VersionNumber, is_jll::Bool; new_package_waiting_period=nothing, + ::NewPackage, suggest_onepointzero::Bool, version::VersionNumber, is_jll::Bool; new_package_waiting_period=nothing ) suggest_onepointzero &= version < v"1.0.0" if is_jll From 0d124bc494ec7b869115d3d7fdf30d63945c03d7 Mon Sep 17 00:00:00 2001 From: Eric Hanson <5846501+ericphanson@users.noreply.github.com> Date: Wed, 31 Jan 2024 20:18:06 +0100 Subject: [PATCH 09/11] Update src/AutoMerge/pull_requests.jl --- src/AutoMerge/pull_requests.jl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/AutoMerge/pull_requests.jl b/src/AutoMerge/pull_requests.jl index 53336e01..4f2188f5 100644 --- a/src/AutoMerge/pull_requests.jl +++ b/src/AutoMerge/pull_requests.jl @@ -233,7 +233,7 @@ function pull_request_build(data::GitHubAutoMergeData; check_license, new_packag data.suggest_onepointzero, data.version, this_pr_can_use_special_jll_exceptions; - new_package_waiting_period + new_package_waiting_period=new_package_waiting_period ) my_retry(() -> update_automerge_comment!(data, this_pr_comment_pass)) else # failure From 7980b1a57d0962b9da5e791521f85ec829c1c229 Mon Sep 17 00:00:00 2001 From: Eric Hanson <5846501+ericphanson@users.noreply.github.com> Date: Wed, 31 Jan 2024 20:38:50 +0100 Subject: [PATCH 10/11] Apply suggestions from code review --- src/AutoMerge/util.jl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/AutoMerge/util.jl b/src/AutoMerge/util.jl index 7d07e5ca..550e38f3 100644 --- a/src/AutoMerge/util.jl +++ b/src/AutoMerge/util.jl @@ -153,7 +153,7 @@ function _comment_noblock(n) end function comment_text_pass( - ::NewVersion, suggest_onepointzero::Bool, version::VersionNumber, is_jll::Bool; new_package_waiting_period=nothing + ::NewVersion, suggest_onepointzero::Bool, version::VersionNumber, is_jll::Bool; new_package_waiting_period ) # Need to know this ahead of time to get the section numbers right suggest_onepointzero &= version < v"1.0.0" @@ -171,7 +171,7 @@ function comment_text_pass( end function comment_text_pass( - ::NewPackage, suggest_onepointzero::Bool, version::VersionNumber, is_jll::Bool; new_package_waiting_period=nothing + ::NewPackage, suggest_onepointzero::Bool, version::VersionNumber, is_jll::Bool; new_package_waiting_period ) suggest_onepointzero &= version < v"1.0.0" if is_jll From fb47260ef67e7e3a7669766717fc2e017e67f456 Mon Sep 17 00:00:00 2001 From: Eric Hanson <5846501+ericphanson@users.noreply.github.com> Date: Wed, 12 Jun 2024 21:06:39 +0200 Subject: [PATCH 11/11] add kwarg --- test/automerge-unit.jl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/automerge-unit.jl b/test/automerge-unit.jl index 0a1702be..95a6e020 100644 --- a/test/automerge-unit.jl +++ b/test/automerge-unit.jl @@ -61,7 +61,7 @@ function comment_reference_test() name = string("comment", "_pass_", pass, "_type_", type_name, "_suggest_onepointzero_", suggest_onepointzero, "_version_", version, "_is_jll_", is_jll) - @test_reference "reference_comments/$name.md" AutoMerge.comment_text_pass(type, suggest_onepointzero, version, is_jll) by=strip_equal + @test_reference "reference_comments/$name.md" AutoMerge.comment_text_pass(type, suggest_onepointzero, version, is_jll, new_package_waiting_period=Day(3)) by=strip_equal end else for point_to_slack in (true, false)