Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

copyGraph is using the wrong verb #1084

Open
dehann opened this issue Jul 11, 2024 · 1 comment
Open

copyGraph is using the wrong verb #1084

dehann opened this issue Jul 11, 2024 · 1 comment
Labels
Milestone

Comments

@dehann
Copy link
Member

dehann commented Jul 11, 2024

in call with Johan on verb Nouns for how to "get a copy of graph from one machine to another"

  • function merge!(dst, srcs...; *labels=:) # returns dst, is blocking
  • duplicate(src) = merge!(LocalDFG(), src) # is blocking (should this be a push or pull verb?)
  • clone(src) # does not overwrite
@dehann dehann added this to the v0.0.x milestone Jul 11, 2024
@dehann dehann added the design label Jul 11, 2024
@Affie
Copy link
Member

Affie commented Jul 11, 2024

I'm also considering get.

  • Currently the session noun, but there exists a session structure and it will be deprecated.
    • How to distinguish between getting the container and the container plus links.
    • getVariable gets the variable + satellites. Maybe only satellites included automatically in get.
  • save/load verbs uses noun DFG so getDFG(NvaClient, sessionLabel)
  • copy uses noun Graph so getGraph(NvaClient, sessionLabel)
  • We can also just use the save/load verbs as in FileDFG, so loadDFG(NvaDFG)->GraphsDFG

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants