-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ReshapedArrays support #771
Conversation
Co-authored-by: Dominique <[email protected]>
Co-authored-by: Dominique <[email protected]>
Co-authored-by: Dominique <[email protected]>
Still a draft cause i want to see if I can preserve sparsity |
Actually it makes no sense to preserve sparsity |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #771 +/- ##
==========================================
+ Coverage 97.98% 98.26% +0.28%
==========================================
Files 37 39 +2
Lines 6091 7107 +1016
==========================================
+ Hits 5968 6984 +1016
Misses 123 123 ☔ View full report in Codecov by Sentry. |
@gdalle May I ask you to rebase your PR? Is it still relevant? |
I don't even remember why I needed it anymore, it's probably from the time where ImplicitDifferentiation would do a lot of reshaping. Now it only accepts vectors so that's easier. Let's close this, I'll reopen if the need arises. |
Fix #770