Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReshapedArrays support #771

Closed
wants to merge 182 commits into from
Closed

Conversation

gdalle
Copy link

@gdalle gdalle commented Aug 9, 2023

Fix #770

@gdalle gdalle marked this pull request as draft August 9, 2023 16:58
@gdalle
Copy link
Author

gdalle commented Aug 9, 2023

Still a draft cause i want to see if I can preserve sparsity

@gdalle gdalle marked this pull request as ready for review August 9, 2023 17:05
@gdalle
Copy link
Author

gdalle commented Aug 9, 2023

Actually it makes no sense to preserve sparsity

@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Attention: Patch coverage is 97.78339% with 114 lines in your changes missing coverage. Please review.

Project coverage is 98.26%. Comparing base (8035437) to head (1d33fb6).
Report is 270 commits behind head on main.

Files with missing lines Patch % Lines
src/cr.jl 70.04% 68 Missing ⚠️
src/krylov_utils.jl 91.00% 17 Missing ⚠️
src/lslq.jl 96.41% 8 Missing ⚠️
src/craigmr.jl 95.54% 7 Missing ⚠️
src/lsmr.jl 97.58% 5 Missing ⚠️
src/lsqr.jl 97.39% 5 Missing ⚠️
src/craig.jl 98.69% 2 Missing ⚠️
src/krylov_solvers.jl 99.86% 1 Missing ⚠️
src/lnlq.jl 99.54% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #771      +/-   ##
==========================================
+ Coverage   97.98%   98.26%   +0.28%     
==========================================
  Files          37       39       +2     
  Lines        6091     7107    +1016     
==========================================
+ Hits         5968     6984    +1016     
  Misses        123      123              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2023

Package name latest stable
CaNNOLeS.jl
DCISolver.jl
FletcherPenaltySolver.jl
JSOSolvers.jl
LLSModels.jl
LinearSolve.jl
Percival.jl
RipQP.jl

@amontoison
Copy link
Member

amontoison commented Oct 14, 2024

@gdalle May I ask you to rebase your PR?
I didn't know that you opened a PR about the ReshapedArrays support.

Is it still relevant?

@gdalle
Copy link
Author

gdalle commented Oct 16, 2024

I don't even remember why I needed it anymore, it's probably from the time where ImplicitDifferentiation would do a lot of reshaping. Now it only accepts vectors so that's easier. Let's close this, I'll reopen if the need arises.

@gdalle gdalle closed this Oct 16, 2024
@gdalle gdalle deleted the reshapedarrays branch October 16, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ReshapedArrays support
6 participants