Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update with JSOBestieTemplate for Krylov #924

Merged
merged 3 commits into from
Nov 6, 2024
Merged

Conversation

tmigot
Copy link
Member

@tmigot tmigot commented Nov 1, 2024

Automated update using JSOBestieTemplate

@tmigot tmigot requested a review from amontoison November 2, 2024 14:47
@amontoison
Copy link
Member

amontoison commented Nov 2, 2024

@tmigot Why do you remove CommentPR.yml?
It allows to update the previous breakage message. Otherwise after 35 rebase, we have 35 messages and it's just spamming.

@amontoison amontoison force-pushed the update-jso-bestietemplate branch from e3d70f9 to 2ff619e Compare November 6, 2024 20:09
@JuliaSmoothOptimizers JuliaSmoothOptimizers deleted a comment from github-actions bot Nov 6, 2024
@JuliaSmoothOptimizers JuliaSmoothOptimizers deleted a comment from github-actions bot Nov 6, 2024
@amontoison amontoison merged commit f6f5a3f into main Nov 6, 2024
35 of 36 checks passed
@amontoison amontoison deleted the update-jso-bestietemplate branch November 6, 2024 20:14
@tmigot
Copy link
Member Author

tmigot commented Nov 6, 2024

Hi @amontoison ! Sorry, I didn't reply in time, I was also looking for some time to update the script. I see that you were faster :).
Can you open a PR here https://github.com/JuliaSmoothOptimizers/JSOBestieTemplate.jl to include your changes ?

@amontoison
Copy link
Member

amontoison commented Nov 6, 2024

It was planned :)
I just want to check if it works as intended before in the PR #927.

@tmigot
Copy link
Member Author

tmigot commented Nov 6, 2024

Also, note that with this script we only cover JSO packages in the Breakage.
So, if you would want to test other packages I would suggest to add another script Krylov.jl-specific.

Copy link
Contributor

github-actions bot commented Nov 6, 2024

Package name latest stable
AdaptiveRegularization
CaNNOLeS
DCISolver
FletcherPenaltySolver
JSOSolvers
PartiallySeparableNLPModels
PartiallySeparableSolvers
PartitionedVectors
Percival
RipQP

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants